qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org
Cc: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Subject: [PULL 04/16] net: unbreak well-form id check for "-nic"
Date: Fri, 12 Mar 2021 14:16:14 +0800	[thread overview]
Message-ID: <1615529786-30763-5-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1615529786-30763-1-git-send-email-jasowang@redhat.com>

The auto genreated id for "-nic" has "_" prefix which can't satisfy
the well-formed id check that is introduced by
871579b9834aca517dc2d4941691a1d2082db6f2 ("net: validate that ids are
well formed"). Fix this by simply removing the "__" prefix.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 net/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/net.c b/net/net.c
index d36729f..254b42f 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1479,7 +1479,7 @@ static int net_param_nic(void *dummy, QemuOpts *opts, Error **errp)
     /* Create an ID if the user did not specify one */
     nd_id = g_strdup(qemu_opts_id(opts));
     if (!nd_id) {
-        nd_id = g_strdup_printf("__org.qemu.nic%i", idx);
+        nd_id = g_strdup_printf("org.qemu.nic%i", idx);
         qemu_opts_set_id(opts, nd_id);
     }
 
-- 
2.7.4



  parent reply	other threads:[~2021-03-12  6:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  6:16 [PULL 00/16] Net patches Jason Wang
2021-03-12  6:16 ` [PULL 01/16] virtio-net: calculating proper msix vectors on init Jason Wang
2021-03-12  6:16 ` [PULL 02/16] net: Fix build error when DEBUG_NET is on Jason Wang
2021-03-12  6:16 ` [PULL 03/16] net: validate that ids are well formed Jason Wang
2021-03-12  8:44   ` Paolo Bonzini
2021-03-12 13:26     ` Jason Wang
2021-03-12 14:23       ` Paolo Bonzini
2021-03-12  6:16 ` Jason Wang [this message]
2021-03-12  6:16 ` [PULL 05/16] e1000: fail early for evil descriptor Jason Wang
2021-03-12  6:16 ` [PULL 06/16] net: introduce qemu_receive_packet() Jason Wang
2021-03-12  6:16 ` [PULL 07/16] e1000: switch to use qemu_receive_packet() for loopback Jason Wang
2021-03-12  6:16 ` [PULL 08/16] dp8393x: switch to use qemu_receive_packet() for loopback packet Jason Wang
2021-03-12  6:16 ` [PULL 09/16] msf2-mac: switch to use qemu_receive_packet() for loopback Jason Wang
2021-03-12  6:16 ` [PULL 10/16] sungem: " Jason Wang
2021-03-12  6:16 ` [PULL 11/16] tx_pkt: switch to use qemu_receive_packet_iov() " Jason Wang
2021-03-12  6:16 ` [PULL 12/16] rtl8139: switch to use qemu_receive_packet() " Jason Wang
2021-03-12  6:16 ` [PULL 13/16] pcnet: " Jason Wang
2021-03-12  6:16 ` [PULL 14/16] cadence_gem: " Jason Wang
2021-03-12  6:16 ` [PULL 15/16] lan9118: " Jason Wang
2021-03-12  6:16 ` [PULL 16/16] pvrdma: wean code off pvrdma_ring.h kernel header Jason Wang
2021-03-14 11:37 ` [PULL 00/16] Net patches Peter Maydell
2021-03-15  3:35   ` Jason Wang
2021-03-15  5:39   ` Thomas Huth
2021-03-15  8:07     ` Jason Wang
2021-03-15  9:52       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1615529786-30763-5-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).