From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org
Cc: Jason Wang <jasowang@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Prasad J Pandit <ppandit@redhat.com>
Subject: [PULL 05/16] e1000: fail early for evil descriptor
Date: Fri, 12 Mar 2021 14:16:15 +0800 [thread overview]
Message-ID: <1615529786-30763-6-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1615529786-30763-1-git-send-email-jasowang@redhat.com>
During procss_tx_desc(), driver can try to chain data descriptor with
legacy descriptor, when will lead underflow for the following
calculation in process_tx_desc() for bytes:
if (tp->size + bytes > msh)
bytes = msh - tp->size;
This will lead a infinite loop. So check and fail early if tp->size if
greater or equal to msh.
Reported-by: Alexander Bulekov <alxndr@bu.edu>
Reported-by: Cheolwoo Myung <cwmyung@snu.ac.kr>
Reported-by: Ruhr-University Bochum <bugs-syssec@rub.de>
Cc: Prasad J Pandit <ppandit@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/e1000.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index d8da2f6..4345d86 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -670,6 +670,9 @@ process_tx_desc(E1000State *s, struct e1000_tx_desc *dp)
msh = tp->tso_props.hdr_len + tp->tso_props.mss;
do {
bytes = split_size;
+ if (tp->size >= msh) {
+ goto eop;
+ }
if (tp->size + bytes > msh)
bytes = msh - tp->size;
@@ -695,6 +698,7 @@ process_tx_desc(E1000State *s, struct e1000_tx_desc *dp)
tp->size += split_size;
}
+eop:
if (!(txd_lower & E1000_TXD_CMD_EOP))
return;
if (!(tp->cptse && tp->size < tp->tso_props.hdr_len)) {
--
2.7.4
next prev parent reply other threads:[~2021-03-12 6:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 6:16 [PULL 00/16] Net patches Jason Wang
2021-03-12 6:16 ` [PULL 01/16] virtio-net: calculating proper msix vectors on init Jason Wang
2021-03-12 6:16 ` [PULL 02/16] net: Fix build error when DEBUG_NET is on Jason Wang
2021-03-12 6:16 ` [PULL 03/16] net: validate that ids are well formed Jason Wang
2021-03-12 8:44 ` Paolo Bonzini
2021-03-12 13:26 ` Jason Wang
2021-03-12 14:23 ` Paolo Bonzini
2021-03-12 6:16 ` [PULL 04/16] net: unbreak well-form id check for "-nic" Jason Wang
2021-03-12 6:16 ` Jason Wang [this message]
2021-03-12 6:16 ` [PULL 06/16] net: introduce qemu_receive_packet() Jason Wang
2021-03-12 6:16 ` [PULL 07/16] e1000: switch to use qemu_receive_packet() for loopback Jason Wang
2021-03-12 6:16 ` [PULL 08/16] dp8393x: switch to use qemu_receive_packet() for loopback packet Jason Wang
2021-03-12 6:16 ` [PULL 09/16] msf2-mac: switch to use qemu_receive_packet() for loopback Jason Wang
2021-03-12 6:16 ` [PULL 10/16] sungem: " Jason Wang
2021-03-12 6:16 ` [PULL 11/16] tx_pkt: switch to use qemu_receive_packet_iov() " Jason Wang
2021-03-12 6:16 ` [PULL 12/16] rtl8139: switch to use qemu_receive_packet() " Jason Wang
2021-03-12 6:16 ` [PULL 13/16] pcnet: " Jason Wang
2021-03-12 6:16 ` [PULL 14/16] cadence_gem: " Jason Wang
2021-03-12 6:16 ` [PULL 15/16] lan9118: " Jason Wang
2021-03-12 6:16 ` [PULL 16/16] pvrdma: wean code off pvrdma_ring.h kernel header Jason Wang
2021-03-14 11:37 ` [PULL 00/16] Net patches Peter Maydell
2021-03-15 3:35 ` Jason Wang
2021-03-15 5:39 ` Thomas Huth
2021-03-15 8:07 ` Jason Wang
2021-03-15 9:52 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615529786-30763-6-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).