* [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons
@ 2021-03-15 4:55 Taylor Simpson
2021-03-15 9:43 ` Philippe Mathieu-Daudé
2021-03-15 19:49 ` Richard Henderson
0 siblings, 2 replies; 4+ messages in thread
From: Taylor Simpson @ 2021-03-15 4:55 UTC (permalink / raw)
To: qemu-devel; +Cc: philmd, tsimpson, richard.henderson
Address feedback from Richard Henderson <<richard.henderson@linaro.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
target/hexagon/gen_tcg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
index e044dea..a30048e 100644
--- a/target/hexagon/gen_tcg.h
+++ b/target/hexagon/gen_tcg.h
@@ -83,9 +83,9 @@
#define fGEN_TCG_L2_loadrub_pr(SHORTCODE) SHORTCODE
#define fGEN_TCG_L2_loadrub_pi(SHORTCODE) SHORTCODE
#define fGEN_TCG_L2_loadrb_pr(SHORTCODE) SHORTCODE
-#define fGEN_TCG_L2_loadrb_pi(SHORTCODE) SHORTCODE;
+#define fGEN_TCG_L2_loadrb_pi(SHORTCODE) SHORTCODE
#define fGEN_TCG_L2_loadruh_pr(SHORTCODE) SHORTCODE
-#define fGEN_TCG_L2_loadruh_pi(SHORTCODE) SHORTCODE;
+#define fGEN_TCG_L2_loadruh_pi(SHORTCODE) SHORTCODE
#define fGEN_TCG_L2_loadrh_pr(SHORTCODE) SHORTCODE
#define fGEN_TCG_L2_loadrh_pi(SHORTCODE) SHORTCODE
#define fGEN_TCG_L2_loadri_pr(SHORTCODE) SHORTCODE
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons
2021-03-15 4:55 [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons Taylor Simpson
@ 2021-03-15 9:43 ` Philippe Mathieu-Daudé
2021-04-30 16:55 ` Laurent Vivier
2021-03-15 19:49 ` Richard Henderson
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-15 9:43 UTC (permalink / raw)
To: Taylor Simpson, qemu-devel, QEMU Trivial; +Cc: richard.henderson
On 3/15/21 5:55 AM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
>
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> target/hexagon/gen_tcg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
> index e044dea..a30048e 100644
> --- a/target/hexagon/gen_tcg.h
> +++ b/target/hexagon/gen_tcg.h
> @@ -83,9 +83,9 @@
> #define fGEN_TCG_L2_loadrub_pr(SHORTCODE) SHORTCODE
> #define fGEN_TCG_L2_loadrub_pi(SHORTCODE) SHORTCODE
> #define fGEN_TCG_L2_loadrb_pr(SHORTCODE) SHORTCODE
> -#define fGEN_TCG_L2_loadrb_pi(SHORTCODE) SHORTCODE;
> +#define fGEN_TCG_L2_loadrb_pi(SHORTCODE) SHORTCODE
> #define fGEN_TCG_L2_loadruh_pr(SHORTCODE) SHORTCODE
> -#define fGEN_TCG_L2_loadruh_pi(SHORTCODE) SHORTCODE;
> +#define fGEN_TCG_L2_loadruh_pi(SHORTCODE) SHORTCODE
> #define fGEN_TCG_L2_loadrh_pr(SHORTCODE) SHORTCODE
> #define fGEN_TCG_L2_loadrh_pi(SHORTCODE) SHORTCODE
> #define fGEN_TCG_L2_loadri_pr(SHORTCODE) SHORTCODE
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons
2021-03-15 4:55 [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons Taylor Simpson
2021-03-15 9:43 ` Philippe Mathieu-Daudé
@ 2021-03-15 19:49 ` Richard Henderson
1 sibling, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2021-03-15 19:49 UTC (permalink / raw)
To: Taylor Simpson, qemu-devel; +Cc: philmd
On 3/14/21 10:55 PM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
>
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
> target/hexagon/gen_tcg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Queued.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons
2021-03-15 9:43 ` Philippe Mathieu-Daudé
@ 2021-04-30 16:55 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-04-30 16:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Taylor Simpson, qemu-devel,
QEMU Trivial
Cc: richard.henderson
Le 15/03/2021 à 10:43, Philippe Mathieu-Daudé a écrit :
> On 3/15/21 5:55 AM, Taylor Simpson wrote:
>> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
>>
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
>> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
>> ---
>> target/hexagon/gen_tcg.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
>> index e044dea..a30048e 100644
>> --- a/target/hexagon/gen_tcg.h
>> +++ b/target/hexagon/gen_tcg.h
>> @@ -83,9 +83,9 @@
>> #define fGEN_TCG_L2_loadrub_pr(SHORTCODE) SHORTCODE
>> #define fGEN_TCG_L2_loadrub_pi(SHORTCODE) SHORTCODE
>> #define fGEN_TCG_L2_loadrb_pr(SHORTCODE) SHORTCODE
>> -#define fGEN_TCG_L2_loadrb_pi(SHORTCODE) SHORTCODE;
>> +#define fGEN_TCG_L2_loadrb_pi(SHORTCODE) SHORTCODE
>> #define fGEN_TCG_L2_loadruh_pr(SHORTCODE) SHORTCODE
>> -#define fGEN_TCG_L2_loadruh_pi(SHORTCODE) SHORTCODE;
>> +#define fGEN_TCG_L2_loadruh_pi(SHORTCODE) SHORTCODE
>> #define fGEN_TCG_L2_loadrh_pr(SHORTCODE) SHORTCODE
>> #define fGEN_TCG_L2_loadrh_pi(SHORTCODE) SHORTCODE
>> #define fGEN_TCG_L2_loadri_pr(SHORTCODE) SHORTCODE
>>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-30 17:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-15 4:55 [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons Taylor Simpson
2021-03-15 9:43 ` Philippe Mathieu-Daudé
2021-04-30 16:55 ` Laurent Vivier
2021-03-15 19:49 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).