* [Trivial] docs: More precisely describe memory-backend-*::id's user
@ 2021-04-22 8:42 Robert Hoo
2021-05-01 2:29 ` Robert Hoo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Robert Hoo @ 2021-04-22 8:42 UTC (permalink / raw)
To: mjt, laurent, qemu-trivial; +Cc: robert.hu, qemu-devel, Robert Hoo
'id' of memory-backend-{file,ram} is not only for '-numa''s reference, but
also other parameters like '-device nvdimm'.
More clearly call out this to avoid misinterpretation.
Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
---
qemu-options.hx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index fd21002..635dc8a 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4508,11 +4508,11 @@ SRST
the guest RAM with huge pages.
The ``id`` parameter is a unique ID that will be used to
- reference this memory region when configuring the ``-numa``
- argument.
+ reference this memory region in other parameters, e.g. ``-numa``,
+ ``-device nvdimm``, etc.
The ``size`` option provides the size of the memory region, and
- accepts common suffixes, eg ``500M``.
+ accepts common suffixes, e.g. ``500M``.
The ``mem-path`` provides the path to either a shared memory or
huge page filesystem mount.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Trivial] docs: More precisely describe memory-backend-*::id's user
2021-04-22 8:42 [Trivial] docs: More precisely describe memory-backend-*::id's user Robert Hoo
@ 2021-05-01 2:29 ` Robert Hoo
2021-05-01 5:50 ` Markus Armbruster
2021-05-01 9:58 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Robert Hoo @ 2021-05-01 2:29 UTC (permalink / raw)
To: mjt, laurent, qemu-trivial; +Cc: robert.hu, qemu-devel
Ping for review ...
Thanks.
On Thu, 2021-04-22 at 16:42 +0800, Robert Hoo wrote:
> 'id' of memory-backend-{file,ram} is not only for '-numa''s
> reference, but
> also other parameters like '-device nvdimm'.
> More clearly call out this to avoid misinterpretation.
>
> Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
> ---
> qemu-options.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index fd21002..635dc8a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -4508,11 +4508,11 @@ SRST
> the guest RAM with huge pages.
>
> The ``id`` parameter is a unique ID that will be used to
> - reference this memory region when configuring the ``-numa``
> - argument.
> + reference this memory region in other parameters, e.g. ``-
> numa``,
> + ``-device nvdimm``, etc.
>
> The ``size`` option provides the size of the memory region,
> and
> - accepts common suffixes, eg ``500M``.
> + accepts common suffixes, e.g. ``500M``.
>
> The ``mem-path`` provides the path to either a shared memory
> or
> huge page filesystem mount.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Trivial] docs: More precisely describe memory-backend-*::id's user
2021-04-22 8:42 [Trivial] docs: More precisely describe memory-backend-*::id's user Robert Hoo
2021-05-01 2:29 ` Robert Hoo
@ 2021-05-01 5:50 ` Markus Armbruster
2021-05-01 9:58 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2021-05-01 5:50 UTC (permalink / raw)
To: Robert Hoo; +Cc: qemu-trivial, robert.hu, mjt, laurent, qemu-devel
Robert Hoo <robert.hu@linux.intel.com> writes:
> 'id' of memory-backend-{file,ram} is not only for '-numa''s reference, but
> also other parameters like '-device nvdimm'.
> More clearly call out this to avoid misinterpretation.
>
> Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
> ---
> qemu-options.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index fd21002..635dc8a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -4508,11 +4508,11 @@ SRST
> the guest RAM with huge pages.
>
> The ``id`` parameter is a unique ID that will be used to
> - reference this memory region when configuring the ``-numa``
> - argument.
> + reference this memory region in other parameters, e.g. ``-numa``,
> + ``-device nvdimm``, etc.
>
> The ``size`` option provides the size of the memory region, and
> - accepts common suffixes, eg ``500M``.
> + accepts common suffixes, e.g. ``500M``.
>
> The ``mem-path`` provides the path to either a shared memory or
> huge page filesystem mount.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Trivial] docs: More precisely describe memory-backend-*::id's user
2021-04-22 8:42 [Trivial] docs: More precisely describe memory-backend-*::id's user Robert Hoo
2021-05-01 2:29 ` Robert Hoo
2021-05-01 5:50 ` Markus Armbruster
@ 2021-05-01 9:58 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-05-01 9:58 UTC (permalink / raw)
To: Robert Hoo, mjt, qemu-trivial; +Cc: robert.hu, qemu-devel
Le 22/04/2021 à 10:42, Robert Hoo a écrit :
> 'id' of memory-backend-{file,ram} is not only for '-numa''s reference, but
> also other parameters like '-device nvdimm'.
> More clearly call out this to avoid misinterpretation.
>
> Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
> ---
> qemu-options.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index fd21002..635dc8a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -4508,11 +4508,11 @@ SRST
> the guest RAM with huge pages.
>
> The ``id`` parameter is a unique ID that will be used to
> - reference this memory region when configuring the ``-numa``
> - argument.
> + reference this memory region in other parameters, e.g. ``-numa``,
> + ``-device nvdimm``, etc.
>
> The ``size`` option provides the size of the memory region, and
> - accepts common suffixes, eg ``500M``.
> + accepts common suffixes, e.g. ``500M``.
>
> The ``mem-path`` provides the path to either a shared memory or
> huge page filesystem mount.
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-01 10:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-22 8:42 [Trivial] docs: More precisely describe memory-backend-*::id's user Robert Hoo
2021-05-01 2:29 ` Robert Hoo
2021-05-01 5:50 ` Markus Armbruster
2021-05-01 9:58 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).