Re: [PULL 00/48] ppc-for-6.1 queue 20210519

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210519125148.27720-1-david@gibson.dropbear.id.au/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210519125148.27720-1-david@gibson.dropbear.id.au
Subject: [PULL 00/48] ppc-for-6.1 queue 20210519

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/0799f0de89ad2482672b5d61d0de61e6eba782da.1621407918.git.alishir@routerhosting.com -> patchew/0799f0de89ad2482672b5d61d0de61e6eba782da.1621407918.git.alishir@routerhosting.com
 - [tag update]      patchew/20210519053940.1888907-1-kraxel@redhat.com -> patchew/20210519053940.1888907-1-kraxel@redhat.com
 - [tag update]      patchew/20210519113840.298174-1-thuth@redhat.com -> patchew/20210519113840.298174-1-thuth@redhat.com
 * [new tag]         patchew/20210519125148.27720-1-david@gibson.dropbear.id.au -> patchew/20210519125148.27720-1-david@gibson.dropbear.id.au
Switched to a new branch 'test'
3c00fdf target/ppc: Remove type argument for mmubooke206_get_physical_address
60016bb target/ppc: Remove type argument from mmubooke206_check_tlb
7c11f08 target/ppc: Remove type argument from mmubooke_get_physical_address
5b6598c target/ppc: Remove type argument from mmubooke_check_tlb
a5d9124 target/ppc: Remove type argument from mmu40x_get_physical_address
6303499 target/ppc: Remove type argument from get_bat_6xx_tlb
1909f07 target/ppc: Remove type argument from ppc6xx_tlb_check
9c7354d target/ppc: Remove type argument from ppc6xx_tlb_pte_check
6554abd target/ppc: Remove type argument from check_prot
67377cb target/ppc: Use MMUAccessType in mmu_helper.c
38dbc23 target/ppc: Rename access_type to type in mmu_helper.c
8455e55 target/ppc: Use MMUAccessType in mmu-hash32.c
5d0dd44 target/ppc: Use MMUAccessType in mmu-hash64.c
30623d8 target/ppc: Use MMUAccessType in mmu-radix64.c
6f28cd1 target/ppc: Introduce prot_for_access_type
68af5d8 target/ppc: Fix load endianness for lxvwsx/lxvdsx
8cd5c2d target/ppc: Use translator_loop_temp_check
7dec420 target/ppc: Mark helper_raise_exception* as noreturn
23e15df target/ppc: Tidy exception vs exit_tb
4793076 target/ppc: Move single-step check to ppc_tr_tb_stop
22f5784 target/ppc: Remove DisasContext.exception
95de7c0 target/ppc: Replace POWERPC_EXCP_BRANCH with DISAS_NORETURN
f23b326 target/ppc: Replace POWERPC_EXCP_STOP with DISAS_EXIT_UPDATE
1fc4915 target/ppc: Introduce gen_icount_io_start
0e86c00 target/ppc: Remove unnecessary gen_io_end calls
b2ca732 target/ppc: Replace POWERPC_EXCP_SYNC with DISAS_EXIT
70875f5 target/ppc: Introduce DISAS_{EXIT,CHAIN}{,_UPDATE}
4915e7b target/ppc: Simplify gen_debug_exception
a398d05 target/ppc: Remove special case for POWERPC_EXCP_TRAP
f986c3a target/ppc: Remove special case for POWERPC_SYSCALL
4a93c7b target/ppc: Move DISAS_NORETURN setting into gen_exception*
c9f2edc target/ppc: Split out decode_legacy
e224276 target/ppc: Add cia field to DisasContext
5253f5d target/ppc: moved ppc_cpu_dump_state to cpu_init.c
121b6dd target/ppc: moved ppc_store_sdr1 to cpu.c
b091081 target/ppc: updated vscr manipulation in machine.c
6fea522 target/ppc: created ppc_{store, get}_vscr for generic vscr usage
98d7adb target/ppc: isolated cpu init from translation logic
b69a5c9 target/ppc: turned SPR R/W callbacks not static
a57c158 hw/ppc: moved has_spr to cpu.h
2648581 target/ppc: moved ppc_store_lpcr to misc_helper.c
c9e6564 target/ppc: moved function out of mmu-hash64
94817f2 hw/ppc: moved hcalls that depend on softmmu
fb0f4cf target/ppc: move SPR R/W callbacks to translate.c
386aa35 target/ppc: renamed SPR registration functions
b0e64f0 target/ppc: Fold gen_*_xer into their callers
508bb8b hw/ppc/spapr.c: Make sure the host supports the selected MMU mode
2cddc9b hw/ppc/spapr.c: Extract MMU mode error reporting into a function

=== OUTPUT BEGIN ===
1/48 Checking commit 2cddc9bc2c66 (hw/ppc/spapr.c: Extract MMU mode error reporting into a function)
2/48 Checking commit 508bb8b7cc99 (hw/ppc/spapr.c: Make sure the host supports the selected MMU mode)
3/48 Checking commit b0e64f06d98a (target/ppc: Fold gen_*_xer into their callers)
4/48 Checking commit 386aa355b0f6 (target/ppc: renamed SPR registration functions)
5/48 Checking commit fb0f4cf4a3b8 (target/ppc: move SPR R/W callbacks to translate.c)
ERROR: if this code is redundant consider removing it
#35: FILE: target/ppc/translate.c:377:
+#if 0

total: 1 errors, 0 warnings, 2122 lines checked

Patch 5/48 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/48 Checking commit 94817f265d3b (hw/ppc: moved hcalls that depend on softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#723: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#790: FILE: hw/ppc/spapr_softmmu.c:63:
+        /* FIXME: What WIMG combinations could be sensible for IO?

WARNING: Block comments use a trailing */ on a separate line
#791: FILE: hw/ppc/spapr_softmmu.c:64:
+         * For now we allow WIMG=010x, but are there others? */

ERROR: spaces required around that '*' (ctx:VxV)
#929: FILE: hw/ppc/spapr_softmmu.c:202:
+        target_ulong *tsh = &args[i*2];
                                    ^

ERROR: spaces required around that '*' (ctx:VxV)
#930: FILE: hw/ppc/spapr_softmmu.c:203:
+        target_ulong tsl = args[i*2 + 1];
                                  ^

WARNING: Block comments use a leading /* on a separate line
#1048: FILE: hw/ppc/spapr_softmmu.c:321:
+    /* These fields are private to the preparation thread if

WARNING: Block comments use a trailing */ on a separate line
#1049: FILE: hw/ppc/spapr_softmmu.c:322:
+     * !complete, otherwise protected by the BQL */

WARNING: Block comments use a leading /* on a separate line
#1148: FILE: hw/ppc/spapr_softmmu.c:421:
+    /* In theory we could estimate the time more accurately based on

WARNING: Block comments use a trailing */ on a separate line
#1149: FILE: hw/ppc/spapr_softmmu.c:422:
+     * the new size, but there's not much point */

WARNING: line over 80 characters
#1363: FILE: include/hw/ppc/spapr.h:585:
+target_ulong softmmu_resize_hpt_prepare(PowerPCCPU *cpu, SpaprMachineState *spapr,

WARNING: line over 80 characters
#1365: FILE: include/hw/ppc/spapr.h:587:
+target_ulong softmmu_resize_hpt_commit(PowerPCCPU *cpu, SpaprMachineState *spapr,

total: 2 errors, 9 warnings, 1318 lines checked

Patch 6/48 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/48 Checking commit c9e65648f02d (target/ppc: moved function out of mmu-hash64)
8/48 Checking commit 26485812507d (target/ppc: moved ppc_store_lpcr to misc_helper.c)
9/48 Checking commit a57c1580fdbf (hw/ppc: moved has_spr to cpu.h)
10/48 Checking commit b69a5c97885f (target/ppc: turned SPR R/W callbacks not static)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 914 lines checked

Patch 10/48 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/48 Checking commit 98d7adb620c6 (target/ppc: isolated cpu init from translation logic)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
 target/ppc/{translate_init.c.inc => cpu_init.c} | 8 ++++++++

total: 0 errors, 1 warnings, 69 lines checked

Patch 11/48 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/48 Checking commit 6fea52250ee6 (target/ppc: created ppc_{store, get}_vscr for generic vscr usage)
13/48 Checking commit b091081afee1 (target/ppc: updated vscr manipulation in machine.c)
14/48 Checking commit 121b6ddc4c0d (target/ppc: moved ppc_store_sdr1 to cpu.c)
15/48 Checking commit 5253f5dbefff (target/ppc: moved ppc_cpu_dump_state to cpu_init.c)
ERROR: braces {} are necessary for all arms of this statement
#68: FILE: target/ppc/cpu_init.c:9410:
+    for (i = 0; i < 8; i++)
[...]

total: 1 errors, 0 warnings, 379 lines checked

Patch 15/48 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/48 Checking commit e224276774ea (target/ppc: Add cia field to DisasContext)
17/48 Checking commit c9f2edcc8918 (target/ppc: Split out decode_legacy)
18/48 Checking commit 4a93c7b82c58 (target/ppc: Move DISAS_NORETURN setting into gen_exception*)
19/48 Checking commit f986c3a091e9 (target/ppc: Remove special case for POWERPC_SYSCALL)
20/48 Checking commit a398d054848a (target/ppc: Remove special case for POWERPC_EXCP_TRAP)
21/48 Checking commit 4915e7b46b12 (target/ppc: Simplify gen_debug_exception)
22/48 Checking commit 70875f54b21e (target/ppc: Introduce DISAS_{EXIT,CHAIN}{,_UPDATE})
23/48 Checking commit b2ca73208c0a (target/ppc: Replace POWERPC_EXCP_SYNC with DISAS_EXIT)
24/48 Checking commit 0e86c0020724 (target/ppc: Remove unnecessary gen_io_end calls)
25/48 Checking commit 1fc491598e1b (target/ppc: Introduce gen_icount_io_start)
26/48 Checking commit f23b32676f8e (target/ppc: Replace POWERPC_EXCP_STOP with DISAS_EXIT_UPDATE)
27/48 Checking commit 95de7c0a4a7c (target/ppc: Replace POWERPC_EXCP_BRANCH with DISAS_NORETURN)
28/48 Checking commit 22f5784678ff (target/ppc: Remove DisasContext.exception)
29/48 Checking commit 4793076f453b (target/ppc: Move single-step check to ppc_tr_tb_stop)
30/48 Checking commit 23e15dfc2760 (target/ppc: Tidy exception vs exit_tb)
31/48 Checking commit 7dec420b826f (target/ppc: Mark helper_raise_exception* as noreturn)
32/48 Checking commit 8cd5c2d65dc9 (target/ppc: Use translator_loop_temp_check)
33/48 Checking commit 68af5d84a321 (target/ppc: Fix load endianness for lxvwsx/lxvdsx)
34/48 Checking commit 6f28cd1c5fc2 (target/ppc: Introduce prot_for_access_type)
35/48 Checking commit 30623d847c0a (target/ppc: Use MMUAccessType in mmu-radix64.c)
WARNING: line over 80 characters
#180: FILE: target/ppc/mmu-radix64.c:314:
+        ppc_radix64_check_prot(cpu, access_type, pte, &fault_cause, h_prot, true)) {

WARNING: line over 80 characters
#186: FILE: target/ppc/mmu-radix64.c:319:
+            ppc_radix64_raise_hsi(cpu, access_type, eaddr, g_raddr, fault_cause);

WARNING: line over 80 characters
#237: FILE: target/ppc/mmu-radix64.c:435:
+    if (ppc_radix64_check_prot(cpu, access_type, pte, &fault_cause, g_prot, false)) {

WARNING: line over 80 characters
#283: FILE: target/ppc/mmu-radix64.c:501:
+                ppc_radix64_raise_si(cpu, access_type, eaddr, DSISR_R_BADCONFIG);

total: 0 errors, 4 warnings, 297 lines checked

Patch 35/48 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/48 Checking commit 5d0dd4436d1c (target/ppc: Use MMUAccessType in mmu-hash64.c)
37/48 Checking commit 8455e55a84bf (target/ppc: Use MMUAccessType in mmu-hash32.c)
38/48 Checking commit 38dbc2393d2c (target/ppc: Rename access_type to type in mmu_helper.c)
39/48 Checking commit 67377cbdf7ed (target/ppc: Use MMUAccessType in mmu_helper.c)
WARNING: line over 80 characters
#468: FILE: target/ppc/mmu_helper.c:1644:
+                    env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, MMU_DATA_LOAD);

WARNING: line over 80 characters
#504: FILE: target/ppc/mmu_helper.c:1731:
+                    booke206_update_mas_tlb_miss(env, address, access_type, mmu_idx);

WARNING: line over 80 characters
#511: FILE: target/ppc/mmu_helper.c:1737:
+                    env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, access_type);

WARNING: line over 80 characters
#527: FILE: target/ppc/mmu_helper.c:1761:
+                    env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, access_type);

total: 0 errors, 4 warnings, 484 lines checked

Patch 39/48 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/48 Checking commit 6554abd1d707 (target/ppc: Remove type argument from check_prot)
41/48 Checking commit 9c7354d07797 (target/ppc: Remove type argument from ppc6xx_tlb_pte_check)
42/48 Checking commit 1909f072e0db (target/ppc: Remove type argument from ppc6xx_tlb_check)
43/48 Checking commit 630349901c5b (target/ppc: Remove type argument from get_bat_6xx_tlb)
44/48 Checking commit a5d9124882e1 (target/ppc: Remove type argument from mmu40x_get_physical_address)
45/48 Checking commit 5b6598c37d9d (target/ppc: Remove type argument from mmubooke_check_tlb)
46/48 Checking commit 7c11f08b10a1 (target/ppc: Remove type argument from mmubooke_get_physical_address)
47/48 Checking commit 60016bb16305 (target/ppc: Remove type argument from mmubooke206_check_tlb)
48/48 Checking commit 3c00fdfe685b (target/ppc: Remove type argument for mmubooke206_get_physical_address)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210519125148.27720-1-david@gibson.dropbear.id.au/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com