From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bU9SP-0003sM-LN for qemu-devel@nongnu.org; Mon, 01 Aug 2016 05:24:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bU9SM-0004Ox-6o for qemu-devel@nongnu.org; Mon, 01 Aug 2016 05:24:21 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:54991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bU9SL-0004Os-Pl for qemu-devel@nongnu.org; Mon, 01 Aug 2016 05:24:18 -0400 Date: Mon, 1 Aug 2016 05:24:14 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1621526280.10219655.1470043454030.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1468953718-27661-1-git-send-email-armbru@redhat.com> <1468953718-27661-3-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_10219653_207767768.1470043454027" Subject: Re: [Qemu-devel] [PULL v2 for-2.7 02/15] qapi: change QmpInputVisitor to QSLIST List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Laszlo Ersek , Markus Armbruster , Eric Blake , Gerd Hoffmann , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau ------=_Part_10219653_207767768.1470043454027 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi ----- Original Message ----- > > > On 27/07/2016 23:37, Laszlo Ersek wrote: > > It seems to me that QEMU deadlocks when it tries to emit the > > SPICE_DISCONNECTED event. > > > > (Note that I can't find "handle SPICE_DISCONNECTED" in the libvirtd log > > even in the successful case (i.e., when QEMU is built at the parent of > > 3d344c2aabb7).) > > > > Apparently audio_atexit() is triggered when QEMU is returning from > > main() -- or calling exit() --, which somehow results in QEMU trying to > > send a SPICE_DISCONNECTED event through the monitor? I guess the monitor > > has been long dead by then. > > > > Hmmm, this gives me an idea... What happens if I remove the following > > fragment from my domain XML? > > > > > >
> function='0x0'/> > > > > > > Yeah, the hang disappears, shutdown works just fine. It's a spice audio > > bug after all, apparently. Sorry for reporting it in this thread! :) I'm > > adding Gerd to the address list. > > > > To reiterate: this patch (commit 3d344c2aabb7) does *not* cause the > > symptom, it only exposes an independent bug that causes the symptom. > > And, I can work around that for now, by removing sound devices. > > I think the issue here is that the monitor is gone by the time > audio_atexit is called. It is caused by commit > c1111a24a3358ecd2f17be7c8b117cfe8bc5e5f8. > > The fix is to move the audio_atexit call to main before > qemu_chr_cleanup, but I'm not sure how to deal with coreaudio_atexit. alternatively, cleanup the monitor before cleaning up the chardev? I was just looking at that, see wip patch attached. ------=_Part_10219653_207767768.1470043454027 Content-Type: text/x-patch; name=0001-monitor-fix-crash-when-leaving-qemu-with-spice-audio.patch Content-Disposition: attachment; filename=0001-monitor-fix-crash-when-leaving-qemu-with-spice-audio.patch Content-Transfer-Encoding: base64 RnJvbSA2ZDhkZTkwZWFmMTI4ODNhODc3MjFmYTY3YjY3Y2VjZmE5YTY3NDUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWFyYy1BbmRyPUMzPUE5PTIwTHVyZWF1Pz0g PG1hcmNhbmRyZS5sdXJlYXVAcmVkaGF0LmNvbT4KRGF0ZTogTW9uLCAxIEF1ZyAyMDE2IDEzOjE2 OjU1ICswNDAwClN1YmplY3Q6IFtQQVRDSF0gbW9uaXRvcjogZml4IGNyYXNoIHdoZW4gbGVhdmlu ZyBxZW11IHdpdGggc3BpY2UgYXVkaW8KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0 ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQK ClNpbmNlIGFhNWNiN2Y1ZSwgdGhlIGNoYXJkZXZzIGFyZSBiZWluZyBjbGVhbmVkIHVwIHdoZW4g bGVhdmluZwpxZW11LiBIb3dldmVyLCB0aGUgbW9uaXRvciBoYXMgc3RpbGwgcmVmZXJlbmNlcyB0 byB0aGVtLCB3aGljaCBtYXkKbGVhZCB0byBjcmFzaGVzIHdoZW4gcnVubmluZyBhdGV4aXQoKSBh bmQgdHJ5aW5nIHRvIHNlbmQgbW9uaXRvcgpldmVudHM6CgogIzAgIDB4MDAwMDdmZmZkYjE4ZjZm NSBpbiBfX0dJX3JhaXNlIChzaWc9c2lnQGVudHJ5PTYpIGF0IC4uL3N5c2RlcHMvdW5peC9zeXN2 L2xpbnV4L3JhaXNlLmM6NTQKICMxICAweDAwMDA3ZmZmZGIxOTEyZmEgaW4gX19HSV9hYm9ydCAo KSBhdCBhYm9ydC5jOjg5CiAjMiAgMHgwMDAwNTU1NTU1YzI2M2U3IGluIGVycm9yX2V4aXQgKGVy cj0yMiwgbXNnPTB4NTU1NTU1ZDQ3OTgwIDxfX2Z1bmNfXy4xMzUzNz4gInFlbXVfbXV0ZXhfbG9j ayIpIGF0IHV0aWwvcWVtdS10aHJlYWQtcG9zaXguYzozOQogIzMgIDB4MDAwMDU1NTU1NWMyNjQ4 OCBpbiBxZW11X211dGV4X2xvY2sgKG11dGV4PTB4NTU1NTU2N2EyNDIwKSBhdCB1dGlsL3FlbXUt dGhyZWFkLXBvc2l4LmM6NjYKICM0ICAweDAwMDA1NTU1NTU4YzUyZGIgaW4gcWVtdV9jaHJfZmVf d3JpdGUgKHM9MHg1NTU1NTY3YTI0MjAsIGJ1Zj0weDU1NTU1NzQwZGM0MCAie1widGltZXN0YW1w XCI6IHtcInNlY29uZHNcIjogMTQ3MDA0MTcxNiwgXCJtaWNyb3NlY29uZHNcIjogOTg5Njk5fSwg XCJldmVudFwiOiBcIlNQSUNFX0RJU0NPTk5FQ1RFRFwiLCBcImRhdGFcIjoge1wic2VydmVyXCI6 IHtcInBvcnRcIjogXCI1OTAwXCIsIFwiZmFtaWx5XCI6IFwiaXB2NFwiLCBcImhvc3RcIjogXCIx MjcuMC4wLjFcIn0sIFwiY2xpZW50XCI6IHtcInBvcnRcIjogXCI0MDI3MlwiLCBcImYiLi4uLCBs ZW49MjQwKSBhdCBxZW11LWNoYXIuYzoyODAKICM1ICAweDAwMDA1NTU1NTU3ODdjYWQgaW4gbW9u aXRvcl9mbHVzaF9sb2NrZWQgKG1vbj0weDU1NTU1NjdiZDllMCkgYXQgL2hvbWUvZWxtYXJjby9z cmMvcWVtdS9tb25pdG9yLmM6MzExCiAjNiAgMHgwMDAwNTU1NTU1Nzg3ZTQ2IGluIG1vbml0b3Jf cHV0cyAobW9uPTB4NTU1NTU2N2JkOWUwLCBzdHI9MHg1NTU1NTY3YTQ0ZWYgIiIpIGF0IC9ob21l L2VsbWFyY28vc3JjL3FlbXUvbW9uaXRvci5jOjM1MwogIzcgIDB4MDAwMDU1NTU1NTc4ODBmZSBp biBtb25pdG9yX2pzb25fZW1pdHRlciAobW9uPTB4NTU1NTU2N2JkOWUwLCBkYXRhPTB4NTU1NTU2 N2M3M2EwKSBhdCAvaG9tZS9lbG1hcmNvL3NyYy9xZW11L21vbml0b3IuYzo0MDEKICM4ICAweDAw MDA1NTU1NTU3ODgyZDIgaW4gbW9uaXRvcl9xYXBpX2V2ZW50X2VtaXQgKGV2ZW50PVFBUElfRVZF TlRfU1BJQ0VfRElTQ09OTkVDVEVELCBxZGljdD0weDU1NTU1NjdjNzNhMCkgYXQgL2hvbWUvZWxt YXJjby9zcmMvcWVtdS9tb25pdG9yLmM6NDcyCiAjOSAgMHgwMDAwNTU1NTU1Nzg4MzhmIGluIG1v bml0b3JfcWFwaV9ldmVudF9xdWV1ZSAoZXZlbnQ9UUFQSV9FVkVOVF9TUElDRV9ESVNDT05ORUNU RUQsIHFkaWN0PTB4NTU1NTU2N2M3M2EwLCBlcnJwPTB4N2ZmZmZmZmZjYTg4KSBhdCAvaG9tZS9l bG1hcmNvL3NyYy9xZW11L21vbml0b3IuYzo0OTcKICMxMCAweDAwMDA1NTU1NTVjMTU1NDEgaW4g cWFwaV9ldmVudF9zZW5kX3NwaWNlX2Rpc2Nvbm5lY3RlZCAoc2VydmVyPTB4NTU1NTU3MTEzOWQw LCBjbGllbnQ9MHg1NTU1NTcwZDBkYjAsIGVycnA9MHg1NTU1NTY2YzA0MjggPGVycm9yX2Fib3J0 PikgYXQgcWFwaS1ldmVudC5jOjEwMzgKICMxMSAweDAwMDA1NTU1NTViMTFiYzYgaW4gY2hhbm5l bF9ldmVudCAoZXZlbnQ9MywgaW5mbz0weDU1NTU1NzBkNmMwMCkgYXQgdWkvc3BpY2UtY29yZS5j OjI0OAogIzEyIDB4MDAwMDdmZmZkY2M5OTgzYSBpbiBhZGFwdGVyX2NoYW5uZWxfZXZlbnQgKGV2 ZW50PTMsIGluZm89MHg1NTU1NTcwZDZjMDApIGF0IHJlZHMuYzoxMjAKICMxMyAweDAwMDA3ZmZm ZGNjOTlhMjUgaW4gcmVkc19oYW5kbGVfY2hhbm5lbF9ldmVudCAocmVkcz0weDU1NTU1NjdhOWQ2 MCwgZXZlbnQ9MywgaW5mbz0weDU1NTU1NzBkNmMwMCkgYXQgcmVkcy5jOjMyNAogIzE0IDB4MDAw MDdmZmZkY2M3ZDRjNCBpbiBtYWluX2Rpc3BhdGNoZXJfc2VsZl9oYW5kbGVfY2hhbm5lbF9ldmVu dCAoc2VsZj0weDU1NTU1NjdiMjhiMCwgZXZlbnQ9MywgaW5mbz0weDU1NTU1NzBkNmMwMCkgYXQg bWFpbi1kaXNwYXRjaGVyLmM6MTc1CiAjMTUgMHgwMDAwN2ZmZmRjYzdkNWIxIGluIG1haW5fZGlz cGF0Y2hlcl9jaGFubmVsX2V2ZW50IChzZWxmPTB4NTU1NTU2N2IyOGIwLCBldmVudD0zLCBpbmZv PTB4NTU1NTU3MGQ2YzAwKSBhdCBtYWluLWRpc3BhdGNoZXIuYzoxOTQKICMxNiAweDAwMDA3ZmZm ZGNjYTc2NzQgaW4gcmVkc19zdHJlYW1fcHVzaF9jaGFubmVsX2V2ZW50IChzPTB4NTU1NTU3MGQ5 OTEwLCBldmVudD0zKSBhdCByZWRzLXN0cmVhbS5jOjM1NAogIzE3IDB4MDAwMDdmZmZkY2NhNzQ5 YiBpbiByZWRzX3N0cmVhbV9mcmVlIChzPTB4NTU1NTU3MGQ5OTEwKSBhdCByZWRzLXN0cmVhbS5j OjMyMwogIzE4IDB4MDAwMDdmZmZkY2NiNWRhZCBpbiBzbmRfZGlzY29ubmVjdF9jaGFubmVsIChj aGFubmVsPTB4NTU1NTU3NmE4OWEwKSBhdCBzb3VuZC5jOjIyOQogIzE5IDB4MDAwMDdmZmZkY2Ni OWU1NyBpbiBzbmRfZGV0YWNoX2NvbW1vbiAod29ya2VyPTB4NTU1NTU3NzM5NzIwKSBhdCBzb3Vu ZC5jOjE1ODkKICMyMCAweDAwMDA3ZmZmZGNjYjlmMGUgaW4gc25kX2RldGFjaF9wbGF5YmFjayAo c2luPTB4NTU1NTU2OWZlM2Y4KSBhdCBzb3VuZC5jOjE2MDIKICMyMSAweDAwMDA3ZmZmZGNjYTMz NzMgaW4gc3BpY2Vfc2VydmVyX3JlbW92ZV9pbnRlcmZhY2UgKHNpbj0weDU1NTU1NjlmZTNmOCkg YXQgcmVkcy5jOjMzODcKICMyMiAweDAwMDA1NTU1NTU4ZmY2ZTIgaW4gbGluZV9vdXRfZmluaSAo aHc9MHg1NTU1NTY5ZmUzNzApIGF0IGF1ZGlvL3NwaWNlYXVkaW8uYzoxNTIKICMyMyAweDAwMDA1 NTU1NTU4ZjkwOWUgaW4gYXVkaW9fYXRleGl0ICgpIGF0IGF1ZGlvL2F1ZGlvLmM6MTc1NAogIzI0 IDB4MDAwMDdmZmZkYjE5NDFlOCBpbiBfX3J1bl9leGl0X2hhbmRsZXJzIChzdGF0dXM9MCwgbGlz dHA9MHg3ZmZmZGI1MTc1ZDggPF9fZXhpdF9mdW5jcz4sIHJ1bl9saXN0X2F0ZXhpdD1ydW5fbGlz dF9hdGV4aXRAZW50cnk9dHJ1ZSkgYXQgZXhpdC5jOjgyCiAjMjUgMHgwMDAwN2ZmZmRiMTk0MjM1 IGluIF9fR0lfZXhpdCAoc3RhdHVzPTxvcHRpbWl6ZWQgb3V0PikgYXQgZXhpdC5jOjEwNAogIzI2 IDB4MDAwMDdmZmZkYjE3YjczOCBpbiBfX2xpYmNfc3RhcnRfbWFpbiAobWFpbj0weDU1NTU1NThk Nzg3NCA8bWFpbj4sIGFyZ2M9NjcsIGFyZ3Y9MHg3ZmZmZmZmZmNmNDgsIGluaXQ9PG9wdGltaXpl ZCBvdXQ+LCBmaW5pPTxvcHRpbWl6ZWQgb3V0PiwgcnRsZF9maW5pPTxvcHRpbWl6ZWQgb3V0Piwg c3RhY2tfZW5kPTB4N2ZmZmZmZmZjZjM4KSBhdCAuLi9jc3UvbGliYy1zdGFydC5jOjMyMwoKQWRk IGEgbW9uaXRvcl9jbGVhbnVwKCkgZnVuY3Rpb25zIHRvIHJlbW92ZSBhbGwgdGhlIG1vbml0b3Jz IGJlZm9yZQpjbGVhbmluZyB1cCB0aGUgY2hhcmRldi4gTm90ZSB0aGF0IHdlIGFyZSAibG9zaW5n IiBzb21lIGV2ZW50cyB0aGF0CnVzZWQgdG8gYmUgc2VudCBkdXJpbmcgYXRleGl0KCkuCgpTaWdu ZWQtb2ZmLWJ5OiBNYXJjLUFuZHLDqSBMdXJlYXUgPG1hcmNhbmRyZS5sdXJlYXVAcmVkaGF0LmNv bT4KLS0tCiBtb25pdG9yLmMgICAgICAgICAgICAgICAgIHwgMjAgKysrKysrKysrKysrKysrKysr KysKIGluY2x1ZGUvbW9uaXRvci9tb25pdG9yLmggfCAgMSArCiB2bC5jICAgICAgICAgICAgICAg ICAgICAgIHwgIDEgKwogMyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvbW9uaXRvci5jIGIvbW9uaXRvci5jCmluZGV4IDVkNjhhNWQuLjVjMDAzNzMgMTAwNjQ0 Ci0tLSBhL21vbml0b3IuYworKysgYi9tb25pdG9yLmMKQEAgLTYzNSw2ICs2MzUsMTMgQEAgc3Rh dGljIHZvaWQgbW9uaXRvcl9kYXRhX2luaXQoTW9uaXRvciAqbW9uKQogCiBzdGF0aWMgdm9pZCBt b25pdG9yX2RhdGFfZGVzdHJveShNb25pdG9yICptb24pCiB7CisgICAgaWYgKG1vbi0+Y2hyKSB7 CisgICAgICAgIHFlbXVfY2hyX2FkZF9oYW5kbGVycyhtb24tPmNociwgTlVMTCwgTlVMTCwgTlVM TCwgTlVMTCk7CisgICAgfQorICAgIGlmIChtb25pdG9yX2lzX3FtcChtb24pKSB7CisgICAgICAg IGpzb25fbWVzc2FnZV9wYXJzZXJfZGVzdHJveSgmbW9uLT5xbXAucGFyc2VyKTsKKyAgICB9Cisg ICAgZ19mcmVlKG1vbi0+cnMpOwogICAgIFFERUNSRUYobW9uLT5vdXRidWYpOwogICAgIHFlbXVf bXV0ZXhfZGVzdHJveSgmbW9uLT5vdXRfbG9jayk7CiB9CkBAIC00MTk2LDYgKzQyMDMsMTkgQEAg dm9pZCBtb25pdG9yX2luaXQoQ2hhckRyaXZlclN0YXRlICpjaHIsIGludCBmbGFncykKICAgICBx ZW11X211dGV4X3VubG9jaygmbW9uaXRvcl9sb2NrKTsKIH0KIAordm9pZCBtb25pdG9yX2NsZWFu dXAodm9pZCkKK3sKKyAgICBNb25pdG9yICptb24sICpuZXh0OworCisgICAgcWVtdV9tdXRleF9s b2NrKCZtb25pdG9yX2xvY2spOworICAgIFFMSVNUX0ZPUkVBQ0hfU0FGRShtb24sICZtb25fbGlz dCwgZW50cnksIG5leHQpIHsKKyAgICAgICAgUUxJU1RfUkVNT1ZFKG1vbiwgZW50cnkpOworICAg ICAgICBtb25pdG9yX2RhdGFfZGVzdHJveShtb24pOworICAgICAgICBnX2ZyZWUobW9uKTsKKyAg ICB9CisgICAgcWVtdV9tdXRleF91bmxvY2soJm1vbml0b3JfbG9jayk7Cit9CisKIHN0YXRpYyB2 b2lkIGJkcnZfcGFzc3dvcmRfY2Iodm9pZCAqb3BhcXVlLCBjb25zdCBjaGFyICpwYXNzd29yZCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqcmVhZGxpbmVfb3BhcXVlKQogewpk aWZmIC0tZ2l0IGEvaW5jbHVkZS9tb25pdG9yL21vbml0b3IuaCBiL2luY2x1ZGUvbW9uaXRvci9t b25pdG9yLmgKaW5kZXggYzVjOWVhMi4uYTcxNGQ4ZSAxMDA2NDQKLS0tIGEvaW5jbHVkZS9tb25p dG9yL21vbml0b3IuaAorKysgYi9pbmNsdWRlL21vbml0b3IvbW9uaXRvci5oCkBAIC0xNyw2ICsx Nyw3IEBAIGV4dGVybiBNb25pdG9yICpjdXJfbW9uOwogYm9vbCBtb25pdG9yX2N1cl9pc19xbXAo dm9pZCk7CiAKIHZvaWQgbW9uaXRvcl9pbml0KENoYXJEcml2ZXJTdGF0ZSAqY2hyLCBpbnQgZmxh Z3MpOwordm9pZCBtb25pdG9yX2NsZWFudXAodm9pZCk7CiAKIGludCBtb25pdG9yX3N1c3BlbmQo TW9uaXRvciAqbW9uKTsKIHZvaWQgbW9uaXRvcl9yZXN1bWUoTW9uaXRvciAqbW9uKTsKZGlmZiAt LWdpdCBhL3ZsLmMgYi92bC5jCmluZGV4IGU3YzJjNjIuLmExNGM0MzggMTAwNjQ0Ci0tLSBhL3Zs LmMKKysrIGIvdmwuYwpAQCAtNDYxMiw2ICs0NjEyLDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNo YXIgKiphcmd2LCBjaGFyICoqZW52cCkKIAogICAgIC8qIHZob3N0LXVzZXIgbXVzdCBiZSBjbGVh bmVkIHVwIGJlZm9yZSBjaGFyZGV2cy4gICovCiAgICAgbmV0X2NsZWFudXAoKTsKKyAgICBtb25p dG9yX2NsZWFudXAoKTsKICAgICBxZW11X2Nocl9jbGVhbnVwKCk7CiAKICAgICByZXR1cm4gMDsK LS0gCjIuOS4wCgo= ------=_Part_10219653_207767768.1470043454027--