From: Lei Rao <lei.rao@intel.com>
To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com,
jasowang@redhat.com, zhang.zhanghailiang@huawei.com,
quintela@redhat.com, dgilbert@redhat.com, lukasstraub2@web.de
Cc: like.xu.linux@gmail.com, "Rao, Lei" <lei.rao@intel.com>,
qemu-devel@nongnu.org
Subject: [PATCH 5/7] Removed the qemu_fclose() in colo_process_incoming_thread
Date: Thu, 17 Jun 2021 10:47:13 +0800 [thread overview]
Message-ID: <1623898035-18533-6-git-send-email-lei.rao@intel.com> (raw)
In-Reply-To: <1623898035-18533-1-git-send-email-lei.rao@intel.com>
From: "Rao, Lei" <lei.rao@intel.com>
After the live migration, the related fd will be cleanup in
migration_incoming_state_destroy(). So, the qemu_close()
in colo_process_incoming_thread is not necessary.
Signed-off-by: Lei Rao <lei.rao@intel.com>
---
migration/colo.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index c25e488..e2ab349 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -919,11 +919,6 @@ out:
/* Hope this not to be too long to loop here */
qemu_sem_wait(&mis->colo_incoming_sem);
qemu_sem_destroy(&mis->colo_incoming_sem);
- /* Must be called after failover BH is completed */
- if (mis->to_src_file) {
- qemu_fclose(mis->to_src_file);
- mis->to_src_file = NULL;
- }
rcu_unregister_thread();
return NULL;
--
1.8.3.1
next prev parent reply other threads:[~2021-06-17 2:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 2:47 [PATCH 0/7] Fixed some bugs and optimized some codes for COLO Lei Rao
2021-06-17 2:47 ` [PATCH 1/7] Some minor optimizations " Lei Rao
2021-06-29 17:58 ` Dr. David Alan Gilbert
2021-06-17 2:47 ` [PATCH 2/7] Fixed qemu crash when guest power off in COLO mode Lei Rao
2021-06-17 2:47 ` [PATCH 3/7] Fixed SVM hang when do failover before PVM crash Lei Rao
2021-06-17 5:50 ` lizhijian
2021-06-17 2:47 ` [PATCH 4/7] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff Lei Rao
2021-07-03 20:36 ` Lukas Straub
2021-07-05 2:54 ` Rao, Lei
2021-07-05 9:06 ` Rao, Lei
2021-06-17 2:47 ` Lei Rao [this message]
2021-06-17 2:47 ` [PATCH 6/7] Changed the last-mode to none of first start COLO Lei Rao
2021-06-17 2:47 ` [PATCH 7/7] Optimized the function of fill_connection_key Lei Rao
2021-07-28 6:25 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623898035-18533-6-git-send-email-lei.rao@intel.com \
--to=lei.rao@intel.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=like.xu.linux@gmail.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).