From: Taylor Simpson <tsimpson@quicinc.com>
To: qemu-devel@nongnu.org
Cc: ale@rev.ng, philmd@redhat.com, tsimpson@quicinc.com,
richard.henderson@linaro.org, bcain@quicinc.com
Subject: [PULL 4/4] Hexagon (target/hexagon) remove unused TCG variables
Date: Fri, 18 Jun 2021 14:06:42 -0500 [thread overview]
Message-ID: <1624043202-20124-5-git-send-email-tsimpson@quicinc.com> (raw)
In-Reply-To: <1624043202-20124-1-git-send-email-tsimpson@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1622589584-22571-5-git-send-email-tsimpson@quicinc.com>
---
target/hexagon/genptr.c | 6 ------
target/hexagon/translate.c | 11 ++---------
2 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c
index bd18cb1..5dbabe0 100644
--- a/target/hexagon/genptr.c
+++ b/target/hexagon/genptr.c
@@ -121,10 +121,7 @@ static void gen_log_reg_write_pair(int rnum, TCGv_i64 val)
static inline void gen_log_pred_write(DisasContext *ctx, int pnum, TCGv val)
{
- TCGv zero = tcg_const_tl(0);
TCGv base_val = tcg_temp_new();
- TCGv and_val = tcg_temp_new();
- TCGv pred_written = tcg_temp_new();
tcg_gen_andi_tl(base_val, val, 0xff);
@@ -143,10 +140,7 @@ static inline void gen_log_pred_write(DisasContext *ctx, int pnum, TCGv val)
}
tcg_gen_ori_tl(hex_pred_written, hex_pred_written, 1 << pnum);
- tcg_temp_free(zero);
tcg_temp_free(base_val);
- tcg_temp_free(and_val);
- tcg_temp_free(pred_written);
}
static inline void gen_read_p3_0(TCGv control_reg)
diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c
index 9a37644..b23d36a 100644
--- a/target/hexagon/translate.c
+++ b/target/hexagon/translate.c
@@ -273,7 +273,6 @@ static void gen_reg_writes(DisasContext *ctx)
static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
{
- TCGv zero, control_reg, pval;
int i;
/* Early exit if the log is empty */
@@ -281,10 +280,6 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
return;
}
- zero = tcg_const_tl(0);
- control_reg = tcg_temp_new();
- pval = tcg_temp_new();
-
/*
* Only endloop instructions will conditionally
* write a predicate. If there are no endloop
@@ -292,6 +287,7 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
* write of the predicates.
*/
if (pkt->pkt_has_endloop) {
+ TCGv zero = tcg_const_tl(0);
TCGv pred_written = tcg_temp_new();
for (i = 0; i < ctx->preg_log_idx; i++) {
int pred_num = ctx->preg_log[i];
@@ -302,6 +298,7 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
hex_new_pred_value[pred_num],
hex_pred[pred_num]);
}
+ tcg_temp_free(zero);
tcg_temp_free(pred_written);
} else {
for (i = 0; i < ctx->preg_log_idx; i++) {
@@ -314,10 +311,6 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
}
}
}
-
- tcg_temp_free(zero);
- tcg_temp_free(control_reg);
- tcg_temp_free(pval);
}
static void gen_check_store_width(DisasContext *ctx, int slot_num)
--
2.7.4
next prev parent reply other threads:[~2021-06-18 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 19:06 [PULL 0/4] Hexagon (target/hexagon) bug fixes Taylor Simpson
2021-06-18 19:06 ` [PULL 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW* Taylor Simpson
2021-06-18 19:06 ` [PULL 2/4] Hexagon (target/hexagon) fix l2fetch instructions Taylor Simpson
2021-06-18 19:06 ` [PULL 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions Taylor Simpson
2021-06-18 19:06 ` Taylor Simpson [this message]
2021-06-23 14:31 ` [PULL 0/4] Hexagon (target/hexagon) bug fixes Taylor Simpson
2021-06-23 16:50 ` Peter Maydell
2021-06-29 8:51 ` Peter Maydell
2021-06-29 12:18 ` Peter Maydell
2021-06-29 16:28 ` Taylor Simpson
[not found] <1623966755-30225-1-git-send-email-tsimpson@quicinc.com>
2021-06-17 21:52 ` [PULL 4/4] Hexagon (target/hexagon) remove unused TCG variables Taylor Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1624043202-20124-5-git-send-email-tsimpson@quicinc.com \
--to=tsimpson@quicinc.com \
--cc=ale@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).