From: Taylor Simpson <tsimpson@quicinc.com>
To: qemu-devel@nongnu.org
Cc: ale@rev.ng, bcain@quicinc.com, tsimpson@quicinc.com,
richard.henderson@linaro.org, f4bug@amsat.org
Subject: [PATCH v4 00/30] Hexagon HVX (target/hexagon) patch series
Date: Tue, 12 Oct 2021 05:10:38 -0500 [thread overview]
Message-ID: <1634033468-23566-1-git-send-email-tsimpson@quicinc.com> (raw)
This series adds support for the Hexagon Vector eXtensions (HVX)
These instructions are documented here
https://developer.qualcomm.com/downloads/qualcomm-hexagon-v66-hvx-programmer-s-reference-manual
Hexagon HVX is a wide vector engine with 128 byte vectors.
See patch 01 Hexagon HVX README for more information.
*** Known checkpatch issues ***
The following are known checkpatch errors in the series
target/hexagon/gen_semantics.c Suspicious ; after while (0)
tests/tcg/hexagon/hvx_misc.c Spaces around operator in macro invocation
*** Changes in v4 ***
Address feedback from Richard Henderson <richard.henderson@linaro.org>
- Use tcg_gen_gvec_orc/tcg_gen_gvec_andc
Add tests for the following opcodes
V6_pred_or
V6_pred_or_n
V6_pred_and
V6_pred_and_n
V6_pred_xor
Probe the HVX stores at the beginning of gen_commit_packet
See patches 11 (helper functions) and 12 (TCG generation)
Use tcg_constant_* instead of tcg_const_*
*** Changes in v3 ***
Clean up gen_log_vreg_write
- Remove has_vhist parameter
Remove VRegs_updated_tmp from runtime state
- Check there is exactly one tmp for vhist at TCG generation time
Remove VRegs_select from runtime state
Add test_max_temps test to tests/tcg/hexagon/hvx_misc.c
Don't pass slot to HVX helpers
*** Changes in v2 ***
Address feedback from Richard Henderson <richard.henderson@linaro.org>
- Remove zero_vector from CPUHexagonState
- Remove gather_issued from CPUHexagonState
- Remove is_gather_store_insn from DisasContext and CPUHexagonState
- Change VStoreLog.mask to a bitmap
- Change VTCMStoreLog.mask to a bitmap
- Convert future_VRegs, tmp_Vregs to allocate as-needed
- Don't cast away const
- Remove/simplify count_leading_ones_2
- Control HVX dump with CPU_DUMP_FPU
Remove HVX support from target/hexagon/gdbstub.c
- Hexagon uses lldb which will require support for qRegisterInfo in the
target-independent gdbstub. Will contribute this separately
Convert the histogram instructions to execute at the end of packet commit
- This is necessary to allocate future_VRegs as-needed
Additional tests added in tests/tcg/hexagon
Added helper overrides for several instructions
- As a result, cleaned up utility functions
Additional_cleanup
- Change TCGv_ptr to not _local_
- Remove env argument from gen_commit_hvx
Taylor Simpson (30):
Hexagon HVX (target/hexagon) README
Hexagon HVX (target/hexagon) add Hexagon Vector eXtensions (HVX) to
core
Hexagon HVX (target/hexagon) register names
Hexagon HVX (target/hexagon) instruction attributes
Hexagon HVX (target/hexagon) macros
Hexagon HVX (target/hexagon) import macro definitions
Hexagon HVX (target/hexagon) semantics generator
Hexagon HVX (target/hexagon) semantics generator - part 2
Hexagon HVX (target/hexagon) C preprocessor for decode tree
Hexagon HVX (target/hexagon) instruction utility functions
Hexagon HVX (target/hexagon) helper functions
Hexagon HVX (target/hexagon) TCG generation
Hexagon HVX (target/hexagon) helper overrides infrastructure
Hexagon HVX (target/hexagon) helper overrides for histogram
instructions
Hexagon HVX (target/hexagon) helper overrides - vector assign & cmov
Hexagon HVX (target/hexagon) helper overrides - vector add & sub
Hexagon HVX (target/hexagon) helper overrides - vector shifts
Hexagon HVX (target/hexagon) helper overrides - vector max/min
Hexagon HVX (target/hexagon) helper overrides - vector logical ops
Hexagon HVX (target/hexagon) helper overrides - vector compares
Hexagon HVX (target/hexagon) helper overrides - vector splat and abs
Hexagon HVX (target/hexagon) helper overrides - vector loads
Hexagon HVX (target/hexagon) helper overrides - vector stores
Hexagon HVX (target/hexagon) import semantics
Hexagon HVX (target/hexagon) instruction decoding
Hexagon HVX (target/hexagon) import instruction encodings
Hexagon HVX (tests/tcg/hexagon) vector_add_int test
Hexagon HVX (tests/tcg/hexagon) hvx_misc test
Hexagon HVX (tests/tcg/hexagon) scatter_gather test
Hexagon HVX (tests/tcg/hexagon) histogram test
target/hexagon/cpu.h | 35 +-
target/hexagon/gen_tcg_hvx.h | 903 +++++++++
target/hexagon/helper.h | 16 +
target/hexagon/hex_arch_types.h | 5 +
target/hexagon/hex_regs.h | 1 +
target/hexagon/insn.h | 3 +
target/hexagon/internal.h | 3 +
target/hexagon/macros.h | 22 +
target/hexagon/mmvec/decode_ext_mmvec.h | 24 +
target/hexagon/mmvec/macros.h | 354 ++++
target/hexagon/mmvec/mmvec.h | 83 +
target/hexagon/mmvec/system_ext_mmvec.h | 29 +
target/hexagon/translate.h | 61 +
tests/tcg/hexagon/hvx_histogram_input.h | 717 +++++++
tests/tcg/hexagon/hvx_histogram_row.h | 24 +
target/hexagon/attribs_def.h.inc | 22 +
target/hexagon/cpu.c | 80 +-
target/hexagon/decode.c | 28 +-
target/hexagon/gen_dectree_import.c | 13 +
target/hexagon/gen_semantics.c | 33 +
target/hexagon/genptr.c | 188 ++
target/hexagon/mmvec/decode_ext_mmvec.c | 236 +++
target/hexagon/mmvec/system_ext_mmvec.c | 66 +
target/hexagon/op_helper.c | 282 ++-
target/hexagon/translate.c | 243 ++-
tests/tcg/hexagon/hvx_histogram.c | 88 +
tests/tcg/hexagon/hvx_misc.c | 469 +++++
tests/tcg/hexagon/scatter_gather.c | 1011 ++++++++++
tests/tcg/hexagon/vector_add_int.c | 61 +
target/hexagon/README | 81 +-
target/hexagon/gen_helper_funcs.py | 115 +-
target/hexagon/gen_helper_protos.py | 19 +-
target/hexagon/gen_tcg_funcs.py | 257 ++-
target/hexagon/hex_common.py | 13 +
target/hexagon/imported/allext.idef | 25 +
target/hexagon/imported/allext_macros.def | 25 +
target/hexagon/imported/allextenc.def | 20 +
target/hexagon/imported/allidefs.def | 1 +
target/hexagon/imported/encode.def | 1 +
target/hexagon/imported/macros.def | 88 +
target/hexagon/imported/mmvec/encode_ext.def | 794 ++++++++
target/hexagon/imported/mmvec/ext.idef | 2606 ++++++++++++++++++++++++++
target/hexagon/imported/mmvec/macros.def | 842 +++++++++
target/hexagon/meson.build | 15 +-
tests/tcg/hexagon/Makefile.target | 12 +
tests/tcg/hexagon/hvx_histogram_row.S | 294 +++
46 files changed, 10261 insertions(+), 47 deletions(-)
create mode 100644 target/hexagon/gen_tcg_hvx.h
create mode 100644 target/hexagon/mmvec/decode_ext_mmvec.h
create mode 100644 target/hexagon/mmvec/macros.h
create mode 100644 target/hexagon/mmvec/mmvec.h
create mode 100644 target/hexagon/mmvec/system_ext_mmvec.h
create mode 100644 tests/tcg/hexagon/hvx_histogram_input.h
create mode 100644 tests/tcg/hexagon/hvx_histogram_row.h
create mode 100644 target/hexagon/mmvec/decode_ext_mmvec.c
create mode 100644 target/hexagon/mmvec/system_ext_mmvec.c
create mode 100644 tests/tcg/hexagon/hvx_histogram.c
create mode 100644 tests/tcg/hexagon/hvx_misc.c
create mode 100644 tests/tcg/hexagon/scatter_gather.c
create mode 100644 tests/tcg/hexagon/vector_add_int.c
create mode 100644 target/hexagon/imported/allext.idef
create mode 100644 target/hexagon/imported/allext_macros.def
create mode 100644 target/hexagon/imported/allextenc.def
create mode 100644 target/hexagon/imported/mmvec/encode_ext.def
create mode 100644 target/hexagon/imported/mmvec/ext.idef
create mode 100755 target/hexagon/imported/mmvec/macros.def
create mode 100644 tests/tcg/hexagon/hvx_histogram_row.S
--
2.7.4
next reply other threads:[~2021-10-12 10:17 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 10:10 Taylor Simpson [this message]
2021-10-12 10:10 ` [PATCH v4 01/30] Hexagon HVX (target/hexagon) README Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 02/30] Hexagon HVX (target/hexagon) add Hexagon Vector eXtensions (HVX) to core Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 03/30] Hexagon HVX (target/hexagon) register names Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 04/30] Hexagon HVX (target/hexagon) instruction attributes Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 05/30] Hexagon HVX (target/hexagon) macros Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 06/30] Hexagon HVX (target/hexagon) import macro definitions Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 07/30] Hexagon HVX (target/hexagon) semantics generator Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 08/30] Hexagon HVX (target/hexagon) semantics generator - part 2 Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 09/30] Hexagon HVX (target/hexagon) C preprocessor for decode tree Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 10/30] Hexagon HVX (target/hexagon) instruction utility functions Taylor Simpson
2021-10-29 18:53 ` Richard Henderson
2021-10-29 23:37 ` Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 11/30] Hexagon HVX (target/hexagon) helper functions Taylor Simpson
2021-10-29 18:58 ` Richard Henderson
2021-10-12 10:10 ` [PATCH v4 12/30] Hexagon HVX (target/hexagon) TCG generation Taylor Simpson
2021-10-29 18:59 ` Richard Henderson
2021-10-12 10:10 ` [PATCH v4 13/30] Hexagon HVX (target/hexagon) helper overrides infrastructure Taylor Simpson
2021-10-29 16:48 ` Philippe Mathieu-Daudé
2021-10-29 19:00 ` Richard Henderson
2021-10-12 10:10 ` [PATCH v4 14/30] Hexagon HVX (target/hexagon) helper overrides for histogram instructions Taylor Simpson
2021-10-29 19:04 ` Richard Henderson
2021-10-12 10:10 ` [PATCH v4 15/30] Hexagon HVX (target/hexagon) helper overrides - vector assign & cmov Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 16/30] Hexagon HVX (target/hexagon) helper overrides - vector add & sub Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 17/30] Hexagon HVX (target/hexagon) helper overrides - vector shifts Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 18/30] Hexagon HVX (target/hexagon) helper overrides - vector max/min Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 19/30] Hexagon HVX (target/hexagon) helper overrides - vector logical ops Taylor Simpson
2021-10-29 19:06 ` Richard Henderson
2021-10-12 10:10 ` [PATCH v4 20/30] Hexagon HVX (target/hexagon) helper overrides - vector compares Taylor Simpson
2021-10-12 10:10 ` [PATCH v4 21/30] Hexagon HVX (target/hexagon) helper overrides - vector splat and abs Taylor Simpson
2021-10-12 10:11 ` [PATCH v4 22/30] Hexagon HVX (target/hexagon) helper overrides - vector loads Taylor Simpson
2021-10-12 10:11 ` [PATCH v4 23/30] Hexagon HVX (target/hexagon) helper overrides - vector stores Taylor Simpson
2021-10-12 10:11 ` [PATCH v4 24/30] Hexagon HVX (target/hexagon) import semantics Taylor Simpson
2021-10-12 10:11 ` [PATCH v4 25/30] Hexagon HVX (target/hexagon) instruction decoding Taylor Simpson
2021-10-12 10:11 ` [PATCH v4 26/30] Hexagon HVX (target/hexagon) import instruction encodings Taylor Simpson
2021-10-29 19:08 ` Richard Henderson
2021-10-12 10:11 ` [PATCH v4 27/30] Hexagon HVX (tests/tcg/hexagon) vector_add_int test Taylor Simpson
2021-10-29 19:10 ` Richard Henderson
2021-10-12 10:11 ` [PATCH v4 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test Taylor Simpson
2021-10-29 19:11 ` Richard Henderson
2021-10-12 10:11 ` [PATCH v4 29/30] Hexagon HVX (tests/tcg/hexagon) scatter_gather test Taylor Simpson
2021-10-29 19:13 ` Richard Henderson
2021-10-12 10:11 ` [PATCH v4 30/30] Hexagon HVX (tests/tcg/hexagon) histogram test Taylor Simpson
2021-10-29 19:15 ` Richard Henderson
2021-10-29 19:18 ` Taylor Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1634033468-23566-1-git-send-email-tsimpson@quicinc.com \
--to=tsimpson@quicinc.com \
--cc=ale@rev.ng \
--cc=bcain@quicinc.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).