* [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
@ 2021-11-26 2:00 Andy Pei
2021-11-29 21:57 ` Raphael Norwitz
0 siblings, 1 reply; 3+ messages in thread
From: Andy Pei @ 2021-11-26 2:00 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, qemu-block, mst, mreitz, raphael.norwitz, changpeng.liu
Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX virtio blk device
to avoid guest DMA request size is too large to exceed hardware spec.
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
hw/block/vhost-user-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index ba13cb8..eb1264a 100644
--- a/hw/block/vhost-user-blk.c
+++ b/hw/block/vhost-user-blk.c
@@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,
VHostUserBlk *s = VHOST_USER_BLK(vdev);
/* Turn on pre-defined features */
+ virtio_add_feature(&features, VIRTIO_BLK_F_SIZE_MAX);
virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX);
virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
2021-11-26 2:00 [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device Andy Pei
@ 2021-11-29 21:57 ` Raphael Norwitz
2022-01-03 9:25 ` Pei, Andy
0 siblings, 1 reply; 3+ messages in thread
From: Raphael Norwitz @ 2021-11-29 21:57 UTC (permalink / raw)
To: Andy Pei
Cc: kwolf@redhat.com, qemu-block@nongnu.org, mst@redhat.com,
qemu-devel@nongnu.org, Raphael Norwitz, mreitz@redhat.com,
changpeng.liu@intel.com
Just a commit message nit. Otherwise I'm happy with this. OFC should not
be queued for 6.2.
On Fri, Nov 26, 2021 at 10:00:18AM +0800, Andy Pei wrote:
> Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX virtio blk device
> to avoid guest DMA request size is too large to exceed hardware spec.
Grammar here. Should be something like "...DMA request sizes which are
to large for the hardware spec".
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
> ---
> hw/block/vhost-user-blk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> index ba13cb8..eb1264a 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,
> VHostUserBlk *s = VHOST_USER_BLK(vdev);
>
> /* Turn on pre-defined features */
> + virtio_add_feature(&features, VIRTIO_BLK_F_SIZE_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
> virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
2021-11-29 21:57 ` Raphael Norwitz
@ 2022-01-03 9:25 ` Pei, Andy
0 siblings, 0 replies; 3+ messages in thread
From: Pei, Andy @ 2022-01-03 9:25 UTC (permalink / raw)
To: Raphael Norwitz
Cc: kwolf@redhat.com, qemu-block@nongnu.org, mst@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com, Liu, Changpeng
Hi Raphael,
Thanks for your reply.
I will fix the grammar mistake in V2.
-----Original Message-----
From: Raphael Norwitz <raphael.norwitz@nutanix.com>
Sent: Tuesday, November 30, 2021 5:58 AM
To: Pei, Andy <andy.pei@intel.com>
Cc: qemu-devel@nongnu.org; qemu-block@nongnu.org; Liu, Changpeng <changpeng.liu@intel.com>; Raphael Norwitz <raphael.norwitz@nutanix.com>; mst@redhat.com; kwolf@redhat.com; mreitz@redhat.com
Subject: Re: [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
Just a commit message nit. Otherwise I'm happy with this. OFC should not be queued for 6.2.
On Fri, Nov 26, 2021 at 10:00:18AM +0800, Andy Pei wrote:
> Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX virtio blk device to
> avoid guest DMA request size is too large to exceed hardware spec.
Grammar here. Should be something like "...DMA request sizes which are to large for the hardware spec".
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
> ---
> hw/block/vhost-user-blk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> index ba13cb8..eb1264a 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,
> VHostUserBlk *s = VHOST_USER_BLK(vdev);
>
> /* Turn on pre-defined features */
> + virtio_add_feature(&features, VIRTIO_BLK_F_SIZE_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX);
> virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
> virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-03 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-26 2:00 [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device Andy Pei
2021-11-29 21:57 ` Raphael Norwitz
2022-01-03 9:25 ` Pei, Andy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).