From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a8Wvg-0000b4-44
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:28:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a8Wvc-0002I5-Q4
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:28:56 -0500
Received: from mx6-phx2.redhat.com ([209.132.183.39]:51629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a8Wvc-0002I1-J3
	for qemu-devel@nongnu.org; Mon, 14 Dec 2015 12:28:52 -0500
Date: Mon, 14 Dec 2015 12:28:50 -0500 (EST)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <163895392.40236889.1450114130220.JavaMail.zimbra@redhat.com>
In-Reply-To: <20151214190935-mutt-send-email-mst@redhat.com>
References: <1449994112-7054-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<1449994112-7054-7-git-send-email-shmulik.ladkani@ravellosystems.com>
	<566EF753.4070605@redhat.com>
	<20151214190935-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce
 'x-disable-pcie' backword compatability property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, Marcel Apfelbaum <marcel@redhat.com>, idan brown <idan.brown@ravellosystems.com>, Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>, qemu-devel@nongnu.org

> Well qapi/qmp docs say things like:
> 
> 	Any name (command, event, type, field, or enum value) beginning with
> 	"x-" is marked experimental, and may be withdrawn or changed
> 	incompatibly in a future release.
> 
> It's thus reasonable to use this for internal properties,
> that we don't want users to play with.

What distinguishes an internal from an external property?  Everything
except links to backends would be "internal".

We've used a much more restrictive definition so far than that---basically
known-broken or debugging-only---and I think it's more appropriate.

> BTW, we probably should teach -help to hide these options by default.

Please, no obscuring of functionality.  Debugging-only functionality
definitely belongs in -help.

Paolo