From: Si-Wei Liu <si-wei.liu@oracle.com>
To: qemu-devel@nongnu.org
Cc: si-wei.liu@oracle.com, eperezma@redhat.com, jasowang@redhat.com,
eli@mellanox.com, mst@redhat.com
Subject: [PATCH 7/7] vhost-vdpa: backend feature should set only once
Date: Tue, 29 Mar 2022 23:33:17 -0700 [thread overview]
Message-ID: <1648621997-22416-8-git-send-email-si-wei.liu@oracle.com> (raw)
In-Reply-To: <1648621997-22416-1-git-send-email-si-wei.liu@oracle.com>
The vhost_vdpa_one_time_request() branch in
vhost_vdpa_set_backend_cap() incorrectly sends down
iotls on vhost_dev with non-zero index. This may
end up with multiple VHOST_SET_BACKEND_FEATURES
ioctl calls sent down on the vhost-vdpa fd that is
shared between all these vhost_dev's.
To fix it, send down ioctl only once via the first
vhost_dev with index 0. Toggle the polarity of the
vhost_vdpa_one_time_request() test would do the trick.
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
---
hw/virtio/vhost-vdpa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index c5ed7a3..27ea706 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -665,7 +665,7 @@ static int vhost_vdpa_set_backend_cap(struct vhost_dev *dev)
features &= f;
- if (vhost_vdpa_one_time_request(dev)) {
+ if (!vhost_vdpa_one_time_request(dev)) {
r = vhost_vdpa_call(dev, VHOST_SET_BACKEND_FEATURES, &features);
if (r) {
return -EFAULT;
--
1.8.3.1
next prev parent reply other threads:[~2022-03-30 6:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 6:33 [PATCH 0/7] vhost-vdpa multiqueue fixes Si-Wei Liu
2022-03-30 6:33 ` [PATCH 1/7] virtio-net: align ctrl_vq index for non-mq guest for vhost_vdpa Si-Wei Liu
2022-03-30 9:00 ` Jason Wang
2022-03-30 15:47 ` Si-Wei Liu
2022-03-31 8:39 ` Jason Wang
2022-04-01 22:32 ` Si-Wei Liu
2022-04-02 2:10 ` Jason Wang
2022-04-05 23:26 ` Si-Wei Liu
2022-03-30 6:33 ` [PATCH 2/7] virtio-net: Fix indentation Si-Wei Liu
2022-03-30 9:01 ` Jason Wang
2022-03-30 6:33 ` [PATCH 3/7] virtio-net: Only enable userland vq if using tap backend Si-Wei Liu
2022-03-30 9:07 ` Jason Wang
2022-03-30 6:33 ` [PATCH 4/7] virtio: don't read pending event on host notifier if disabled Si-Wei Liu
2022-03-30 9:14 ` Jason Wang
2022-03-30 16:40 ` Si-Wei Liu
2022-03-31 8:36 ` Jason Wang
2022-04-01 20:37 ` Si-Wei Liu
2022-04-02 2:00 ` Jason Wang
2022-04-05 19:18 ` Si-Wei Liu
2022-04-07 7:05 ` Jason Wang
2022-04-08 1:02 ` Si-Wei Liu
2022-04-11 8:49 ` Jason Wang
2022-03-30 6:33 ` [PATCH 5/7] vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa Si-Wei Liu
2022-03-30 9:15 ` Jason Wang
2022-03-30 6:33 ` [PATCH 6/7] vhost-net: fix improper cleanup in vhost_net_start Si-Wei Liu
2022-03-30 9:30 ` Jason Wang
2022-03-30 6:33 ` Si-Wei Liu [this message]
2022-03-30 9:28 ` [PATCH 7/7] vhost-vdpa: backend feature should set only once Jason Wang
2022-03-30 16:24 ` Stefano Garzarella
2022-03-30 17:12 ` Si-Wei Liu
2022-03-30 17:32 ` Stefano Garzarella
2022-03-30 18:27 ` Eugenio Perez Martin
2022-03-30 22:44 ` Si-Wei Liu
2022-03-30 19:01 ` Eugenio Perez Martin
2022-03-30 23:03 ` Si-Wei Liu
2022-03-31 8:02 ` Eugenio Perez Martin
2022-03-31 8:54 ` Jason Wang
2022-03-31 9:19 ` Eugenio Perez Martin
2022-04-01 2:39 ` Jason Wang
2022-04-01 4:18 ` Si-Wei Liu
2022-04-02 1:33 ` Jason Wang
2022-03-31 21:15 ` Si-Wei Liu
2022-04-01 8:21 ` Eugenio Perez Martin
2022-04-27 4:28 ` [PATCH 0/7] vhost-vdpa multiqueue fixes Jason Wang
2022-04-27 8:29 ` Si-Wei Liu
2022-04-27 8:38 ` Jason Wang
2022-04-27 9:09 ` Si-Wei Liu
2022-04-29 2:30 ` Jason Wang
2022-04-30 2:07 ` Si-Wei Liu
2022-05-05 8:40 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648621997-22416-8-git-send-email-si-wei.liu@oracle.com \
--to=si-wei.liu@oracle.com \
--cc=eli@mellanox.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).