From: Paolo Bonzini <pbonzini@redhat.com>
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: qemu-arm <qemu-arm@nongnu.org>,
peter maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Prasun Kapoor <Prasun.Kapoor@cavium.com>,
Vijaya Kumar K <Vijaya.Kumar@cavium.com>
Subject: Re: [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register
Date: Thu, 4 Aug 2016 08:16:10 -0400 (EDT) [thread overview]
Message-ID: <1648819381.13532219.1470312970610.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CALicx6uuXv=Vnt_H6P2=5EKVAC80Tp7EQVKvE0Fcy0eoUBVNag@mail.gmail.com>
> > Third, it's probably a bad idea to call this function from generic code, so
> > make it static and add the detection function from patch 2/2 already here.
> > By making it static, it's also possible to define it only if CONFIG_LINUX
> > is defined; the ThunderX detection will then return false if !CONFIG_LINUX.
> >
>
> You mean to say, move contents of this patch to util/cutils.c and make it
> static and define under __aarch64__ and CONFIG_LINUX?.
I don't think util/cutils.c is the right file. It should be a new file, something
like util/aarch64-cpuid.c.
If CONFIG_LINUX is not defined, the ThunderX detection function should return
zero.
If __aarch64__ is not defined, the function should not be defined at all.
Paolo
next prev parent reply other threads:[~2016-08-04 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:20 [Qemu-devel] [RFC PATCH v1 0/2] Live migration optimization for Thunderx platform vijay.kilari
2016-08-02 10:20 ` [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register vijay.kilari
2016-08-02 10:48 ` Paolo Bonzini
2016-08-04 9:16 ` Vijay Kilari
2016-08-04 12:16 ` Paolo Bonzini [this message]
2016-08-02 11:10 ` Peter Maydell
2016-08-02 10:20 ` [Qemu-devel] [RFC PATCH v1 2/2] utils: Add prefetch for Thunderx platform vijay.kilari
2016-08-06 10:17 ` Richard Henderson
2016-08-12 11:32 ` Vijay Kilari
2016-08-12 13:20 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648819381.13532219.1470312970610.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=Prasun.Kapoor@cavium.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vijay.kilari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).