From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: Re: [PATCH v2 3/3] qcow2: Rewrite the documentation of qcow2_alloc_cluster_offset()
Date: Fri, 4 Sep 2020 11:43:54 +0200 [thread overview]
Message-ID: <164b6f7e-55b2-cbc4-e90e-c057364a53a7@redhat.com> (raw)
In-Reply-To: <w51blilano8.fsf@maestria.local.igalia.com>
[-- Attachment #1.1: Type: text/plain, Size: 715 bytes --]
On 04.09.20 11:36, Alberto Garcia wrote:
> On Fri 04 Sep 2020 11:28:18 AM CEST, Max Reitz wrote:
>>> + * If any clusters or subclusters were allocated then @m contains a
>>> + * list with the information of all the affected regions. Note that
>>> + * this can happen regardless of whether this function succeeds or
>>> + * not. The caller is responsible for updating the L2 metadata of the
>>> + * allocated clusters (on success) or freeing them (on failure), and
>>> + * for clearing the contents of @m afterwards in both cases.
>>
>> It’s too bad that preallocate_co() doesn’t do that then, isn’t it...
>
> I was planning to have a closer look at that function next week.
Great! :)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-04 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 16:37 [PATCH v2 0/3] qcow2: Fix removal of list members from BDRVQcow2State.cluster_allocs Alberto Garcia
2020-09-03 16:37 ` [PATCH v2 1/3] " Alberto Garcia
2020-09-03 16:37 ` [PATCH v2 2/3] qcow2: Don't check nb_clusters when removing l2meta from the list Alberto Garcia
2020-09-03 16:37 ` [PATCH v2 3/3] qcow2: Rewrite the documentation of qcow2_alloc_cluster_offset() Alberto Garcia
2020-09-04 9:28 ` Max Reitz
2020-09-04 9:36 ` Alberto Garcia
2020-09-04 9:43 ` Max Reitz [this message]
2020-09-04 9:30 ` [PATCH v2 0/3] qcow2: Fix removal of list members from BDRVQcow2State.cluster_allocs Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164b6f7e-55b2-cbc4-e90e-c057364a53a7@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).