From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C2A7C021A9 for ; Mon, 17 Feb 2025 13:58:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tk1d7-0000WV-GY; Mon, 17 Feb 2025 08:57:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tk1d5-0000W8-HX for qemu-devel@nongnu.org; Mon, 17 Feb 2025 08:57:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tk1d3-0005ee-2D for qemu-devel@nongnu.org; Mon, 17 Feb 2025 08:57:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739800663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SCS5pD6uNTix6h3clCBafpYbuedM90Ai82gPSK1o9QU=; b=UPEKg9TGDvw3Ewk3rR4tarKuzMxXJ4oVAAKseUkdhTli+FPsb1Z+6h60WF/N/38XwAVNDd HStto0ZWvrjPVALcv8BfHvkQ1LNHdUnrz8H3+BTrIJzevSvFrn+R2YjcRq6SvJqdflokcK 2o8aK5aEDQS7KyooyExQ2JQO9q0FzKk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-GLKCpDu-OmqgIQdNR0UDTA-1; Mon, 17 Feb 2025 08:57:42 -0500 X-MC-Unique: GLKCpDu-OmqgIQdNR0UDTA-1 X-Mimecast-MFC-AGG-ID: GLKCpDu-OmqgIQdNR0UDTA_1739800661 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4393e8738b3so34511815e9.0 for ; Mon, 17 Feb 2025 05:57:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739800661; x=1740405461; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SCS5pD6uNTix6h3clCBafpYbuedM90Ai82gPSK1o9QU=; b=vp+MFp0+7elB+prTu+7vcCBeHAhZGkjddZ0fGmsMj+EddBGoPabqh1vJuEqkVdNXVi GBywi/Kx5FAjOlWQnw6ViclzwIcvjxjoSQ77cYCqwcIaB/t5tzGCrCuswLkonhwf1/kN VBBNUMRIa4r4XJGfZ3A6zWHQagViqgstk+WALSKEFYpPAQhOfFL9L0lrPh4SEaEH9yt2 zWPP1sRixgoJnq3/FGtIWCEw2++6KnwgR6UKz8oXOeRnLVKcLfbsB4akEnepY1/BdvbC nAG7YIje3pAyZ/ZUnjlCjUGO3sx3IRGXBN5YDW/bhiI3d8B3FGwiALM0Uob8J2Fmpxrq 5Znw== X-Forwarded-Encrypted: i=1; AJvYcCUidBe26tfpOeBT+jfYqfRgpgVWdj7TBltvNDv1iqqEDDtncFpoO3KVLjoLTWsnyih0unf8+hOygKKl@nongnu.org X-Gm-Message-State: AOJu0YzOJ3amQ6jz//WBnz7yAuwhGBheGOD0qvb/XnbPtd0LNp4Nus7t QTGAy2OP0tCnoVL9Uy1Y69b0BGQsyOKXsrmbZJVfCOFqeF78gKXl/Mo/jpFbOU0YJkt+5qxhIqs MbJ8ouerf2rX0Y3J5QAx1PsHnurHoL2qmo3PfvjnKoCvP7iuTElj6 X-Gm-Gg: ASbGncsOIkjZMyh2YKP00r9ivPxa+QiYE4wNYLvo68gc1g1UynwSry2HqMOrdiu5P21 rfMmH4axdUYI4kUNP/ocDHqdnFbmZoJi/uIqGZ+xGSz+TPCkXeVr5ffW92WstlxJ3lVxUmGj/cF hZjB0uVa8fgFdlD+3UUOqk6d4ZHw1Se6S+Hy+bHFWSZItrJoJFH9Lf5WvVaNqLjDUSGYlWus5uf JlNGSgxxl5l6qtEjKg+OQ6J0UPfAMYVlABX4KDw+qGRl7HAR736cFP8sLUc0M788gHRQu/I62C4 AYJdFE+vSAlDPTkQ1M14d1GnkCgTXaAe/PQfGil0 X-Received: by 2002:a5d:5f45:0:b0:38d:e584:81ea with SMTP id ffacd0b85a97d-38f33f4b827mr9314069f8f.45.1739800660661; Mon, 17 Feb 2025 05:57:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5omzDxS8kb3DxFQQC2BgKTssXurpbLs3Cix47KHGQ4V2SDLz4nxHgrMM8DMMlBegBJVHBLQ== X-Received: by 2002:a5d:5f45:0:b0:38d:e584:81ea with SMTP id ffacd0b85a97d-38f33f4b827mr9314036f8f.45.1739800660266; Mon, 17 Feb 2025 05:57:40 -0800 (PST) Received: from ?IPV6:2a01:e0a:165:d60:38c8:6df5:c9ca:a366? ([2a01:e0a:165:d60:38c8:6df5:c9ca:a366]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258cccd3sm12310218f8f.23.2025.02.17.05.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 05:57:39 -0800 (PST) Message-ID: <164d1eb0-93cc-45c7-8b5a-691a1de1ab57@redhat.com> Date: Mon, 17 Feb 2025 14:57:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 32/33] vfio/migration: Add x-migration-multifd-transfer VFIO property To: "Maciej S. Szmigiero" Cc: Alex Williamson , Eric Blake , Peter Xu , Fabiano Rosas , Markus Armbruster , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Avihai Horon , Joao Martins , qemu-devel@nongnu.org References: <8e177cb3-500d-4ada-88c8-64e837a2b9c1@maciej.szmigiero.name> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <8e177cb3-500d-4ada-88c8-64e837a2b9c1@maciej.szmigiero.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/14/25 21:56, Maciej S. Szmigiero wrote: > On 12.02.2025 18:10, Cédric Le Goater wrote: >> On 1/30/25 11:08, Maciej S. Szmigiero wrote: >>> From: "Maciej S. Szmigiero" >>> >>> This property allows configuring at runtime whether to transfer the >>> particular device state via multifd channels when live migrating that >>> device. >>> >>> It defaults to AUTO, which means that VFIO device state transfer via >>> multifd channels is attempted in configurations that otherwise support it. >>> >>> Signed-off-by: Maciej S. Szmigiero >>> --- >>>   hw/vfio/pci.c | 9 +++++++++ >>>   1 file changed, 9 insertions(+) >>> >>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >>> index 2700b355ecf1..cd24f386aaf9 100644 >>> --- a/hw/vfio/pci.c >>> +++ b/hw/vfio/pci.c >>> @@ -3353,6 +3353,8 @@ static void vfio_instance_init(Object *obj) >>>       pci_dev->cap_present |= QEMU_PCI_CAP_EXPRESS; >>>   } >>> +static PropertyInfo qdev_prop_on_off_auto_mutable; >>> + >>>   static const Property vfio_pci_dev_properties[] = { >>>       DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host), >>>       DEFINE_PROP_UUID_NODEFAULT("vf-token", VFIOPCIDevice, vf_token), >>> @@ -3377,6 +3379,10 @@ static const Property vfio_pci_dev_properties[] = { >>>                       VFIO_FEATURE_ENABLE_IGD_OPREGION_BIT, false), >>>       DEFINE_PROP_ON_OFF_AUTO("enable-migration", VFIOPCIDevice, >>>                               vbasedev.enable_migration, ON_OFF_AUTO_AUTO), >>> +    DEFINE_PROP("x-migration-multifd-transfer", VFIOPCIDevice, >>> +                vbasedev.migration_multifd_transfer, >>> +                qdev_prop_on_off_auto_mutable, OnOffAuto, >>> +                .set_default = true, .defval.i = ON_OFF_AUTO_AUTO), >>>       DEFINE_PROP_ON_OFF_AUTO("x-migration-load-config-after-iter", VFIOPCIDevice, >>>                               vbasedev.migration_load_config_after_iter, >>>                               ON_OFF_AUTO_AUTO), >>> @@ -3477,6 +3483,9 @@ static const TypeInfo vfio_pci_nohotplug_dev_info = { >>>   static void register_vfio_pci_dev_type(void) >>>   { >>> +    qdev_prop_on_off_auto_mutable = qdev_prop_on_off_auto; >>> +    qdev_prop_on_off_auto_mutable.realized_set_allowed = true; >>> + >>>       type_register_static(&vfio_pci_dev_info); >>>       type_register_static(&vfio_pci_nohotplug_dev_info); >>>   } >>> >> >> This looks wrong. Why not define the property simply with >> >>     DEFINE_PROP("x-migration-multifd-transfer", VFIOPCIDevice, >>                  vbasedev.migration_multifd_transfer, ON_OFF_AUTO_AUTO) >> ? > > I already explained the reason why I'm not using DEFINE_PROP_ON_OFF_AUTO() > here during the previous version review: > https://lore.kernel.org/qemu-devel/3ba62755-6f36-4707-8c18-8803dbd4f55b@maciej.szmigiero.name/ Ah yes, thanks for the reminder. I will repeat "make it simpler first". Please simply use DEFINE_PROP_ON_OFF_AUTO() first. Thanks, C.