Re: [Qemu-devel] [PATCH 16/35] crypto: mark coroutine_fn

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

On 07/04/2017 05:03 PM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  block/crypto.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/crypto.c b/block/crypto.c
> index 10e5ddccaa..0e30a4ea06 100644
> --- a/block/crypto.c
> +++ b/block/crypto.c
> @@ -568,7 +568,8 @@ static int block_crypto_open_luks(BlockDriverState *bs,
>                                       bs, options, flags, errp);
>  }
>  
> -static int block_crypto_create_luks(const char *filename,
> +static int coroutine_fn
> +block_crypto_create_luks(const char *filename,
>                                      QemuOpts *opts,
>                                      Error **errp)

Indentation is now off.

I don't know how hard we should try to keep our usual style of:

really long labels fn_name(parameters)

vs. the style I'm used to in emacs:

really long labels
fn_name(parameters)

the latter makes it easier to grep for a function implementation (grep
for ^fn_name), and also makes it easier to fit more parameters without
line wrapping, but is not heavily used in our current code base.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]