From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8761AC4741F for ; Sat, 26 Sep 2020 06:57:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D30A4208B6 for ; Sat, 26 Sep 2020 06:57:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ar/X+vFn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D30A4208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kM49T-0006SN-Up for qemu-devel@archiver.kernel.org; Sat, 26 Sep 2020 02:57:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kM48f-00060t-2G for qemu-devel@nongnu.org; Sat, 26 Sep 2020 02:56:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kM48c-0001q5-Gg for qemu-devel@nongnu.org; Sat, 26 Sep 2020 02:56:56 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601103412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vTSgxfivAOkor701R02V0JxkvMwDPiujR1ckTVFoaBM=; b=Ar/X+vFnui5qh82mEyMtv67HeSUMZfTOelrzRzdW2SPmklICx6d3rGFZGmS3rfWV3UxCA5 rhh6kSEgGmE3e8RpoecIdvVazGBn0QZ+Aa4iB/6UO8nCF48bvOcFBJyp9/+3GCU8FDPpZf 7QrTj8+McvUFXHw/1XBfgnmUWSPOxus= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-LpADMo6AO56bDwbfSZ59Aw-1; Sat, 26 Sep 2020 02:56:48 -0400 X-MC-Unique: LpADMo6AO56bDwbfSZ59Aw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E971801AC9; Sat, 26 Sep 2020 06:56:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 161F85C1BB; Sat, 26 Sep 2020 06:56:46 +0000 (UTC) Received: from zmail25.collab.prod.int.phx2.redhat.com (zmail25.collab.prod.int.phx2.redhat.com [10.5.83.31]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A6B7C18095FF; Sat, 26 Sep 2020 06:56:46 +0000 (UTC) Date: Sat, 26 Sep 2020 02:56:46 -0400 (EDT) From: Frediano Ziglio To: marcandre lureau Message-ID: <1655860639.2196690.1601103406201.JavaMail.zimbra@redhat.com> In-Reply-To: <20200925135057.291556-6-marcandre.lureau@redhat.com> References: <20200925135057.291556-1-marcandre.lureau@redhat.com> <20200925135057.291556-6-marcandre.lureau@redhat.com> Subject: Re: [PATCH v2 5/6] spice: get monitors physical dimension MIME-Version: 1.0 X-Originating-IP: [10.33.32.2, 10.4.195.5] Thread-Topic: spice: get monitors physical dimension Thread-Index: zbfOQqaPgi55+NGDPsw22Lqrs539EQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=fziglio@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=fziglio@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/26 02:56:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: spice-devel@lists.freedesktop.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" >=20 > From: Marc-Andr=C3=A9 Lureau >=20 > Note that for consistency, we use the same logic as MonitorsConfig to > figure out the associated monitor. However, I can't find traces of the > discussion/patches about the "new spice-server" behaviour: it still uses > the multiple-configurations path in git master. >=20 This part is now obsolete. > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > include/ui/console.h | 3 +++ > ui/spice-display.c | 9 +++++++++ > 2 files changed, 12 insertions(+) >=20 > diff --git a/include/ui/console.h b/include/ui/console.h > index 353d2e49a1..e7303d8b98 100644 > --- a/include/ui/console.h > +++ b/include/ui/console.h > @@ -119,6 +119,9 @@ typedef struct DisplaySurface { > } DisplaySurface; > =20 > typedef struct QemuUIInfo { > + /* physical dimension */ > + uint16_t width_mm; > + uint16_t height_mm; > /* geometry */ > int xoff; > int yoff; > diff --git a/ui/spice-display.c b/ui/spice-display.c > index b304c13149..a10f72bc5c 100644 > --- a/ui/spice-display.c > +++ b/ui/spice-display.c > @@ -679,7 +679,16 @@ static int interface_client_monitors_config(QXLInsta= nce > *sin, > info.width =3D mc->monitors[head].width; > info.height =3D mc->monitors[head].height; > } > +#if SPICE_SERVER_VERSION >=3D 0x000e04 /* release 0.14.4 */ > + if (mc->flags & VD_AGENT_CONFIG_MONITORS_FLAG_PHYSICAL_SIZE) { > + VDAgentMonitorMM *mm =3D (void *)&mc->monitors[mc->num_of_monito= rs]; > =20 > + if (mc->num_of_monitors > head) { This check is the same of above. Won't be better to move al these block inside the above if block and remove here? > + info.width_mm =3D mm[head].width; > + info.height_mm =3D mm[head].height; > + } > + } > +#endif > trace_qemu_spice_ui_info(ssd->qxl.id, info.width, info.height); > dpy_set_ui_info(ssd->dcl.con, &info); > return 1; Frediano