From: Steve Sistare <steven.sistare@oracle.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Jason Zeng" <jason.zeng@linux.intel.com>,
"Zheng Chuan" <zhengchuan@huawei.com>,
"Steve Sistare" <steven.sistare@oracle.com>,
"Mark Kanda" <mark.kanda@oracle.com>,
"Guoyi Tu" <tugy@chinatelecom.cn>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Peng Liang" <tcx4c70@gmail.com>
Subject: [PATCH V9 42/46] tests/avocado: add cpr regression test
Date: Tue, 26 Jul 2022 09:10:39 -0700 [thread overview]
Message-ID: <1658851843-236870-43-git-send-email-steven.sistare@oracle.com> (raw)
In-Reply-To: <1658851843-236870-1-git-send-email-steven.sistare@oracle.com>
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
MAINTAINERS | 1 +
tests/avocado/cpr.py | 176 +++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 177 insertions(+)
create mode 100644 tests/avocado/cpr.py
diff --git a/MAINTAINERS b/MAINTAINERS
index b93b0bb..adc1218 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3172,6 +3172,7 @@ F: stubs/cpr-state.c
F: include/migration/cpr.h
F: migration/cpr.c
F: hw/vfio/cpr.c
+F: tests/avocado/cpr.py
Record/replay
M: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
diff --git a/tests/avocado/cpr.py b/tests/avocado/cpr.py
new file mode 100644
index 0000000..11e1376
--- /dev/null
+++ b/tests/avocado/cpr.py
@@ -0,0 +1,176 @@
+# cpr test
+
+# Copyright (c) 2021, 2022 Oracle and/or its affiliates.
+#
+# This work is licensed under the terms of the GNU GPL, version 2.
+# See the COPYING file in the top-level directory.
+
+import tempfile
+from avocado_qemu import QemuSystemTest
+from avocado.utils import wait
+
+class Cpr(QemuSystemTest):
+ """
+ :avocado: tags=cpr
+ """
+
+ timeout = 5
+ fast_timeout = 1
+
+ @staticmethod
+ def has_status(vm, status, command):
+ return vm.command(command)['status'] in status
+
+ def wait_for_status(self, vm, status, command):
+ wait.wait_for(self.has_status,
+ timeout=self.timeout,
+ step=0.1,
+ args=(vm,status,command,))
+
+ def wait_for_runstate(self, vm, status):
+ self.wait_for_status(vm, status, 'query-status')
+
+ def wait_for_migration(self, vm, status):
+ self.wait_for_status(vm, status, 'query-migrate')
+
+ def run_and_fail(self, vm, msg):
+ # Qemu will fail fast, so disable monitor to avoid timeout in accept
+ vm.set_qmp_monitor(False)
+ vm.launch()
+ vm.wait(self.timeout)
+ self.assertRegex(vm.get_log(), msg)
+
+ def get_vm_for_restart(self):
+ return self.get_vm('-nodefaults',
+ '-migrate-mode-enable', 'cpr-exec',
+ '-object', 'memory-backend-memfd,id=pc.ram,size=8M',
+ '-machine', 'memory-backend=pc.ram')
+
+ def do_cpr_exec(self, vmstate_name):
+ vm = self.get_vm_for_restart()
+ vm.launch()
+
+ uri = 'file:' + vmstate_name
+ args = vm.full_args + ['-incoming', 'defer']
+
+ vm.command('migrate-set-parameters', cpr_exec_args=args)
+ vm.command('migrate-set-parameters', mode='cpr-exec')
+ vm.qmp('migrate', uri=uri)
+
+ # Cannot poll for migration status, because qemu may call execv before
+ # we see it. Wait for STOP instead.
+ vm.event_wait(name='STOP', timeout=self.fast_timeout)
+
+ # Migrate execs and closes the monitor socket, so reopen it.
+ vm.reopen_qmp_connection()
+
+ self.assertEqual(vm.command('query-status')['status'], 'inmigrate')
+ resp = vm.command('migrate-incoming', uri=uri)
+ self.wait_for_migration(vm, ('completed', 'failed'))
+ self.assertEqual(vm.command('query-migrate')['status'], 'completed')
+
+ resp = vm.command('cont')
+ vm.event_wait(name='RESUME', timeout=self.fast_timeout)
+ self.assertEqual(vm.command('query-status')['status'], 'running')
+
+ def do_cpr_reboot(self, vmstate_name):
+ args = ['-nodefaults', '-migrate-mode-enable', 'cpr-reboot' ]
+ old_vm = self.get_vm(*args)
+ old_vm.launch()
+
+ uri = 'file:' + vmstate_name
+
+ old_vm.command('migrate-set-capabilities', capabilities = [
+ { "capability": "x-ignore-shared", "state": True }])
+ old_vm.command('migrate-set-parameters', mode='cpr-reboot')
+ old_vm.qmp('migrate', uri=uri)
+ self.wait_for_migration(old_vm, ('completed', 'failed'))
+ self.assertEqual(old_vm.command('query-migrate')['status'],
+ 'completed')
+ self.assertEqual(old_vm.command('query-status')['status'],
+ 'postmigrate')
+
+ args = args + ['-incoming', 'defer']
+ new_vm = self.get_vm(*args)
+ new_vm.launch()
+ self.assertEqual(new_vm.command('query-status')['status'], 'inmigrate')
+
+ new_vm.command('migrate-set-capabilities', capabilities = [
+ { "capability": "x-ignore-shared", "state": True }])
+ new_vm.command('migrate-set-parameters', mode='cpr-reboot')
+ new_vm.command('migrate-incoming', uri=uri)
+ self.wait_for_migration(new_vm, ('completed', 'failed'))
+ self.assertEqual(new_vm.command('query-migrate')['status'], 'completed')
+
+ new_vm.command('cont')
+ new_vm.event_wait(name='RESUME', timeout=self.fast_timeout)
+ self.assertEqual(new_vm.command('query-status')['status'], 'running')
+
+ def test_cpr_exec(self):
+ """
+ Verify that cpr restart mode works
+ """
+ with tempfile.NamedTemporaryFile() as vmstate_file:
+ self.do_cpr_exec(vmstate_file.name)
+
+ def test_cpr_reboot(self):
+ """
+ Verify that cpr reboot mode works
+ """
+ with tempfile.NamedTemporaryFile() as vmstate_file:
+ self.do_cpr_reboot(vmstate_file.name)
+
+ def test_cpr_block_cpr_exec(self):
+ """
+ Verify that qemu rejects cpr restart mode for volatile memory
+ """
+
+ vm = self.get_vm('-nodefaults',
+ '-migrate-mode-enable', 'cpr-exec')
+ vm.launch()
+ uri='file:/dev/null'
+ args = vm.full_args + ['-S']
+ resp = vm.command('migrate-set-parameters', mode='cpr-exec')
+ rsp = vm.qmp('migrate', uri=uri)
+ vm.qmp('quit')
+
+ expect = r'Memory region .* is volatile'
+ self.assertRegex(rsp['error']['desc'], expect)
+
+ def test_cpr_block_memfd(self):
+
+ """
+ Verify that qemu complains for only-cpr-capable and volatile memory
+ """
+ vm = self.get_vm('-nodefaults',
+ '-migrate-mode-enable', 'cpr-exec',
+ '-only-cpr-capable')
+ self.run_and_fail(vm, r'only-cpr-capable specified.* Memory ')
+
+ def test_cpr_block_replay(self):
+ """
+ Verify that qemu complains for only-cpr-capable and replay
+ """
+ vm = self.get_vm_for_restart()
+ vm.add_args('-only-cpr-capable',
+ '-icount', 'shift=10,rr=record,rrfile=/dev/null')
+ self.run_and_fail(vm, r'only-cpr-capable specified.* replay ')
+
+ def test_cpr_block_chardev(self):
+ """
+ Verify that qemu complains for only-cpr-capable and unsupported chardev
+ """
+ vm = self.get_vm_for_restart()
+ vm.add_args('-only-cpr-capable',
+ '-chardev', 'vc,id=vc1')
+ self.run_and_fail(vm, r'only-cpr-capable specified.* vc1 ')
+
+ def test_cpr_allow_chardev(self):
+ """
+ Verify that qemu allows unsupported chardev with reopen-on-cpr
+ """
+ vm = self.get_vm_for_restart()
+ vm.add_args('-only-cpr-capable',
+ '-chardev', 'vc,id=vc1,reopen-on-cpr=on')
+ vm.launch()
+ self.wait_for_runstate(vm, ('running'))
--
1.8.3.1
next prev parent reply other threads:[~2022-07-26 16:46 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 16:09 [PATCH V9 00/46] Live Update Steve Sistare
2022-07-26 16:09 ` [PATCH V9 01/46] migration: fix populate_vfio_info Steve Sistare
2022-07-26 16:09 ` [PATCH V9 02/46] memory: RAM_NAMED_FILE flag Steve Sistare
2022-07-26 16:10 ` [PATCH V9 03/46] migration: file URI Steve Sistare
2022-07-26 16:10 ` [PATCH V9 04/46] migration: mode parameter Steve Sistare
2022-07-26 16:10 ` [PATCH V9 05/46] migration: migrate-enable-mode option Steve Sistare
2022-07-26 16:10 ` [PATCH V9 06/46] migration: simplify blockers Steve Sistare
2022-07-26 16:10 ` [PATCH V9 07/46] migration: per-mode blockers Steve Sistare
2022-07-26 16:10 ` [PATCH V9 08/46] cpr: relax some blockers Steve Sistare
2022-07-26 16:10 ` [PATCH V9 09/46] cpr: reboot mode Steve Sistare
2022-07-26 16:10 ` [PATCH V9 10/46] qdev-properties: strList Steve Sistare
2023-06-08 14:50 ` Steven Sistare
2022-07-26 16:10 ` [PATCH V9 11/46] qapi: strList_from_string Steve Sistare
2022-07-26 16:10 ` [PATCH V9 12/46] qapi: QAPI_LIST_LENGTH Steve Sistare
2022-07-26 16:10 ` [PATCH V9 13/46] qapi: strv_from_strList Steve Sistare
2022-07-26 16:10 ` [PATCH V9 14/46] qapi: strList unit tests Steve Sistare
2022-07-26 16:10 ` [PATCH V9 15/46] migration: cpr-exec-args parameter Steve Sistare
2022-07-26 16:10 ` [PATCH V9 16/46] migration: simplify notifiers Steve Sistare
2022-07-26 16:10 ` [PATCH V9 17/46] migration: check mode in notifiers Steve Sistare
2022-07-26 16:10 ` [PATCH V9 18/46] memory: flat section iterator Steve Sistare
2022-07-26 16:10 ` [PATCH V9 19/46] oslib: qemu_clear_cloexec Steve Sistare
2022-07-26 16:10 ` [PATCH V9 20/46] vl: helper to request re-exec Steve Sistare
2022-07-26 16:10 ` [PATCH V9 21/46] cpr: preserve extra state Steve Sistare
2022-07-26 16:10 ` [PATCH V9 22/46] cpr: exec mode Steve Sistare
2022-07-26 16:10 ` [PATCH V9 23/46] cpr: add exec-mode blockers Steve Sistare
2022-07-26 16:10 ` [PATCH V9 24/46] cpr: ram block blockers Steve Sistare
2022-07-26 16:10 ` [PATCH V9 25/46] cpr: only-cpr-capable Steve Sistare
2022-07-26 16:10 ` [PATCH V9 26/46] cpr: Mismatched GPAs fix Steve Sistare
2022-07-26 16:10 ` [PATCH V9 27/46] hostmem-memfd: cpr support Steve Sistare
2022-07-26 16:10 ` [PATCH V9 28/46] hostmem-epc: " Steve Sistare
2022-07-26 16:10 ` [PATCH V9 29/46] pci: export msix_is_pending Steve Sistare
2022-07-26 16:10 ` [PATCH V9 30/46] vfio-pci: refactor for cpr Steve Sistare
2022-07-26 16:10 ` [PATCH V9 31/46] vfio-pci: cpr part 1 (fd and dma) Steve Sistare
2022-07-26 16:10 ` [PATCH V9 32/46] vfio-pci: cpr part 2 (msi) Steve Sistare
2023-07-05 8:56 ` Kunkun Jiang via
2023-07-10 15:43 ` Steven Sistare
2023-07-13 12:35 ` Kunkun Jiang via
2023-07-13 12:42 ` Marc Zyngier
2022-07-26 16:10 ` [PATCH V9 33/46] vfio-pci: cpr part 3 (intx) Steve Sistare
2022-07-26 16:10 ` [PATCH V9 34/46] vfio-pci: recover from unmap-all-vaddr failure Steve Sistare
2022-07-26 16:10 ` [PATCH V9 35/46] vhost: reset vhost devices for cpr Steve Sistare
2022-07-26 16:10 ` [PATCH V9 36/46] chardev: cpr framework Steve Sistare
2022-07-26 16:10 ` [PATCH V9 37/46] chardev: cpr for simple devices Steve Sistare
2022-07-26 16:10 ` [PATCH V9 38/46] chardev: cpr for pty Steve Sistare
2022-07-26 16:10 ` [PATCH V9 39/46] chardev: cpr for sockets Steve Sistare
2022-07-26 16:10 ` [PATCH V9 40/46] python/machine: QEMUMachine full_args Steve Sistare
2022-07-26 18:00 ` John Snow
2022-07-26 16:10 ` [PATCH V9 41/46] python/machine: QEMUMachine reopen_qmp_connection Steve Sistare
2022-07-26 18:04 ` John Snow
2022-07-27 12:06 ` Steven Sistare
2022-07-26 16:10 ` Steve Sistare [this message]
2023-12-01 10:44 ` [PATCH V9 42/46] tests/avocado: add cpr regression test Philippe Mathieu-Daudé
2022-07-26 16:10 ` [PATCH V9 43/46] vl: start on wakeup request Steve Sistare
2022-07-26 16:10 ` [PATCH V9 44/46] migration: fix suspended runstate Steve Sistare
2022-07-26 16:10 ` [PATCH V9 45/46] migration: notifier error reporting Steve Sistare
2022-07-26 16:10 ` [PATCH V9 46/46] vfio: allow cpr-reboot migration if suspended Steve Sistare
2022-12-07 15:48 ` [PATCH V9 00/46] Live Update Steven Sistare
2023-02-07 18:44 ` Steven Sistare
2023-02-07 19:01 ` Steven Sistare
2023-05-30 13:38 ` Philippe Mathieu-Daudé
2023-05-30 13:53 ` Steven Sistare
2023-04-07 17:35 ` Michael Galaxy
2023-04-14 19:20 ` Michael Galaxy
2023-06-06 22:15 ` Michael Galaxy
2023-06-07 15:55 ` Michael Galaxy
2023-06-07 17:37 ` Steven Sistare
2023-06-12 14:59 ` Michael Galaxy
2023-07-10 15:10 ` Steven Sistare
2023-07-13 15:53 ` Michael Galaxy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658851843-236870-43-git-send-email-steven.sistare@oracle.com \
--to=steven.sistare@oracle.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=jason.zeng@linux.intel.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.kanda@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=tcx4c70@gmail.com \
--cc=tugy@chinatelecom.cn \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).