qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 7/9] meson: Do not configure audio if system-mode is not selected
Date: Tue, 19 Jan 2021 19:53:45 +0100	[thread overview]
Message-ID: <166ad408-aa3c-7050-d586-6893f80d3560@redhat.com> (raw)
In-Reply-To: <20210119185005.880322-8-philmd@redhat.com>

Forgot to Cc Gerd, adding him.

On 1/19/21 7:50 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  configure   | 6 ++++++
>  meson.build | 4 +++-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 9f016b06b54..a15bdfb6ef3 100755
> --- a/configure
> +++ b/configure
> @@ -2324,6 +2324,12 @@ if test -z "$want_tools"; then
>      fi
>  fi
>  
> +##########################################
> +# Disable features only meaningful for system-mode emulation
> +if test "$softmmu" = "no"; then
> +    audio_drv_list=""
> +fi
> +
>  ##########################################
>  # Some versions of Mac OS X incorrectly define SIZE_MAX
>  cat > $TMPC << EOF
> diff --git a/meson.build b/meson.build
> index 575e34d88ac..e6c6d1518ef 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2425,7 +2425,9 @@
>  # TODO: add back version
>  summary_info += {'virgl support':     config_host.has_key('CONFIG_VIRGL')}
>  summary_info += {'curl support':      curl.found()}
> -summary_info += {'Audio drivers':     config_host['CONFIG_AUDIO_DRIVERS']}
> +if have_system
> +  summary_info += {'Audio drivers':     config_host['CONFIG_AUDIO_DRIVERS']}
> +endif
>  summary_info += {'Block whitelist (rw)': config_host['CONFIG_BDRV_RW_WHITELIST']}
>  summary_info += {'Block whitelist (ro)': config_host['CONFIG_BDRV_RO_WHITELIST']}
>  summary_info += {'VirtFS support':    have_virtfs}
> 



  reply	other threads:[~2021-01-19 20:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 18:49 [PATCH 0/9] meson: Clarify summary Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 1/9] meson: Summarize generic information first Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 2/9] meson: Summarize compilation information altogether Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 3/9] meson: Summarize host binaries altogether Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 4/9] meson: Summarize accelerators altogether Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 5/9] meson: Display if system emulation is selected in summary Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 6/9] meson: Restrict system-mode specific accelerators Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 7/9] meson: Do not configure audio if system-mode is not selected Philippe Mathieu-Daudé
2021-01-19 18:53   ` Philippe Mathieu-Daudé [this message]
2021-01-20  9:09     ` Gerd Hoffmann
2021-01-19 18:50 ` [PATCH 8/9] meson: Display if user-mode emulation is selected in summary Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 9/9] meson: Summarize block layer information altogether Philippe Mathieu-Daudé
2021-01-20 17:10 ` [PATCH 0/9] meson: Clarify summary Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166ad408-aa3c-7050-d586-6893f80d3560@redhat.com \
    --to=philmd@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).