From: Sun Feng <loyou85@gmail.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, imammedo@redhat.com, ani@anisinha.ca,
Sun Feng <loyou85@gmail.com>
Subject: [PATCH] acpi: Set maximum size to 64k for "etc/acpi/rsdp" blob
Date: Tue, 17 Jan 2023 19:15:21 +0800 [thread overview]
Message-ID: <1673954121-23942-1-git-send-email-loyou85@gmail.com> (raw)
Migrate from aarch64 host with PAGE_SIZE 64k to 4k failed with following errors:
qmp_cmd_name: migrate-incoming, arguments: {"uri": "tcp:[::]:49152"}
{"timestamp": {"seconds": 1673922775, "microseconds": 534702}, "event": "MIGRATION", "data": {"status": "setup"}}
{"timestamp": {"seconds": 1673922776, "microseconds": 53003}, "event": "MIGRATION", "data": {"status": "active"}}
2023-01-17T02:32:56.058827Z qemu-system-aarch64: Length too large: /rom@etc/acpi/rsdp: 0x10000 > 0x1000: Invalid argument
2023-01-17T02:32:56.058832Z qemu-system-aarch64: error while loading state for instance 0x0 of device 'ram'
2023-01-17T02:32:56.059236Z qemu-system-aarch64: load of migration failed: Invalid argument
{"timestamp": {"seconds": 1673922776, "microseconds": 59248}, "event": "MIGRATION", "data": {"status": "failed"}}
2023-01-17 02:32:56.306+0000: shutting down, reason=failed
refer to the following commit, set blob "etc/acpi/rsdp" maximum size to 64k works.
5033728 acpi: Set proper maximum size for "etc/acpi/rsdp" blob
6c2b24d acpi: Set proper maximum size for "etc/table-loader" blob
Signed-off-by: Sun Feng <loyou85@gmail.com>
---
hw/acpi/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/utils.c b/hw/acpi/utils.c
index 0c486ea..85f6ff3 100644
--- a/hw/acpi/utils.c
+++ b/hw/acpi/utils.c
@@ -37,7 +37,7 @@ MemoryRegion *acpi_add_rom_blob(FWCfgCallback update, void *opaque,
} else if (!strcmp(name, ACPI_BUILD_LOADER_FILE)) {
max_size = 0x10000;
} else if (!strcmp(name, ACPI_BUILD_RSDP_FILE)) {
- max_size = 0x1000;
+ max_size = 0x10000;
} else {
g_assert_not_reached();
}
--
2.7.4
next reply other threads:[~2023-01-17 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 11:15 Sun Feng [this message]
2023-01-24 10:30 ` [PATCH] acpi: Set maximum size to 64k for "etc/acpi/rsdp" blob Igor Mammedov
2023-01-30 14:47 ` Feng Sun
2023-01-30 15:07 ` Michael S. Tsirkin
2023-01-31 9:17 ` Feng Sun
2025-05-06 7:08 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1673954121-23942-1-git-send-email-loyou85@gmail.com \
--to=loyou85@gmail.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).