[Qemu-devel] [PATCH] configure

[Qemu-devel] [PATCH] configure

[Jeff Chua]

Avi had suggest I post this patch here so that it can be included in qemu 
instead of kvm.


Here's a little patch to silent ...
   	- sdl-config when SDK is compiled without static library
   	- texi2html when not found

Thanks,
Jeff


--- kvm/qemu/configure.org	2007-05-07 20:36:59 +0800
+++ kvm/qemu/configure	2007-05-07 20:40:58 +0800
@@ -523,8 +523,8 @@
    # static link with sdl ?
    if test "$sdl" = "yes" ; then
    aa="no"
-`$sdl_config --static-libs | grep \\\-laa > /dev/null` && aa="yes"
-sdl_static_libs=`$sdl_config --static-libs`
+`$sdl_config --static-libs 2>/dev/null | grep \\\-laa > /dev/null` && aa="yes"
+sdl_static_libs=`$sdl_config --static-libs 2>/dev/null`
    if [ "$aa" = "yes" ] ; then
      sdl_static_libs="$sdl_static_libs `aalib-config --static-libs`"
    fi
@@ -567,7 +567,8 @@
    fi

    # Check if tools are available to build documentation.
-if [ -x "`which texi2html`" ] && [ -x "`which pod2man`" ]; then
+if [ -x "`which texi2html 2>/dev/null`" \
+	-a -x "`which pod2man 2>/dev/null`" ]; then
      build_docs="yes"
    fi

Re: [Qemu-devel] [PATCH] configure

[Thiemo Seufer]

Jeff Chua wrote:
[snip]
> @@ -567,7 +567,8 @@
>    fi
> 
>    # Check if tools are available to build documentation.
> -if [ -x "`which texi2html`" ] && [ -x "`which pod2man`" ]; then
> +if [ -x "`which texi2html 2>/dev/null`" \
> +	-a -x "`which pod2man 2>/dev/null`" ]; then

Under which circumstances does "which" complain about unavailable
executables?


Thiemo

Re: [Qemu-devel] [PATCH] configure

[Jeff Chua]

For those who does minimal install. In this case,  texi2html would not
be available on the system. I've seen quite a few systems without
texi2html.

Again, the patch is not a MUST, but it's nice not to see unnecessary warning.

Thanks,
Jeff.


On 5/9/07, Thiemo Seufer <ths@networkno.de> wrote:
> Jeff Chua wrote:
> [snip]
> > @@ -567,7 +567,8 @@
> >    fi
> >
> >    # Check if tools are available to build documentation.
> > -if [ -x "`which texi2html`" ] && [ -x "`which pod2man`" ]; then
> > +if [ -x "`which texi2html 2>/dev/null`" \
> > +     -a -x "`which pod2man 2>/dev/null`" ]; then
>
> Under which circumstances does "which" complain about unavailable
> executables?
>
>
> Thiemo
>

Re: [Qemu-devel] [PATCH] configure

[Thiemo Seufer]

Jeff Chua wrote:
> For those who does minimal install. In this case,  texi2html would not
> be available on the system. I've seen quite a few systems without
> texi2html.
> 
> Again, the patch is not a MUST, but it's nice not to see unnecessary 
> warning.

I don't see a warning for e.g. "which foo" on my system. Could you
describe your system and paste the output the which command produces
there?

> Thanks,
> Jeff.
> 
> 
> On 5/9/07, Thiemo Seufer <ths@networkno.de> wrote:
> >Jeff Chua wrote:
> >[snip]
> >> @@ -567,7 +567,8 @@
> >>    fi
> >>
> >>    # Check if tools are available to build documentation.
> >> -if [ -x "`which texi2html`" ] && [ -x "`which pod2man`" ]; then
> >> +if [ -x "`which texi2html 2>/dev/null`" \
> >> +     -a -x "`which pod2man 2>/dev/null`" ]; then
> >
> >Under which circumstances does "which" complain about unavailable
> >executables?
> >
> >
> >Thiemo
> >

Re: [Qemu-devel] [PATCH] configure

[Jeff Chua]

On 5/9/07, Thiemo Seufer <ths@networkno.de> wrote:

> I don't see a warning for e.g. "which foo" on my system. Could you
> describe your system and paste the output the which command produces
> there?

# which foo
which: no foo in
(/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/X11/bin:/usr/local/games:/usr/local/samba/sbin:/usr/local/samba/bin:/etc/rc.d:/root/scripts2:/root/cc2:/usr/local/apache2/bin:/usr/local/squid/sbin:/opt/java/bin:/usr/local/netpbm/bin:/usr/local/ssh/bin:/usr/local/ssl/bin:/usr/lib/yp:.:/usr/vbin:/usr/local/python/bin:/usr/local/tcl/bin:/usr/local/kvm/bin:/usr/local/perl/bin:/db/oracle/db1/bin:/root/oracle2:/usr/local/git/bin:/opt/sybase/bin)
# echo $?
1
# which vi
/usr/bin/vi
# echo $?
0


Thanks,
Jeff.

Re: [Qemu-devel] configure

[Jernej Simončič]

On Wednesday, May 9, 2007, 2:41:03, Thiemo Seufer wrote:

> I don't see a warning for e.g. "which foo" on my system. Could you
> describe your system and paste the output the which command produces
> there?

Gentoo:

# which foo
which: no foo in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/x86_64-pc-linux-gnu/gcc-bin/4.1.1:/opt/blackdown-jre-1.4.2.03/bin)
# which nano
/usr/bin/nano
# file /usr/bin/which
/usr/bin/which: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for GNU/Linux 2.4.1, dynamically linked (uses shared libs), for GNU/Linux 2.4.1, stripped

Debian:

# which foo
# which nano
/usr/bin/nano
# file /bin/which
/bin/which: Bourne shell script text executable

which builtin in the shell on my firewall box (pfSense, based on
FreeBSD 6.2) also produces a warning, but /usr/bin/which on the same
box doesn't.

-- 
< Jernej Simončič ><><><><>< http://deepthought.ena.si/ >

Space expands to house the people to perform the work that Congress creates.
       -- Washington's Law

Re: [Qemu-devel] configure

[Thiemo Seufer]

Jernej Simon?i? wrote:
> On Wednesday, May 9, 2007, 2:41:03, Thiemo Seufer wrote:
> 
> > I don't see a warning for e.g. "which foo" on my system. Could you
> > describe your system and paste the output the which command produces
> > there?
> 
> Gentoo:
> 
> # which foo
> which: no foo in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/x86_64-pc-linux-gnu/gcc-bin/4.1.1:/opt/blackdown-jre-1.4.2.03/bin)
> # which nano
> /usr/bin/nano
> # file /usr/bin/which
> /usr/bin/which: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for GNU/Linux 2.4.1, dynamically linked (uses shared libs), for GNU/Linux 2.4.1, stripped
> 
> Debian:
> 
> # which foo
> # which nano
> /usr/bin/nano
> # file /bin/which
> /bin/which: Bourne shell script text executable
> 
> which builtin in the shell on my firewall box (pfSense, based on
> FreeBSD 6.2) also produces a warning, but /usr/bin/which on the same
> box doesn't.

Thanks, that's the information I needed.


Thiemo