qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Sebastian Herbszt" <herbszt@gmx.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] LSI53C895A: Introduce CASE_GET_REG24
Date: Sat, 3 Jan 2009 20:03:18 +0100	[thread overview]
Message-ID: <16831C6E5BE84D8BB12F83AFCF8403E5@FSCPC> (raw)

CASE_GET_REG32 is already defined in lsi53c895a.c; introduce CASE_GET_REG24.

- Sebastian

--- qemu-r6133/hw/lsi53c895a.c.bak Sat Dec 27 16:18:23 2008
+++ qemu-r6133/hw/lsi53c895a.c Sat Jan  3 18:51:59 2009
@@ -1316,6 +1316,11 @@ again:
 static uint8_t lsi_reg_readb(LSIState *s, int offset)
 {
     uint8_t tmp;
+#define CASE_GET_REG24(name, addr) \
+    case addr: return s->name & 0xff; \
+    case addr + 1: return (s->name >> 8) & 0xff; \
+    case addr + 2: return (s->name >> 16) & 0xff;
+
 #define CASE_GET_REG32(name, addr) \
     case addr: return s->name & 0xff; \
     case addr + 1: return (s->name >> 8) & 0xff; \
@@ -1391,12 +1396,7 @@ static uint8_t lsi_reg_readb(LSIState *s
         return s->ctest5;
     case 0x23: /* CTEST6 */
          return 0;
-    case 0x24: /* DBC[0:7] */
-        return s->dbc & 0xff;
-    case 0x25: /* DBC[8:15] */
-        return (s->dbc >> 8) & 0xff;
-    case 0x26: /* DBC[16->23] */
-        return (s->dbc >> 16) & 0xff;
+    CASE_GET_REG24(dbc, 0x24)
     case 0x27: /* DCMD */
         return s->dcmd;
     CASE_GET_REG32(dsp, 0x2c)
@@ -1481,6 +1481,7 @@ static uint8_t lsi_reg_readb(LSIState *s
     }
     BADF("readb 0x%x\n", offset);
     exit(1);
+#undef CASE_GET_REG24
 #undef CASE_GET_REG32
 }
 

             reply	other threads:[~2009-01-03 19:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-03 19:03 Sebastian Herbszt [this message]
2009-01-14 21:42 ` [Qemu-devel] [PATCH] LSI53C895A: Introduce CASE_GET_REG24 Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16831C6E5BE84D8BB12F83AFCF8403E5@FSCPC \
    --to=herbszt@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).