From: "Marc-André Lureau" <mlureau@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] char: clean up remaining chardevs when leaving
Date: Thu, 16 Jun 2016 08:25:11 -0400 (EDT) [thread overview]
Message-ID: <1684540350.7036885.1466079911243.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <ae2839ad-890e-debd-1b00-e0ba5b8464c6@redhat.com>
Hi
----- Original Message -----
> > +
> > QemuOptsList qemu_chardev_opts = {
> > .name = "chardev",
> > .implied_opt_name = "backend",
> > diff --git a/vl.c b/vl.c
> > index 45eff56..ac92b1d 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -4628,6 +4628,7 @@ int main(int argc, char **argv, char **envp)
> > #ifdef CONFIG_TPM
> > tpm_cleanup();
> > #endif
> > + qemu_chr_cleanup();
>
> Given the amount of exit(1) calls surviving in QEMU, it's probably
> better to use atexit here.
Agreed, fixed
next prev parent reply other threads:[~2016-06-16 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 11:17 [Qemu-devel] [PATCH 0/3] chardev cleanups marcandre.lureau
2016-06-16 11:17 ` [Qemu-devel] [PATCH 1/3] char: clean up remaining chardevs when leaving marcandre.lureau
2016-06-16 12:19 ` Paolo Bonzini
2016-06-16 12:25 ` Marc-André Lureau [this message]
2016-06-16 11:17 ` [Qemu-devel] [PATCH 2/3] socket: add listen feature marcandre.lureau
2016-06-16 11:17 ` [Qemu-devel] [PATCH 3/3] socket: unlink unix socket on remove marcandre.lureau
2016-06-16 12:28 ` Paolo Bonzini
2016-06-16 12:36 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1684540350.7036885.1466079911243.JavaMail.zimbra@redhat.com \
--to=mlureau@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).