From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDWMI-0001gA-Ad for qemu-devel@nongnu.org; Thu, 16 Jun 2016 08:25:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDWMD-0000iR-8b for qemu-devel@nongnu.org; Thu, 16 Jun 2016 08:25:17 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:47772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDWMC-0000iL-VU for qemu-devel@nongnu.org; Thu, 16 Jun 2016 08:25:13 -0400 Date: Thu, 16 Jun 2016 08:25:11 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1684540350.7036885.1466079911243.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1466075835-28494-1-git-send-email-marcandre.lureau@redhat.com> <1466075835-28494-2-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] char: clean up remaining chardevs when leaving List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: marcandre lureau , qemu-devel@nongnu.org, berrange@redhat.com Hi ----- Original Message ----- > > + > > QemuOptsList qemu_chardev_opts = { > > .name = "chardev", > > .implied_opt_name = "backend", > > diff --git a/vl.c b/vl.c > > index 45eff56..ac92b1d 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -4628,6 +4628,7 @@ int main(int argc, char **argv, char **envp) > > #ifdef CONFIG_TPM > > tpm_cleanup(); > > #endif > > + qemu_chr_cleanup(); > > Given the amount of exit(1) calls surviving in QEMU, it's probably > better to use atexit here. Agreed, fixed