From: "Zoltán Kővágó" <dirty.ice.hu@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [RFC PATCH] audio: proper support for float samples in mixeng
Date: Mon, 3 Feb 2020 21:38:39 +0100 [thread overview]
Message-ID: <1686aa04-0dc8-c08b-bdee-565979f19023@gmail.com> (raw)
In-Reply-To: <CAFEAcA_8-0wqQX8KEK_zFRufoaEQkaeaXu4DLx08KazxTZ5fxQ@mail.gmail.com>
On 2020-02-03 11:00, Peter Maydell wrote:
> On Sun, 2 Feb 2020 at 19:39, Kővágó, Zoltán <dirty.ice.hu@gmail.com> wrote:
>>
>> This adds proper support for float samples in mixeng by adding a new
>> audio format for it.
>>
>> Limitations: only native endianness is supported.
>
> Could you explain a bit more what this limitation means, please?
> In general QEMU behaviour shouldn't depend on the endianness
> of the host, ie we should byteswap where necessary.
None of the virtual sound cards support float samples (it looks like
most of them only support 8 and 16 bit, only hda supports 32 bit), it is
only used for the audio backends (i.e. host side). In
audiodev_to_audsettings we set endianness to AUDIO_HOST_ENDIANNESS, so
audio backends should always use native endian.
So this limitation should only cause problems when an audio backend
overrides the endian setting. Wavcapture does it, but it does not
support float. Alsa, sdl, puleaudio and oss can also do it if for some
weird reason it acquires a stream with a different endianness than
requested.
Regards,
Zoltan
next prev parent reply other threads:[~2020-02-03 20:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 19:38 [RFC PATCH] audio: proper support for float samples in mixeng Kővágó, Zoltán
2020-02-02 22:14 ` Howard Spoelstra
2020-02-03 6:21 ` Markus Armbruster
2020-02-03 15:34 ` Eric Blake
2020-02-04 6:48 ` Markus Armbruster
2020-02-03 8:59 ` Volker Rümelin
2020-02-03 10:00 ` Peter Maydell
2020-02-03 20:38 ` Zoltán Kővágó [this message]
2020-02-04 10:24 ` Peter Maydell
2020-02-06 13:37 ` Gerd Hoffmann
2020-03-09 18:36 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1686aa04-0dc8-c08b-bdee-565979f19023@gmail.com \
--to=dirty.ice.hu@gmail.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).