qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Steve Sistare <steven.sistare@oracle.com>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Steve Sistare" <steven.sistare@oracle.com>
Subject: [PATCH V2 05/10] migration: preserve suspended for bg_migration
Date: Fri, 30 Jun 2023 06:49:43 -0700	[thread overview]
Message-ID: <1688132988-314397-6-git-send-email-steven.sistare@oracle.com> (raw)
In-Reply-To: <1688132988-314397-1-git-send-email-steven.sistare@oracle.com>

Do not wake a suspended guest during bg_migration.

Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
 migration/migration.c | 12 +++++-------
 softmmu/runstate.c    |  1 +
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index 7a9218b..125e060 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3044,7 +3044,9 @@ static void bg_migration_vm_start_bh(void *opaque)
     qemu_bh_delete(s->vm_start_bh);
     s->vm_start_bh = NULL;
 
-    vm_start();
+    if (!runstate_check(RUN_STATE_SUSPENDED)) {
+        vm_start();
+    }
     s->downtime = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) - s->downtime_start;
 }
 
@@ -3114,16 +3116,12 @@ static void *bg_migration_thread(void *opaque)
 
     qemu_mutex_lock_iothread();
 
-    /*
-     * If VM is currently in suspended state, then, to make a valid runstate
-     * transition in vm_stop_force_state() we need to wakeup it up.
-     */
-    qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER, NULL);
     s->vm_old_state = runstate_get();
 
     global_state_store();
     /* Forcibly stop VM before saving state of vCPUs and devices */
-    if (vm_stop_force_state(RUN_STATE_PAUSED)) {
+    if (!runstate_check(RUN_STATE_SUSPENDED) &&
+        vm_stop_force_state(RUN_STATE_PAUSED)) {
         goto fail;
     }
     /*
diff --git a/softmmu/runstate.c b/softmmu/runstate.c
index 18efe31..35ce343 100644
--- a/softmmu/runstate.c
+++ b/softmmu/runstate.c
@@ -163,6 +163,7 @@ static const RunStateTransition runstate_transitions_def[] = {
     { RUN_STATE_SUSPENDED, RUN_STATE_FINISH_MIGRATE },
     { RUN_STATE_SUSPENDED, RUN_STATE_PRELAUNCH },
     { RUN_STATE_SUSPENDED, RUN_STATE_COLO},
+    { RUN_STATE_SUSPENDED, RUN_STATE_PAUSED },
 
     { RUN_STATE_WATCHDOG, RUN_STATE_RUNNING },
     { RUN_STATE_WATCHDOG, RUN_STATE_FINISH_MIGRATE },
-- 
1.8.3.1



  parent reply	other threads:[~2023-06-30 13:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30 13:49 [PATCH V2 00/10] fix migration of suspended runstate Steve Sistare
2023-06-30 13:49 ` [PATCH V2 01/10] vl: start on wakeup request Steve Sistare
2023-07-14 12:47   ` Fabiano Rosas
2023-06-30 13:49 ` [PATCH V2 02/10] migration: preserve suspended runstate Steve Sistare
2023-07-14 12:48   ` Fabiano Rosas
2023-06-30 13:49 ` [PATCH V2 03/10] migration: add runstate function Steve Sistare
2023-07-14 12:48   ` Fabiano Rosas
2023-06-30 13:49 ` [PATCH V2 04/10] migration: preserve suspended for snapshot Steve Sistare
2023-06-30 13:49 ` Steve Sistare [this message]
2023-06-30 13:49 ` [PATCH V2 06/10] tests/qtest: migration events Steve Sistare
2023-07-14 12:57   ` Fabiano Rosas
2023-06-30 13:49 ` [PATCH V2 07/10] tests/qtest: option to suspend during migration Steve Sistare
2023-06-30 13:49 ` [PATCH V2 08/10] tests/qtest: precopy migration with suspend Steve Sistare
2023-06-30 13:49 ` [PATCH V2 09/10] tests/qtest: postcopy " Steve Sistare
2023-06-30 13:49 ` [PATCH V2 10/10] tests/qtest: background " Steve Sistare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1688132988-314397-6-git-send-email-steven.sistare@oracle.com \
    --to=steven.sistare@oracle.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).