qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <dovgaluk@ispras.ru>,
	'Artem Pisarenko' <artem.k.pisarenko@gmail.com>,
	'Clement Deschamps' <clement.deschamps@greensocs.com>
Cc: qemu-devel@nongnu.org, 'Pavel Dovgalyuk' <Pavel.Dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call"
Date: Wed, 17 Oct 2018 16:43:09 +0200	[thread overview]
Message-ID: <168ee943-5b06-fbe5-a644-0312d80855ca@redhat.com> (raw)
In-Reply-To: <005c01d4661c$3a9cd0a0$afd671e0$@ru>

On 17/10/2018 15:20, Pavel Dovgalyuk wrote:
> I found the source of the bug. As QEMU becomes more multi-threaded
> and non-synchronized, checkpoints move from thread to thread. And the
> event queue that processed at checkpoints should belong to the same
> thread in both record and replay executions.
> 
> Current problem was with the checkpoint for virtual timers. They are
> processed from different threads: from vCPU and from aio_dispatch
> function.
> 
> Therefore the following patch fixes the problem, but I think that
> this part has to be refactored. There should be nailed-to-thread
> events that process the event queue. Then checkpoints can become just
> synchronization events and therefore omitted for empty timer lists,
> for example.

Can you add a FIXME comment and submit this as a full patch?

Paolo

  parent reply	other threads:[~2018-10-17 14:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  9:07 [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call" Paolo Bonzini
2018-10-17  9:37 ` Pavel Dovgalyuk
2018-10-17  9:53   ` Artem Pisarenko
2018-10-17 10:17     ` Paolo Bonzini
2018-10-17 11:38       ` Pavel Dovgalyuk
2018-10-17 11:42         ` Paolo Bonzini
2018-10-17 11:43           ` Pavel Dovgalyuk
2018-10-17 12:30             ` Alex Bennée
2018-10-17 12:11           ` Pavel Dovgalyuk
2018-10-17 13:20           ` Pavel Dovgalyuk
2018-10-17 13:32             ` Artem Pisarenko
2018-10-18  5:49               ` Pavel Dovgalyuk
2018-10-17 14:43             ` Paolo Bonzini [this message]
2018-10-18  2:22               ` Clement Deschamps

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168ee943-5b06-fbe5-a644-0312d80855ca@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=artem.k.pisarenko@gmail.com \
    --cc=clement.deschamps@greensocs.com \
    --cc=dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).