From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code
Date: Wed, 16 Aug 2017 11:50:12 -0400 (EDT) [thread overview]
Message-ID: <1693347134.2736614.1502898612069.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <981ecc11-57f4-3f6a-3ee6-d829d60edfb1@redhat.com>
Hi
----- Original Message -----
> On 08/02/2017 05:07 PM, Marc-André Lureau wrote:
>
> >>
> >> Rather than leave this untested time-bomb in place, rip it out.
>
> >>
> >> Signed-off-by: Eric Blake <eblake@redhat.com>
> >
> > I think it used to work in a vm (as qemu-ga user), but I don't mind to
> > revert it if we need it back:
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Should this be R-b instead of S-o-b?
correct,
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
prev parent reply other threads:[~2017-08-16 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 20:19 [Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code Eric Blake
2017-08-02 20:24 ` [Qemu-devel] [PATCH for-2.10?] " Eric Blake
2017-08-02 22:07 ` [Qemu-devel] [PATCH] " Marc-André Lureau
2017-08-16 15:45 ` Eric Blake
2017-08-16 15:50 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1693347134.2736614.1502898612069.JavaMail.zimbra@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).