From: Richard Henderson <richard.henderson@linaro.org>
To: Brad Smith <brad@comstyle.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] util/cpuinfo-aarch64: Add OpenBSD support
Date: Sun, 23 Jun 2024 15:08:13 -0700 [thread overview]
Message-ID: <169b725e-44f4-4fe7-9049-174136c393fb@linaro.org> (raw)
In-Reply-To: <99682aaf-935a-4986-8832-dd2f2415f4ef@linaro.org>
On 6/23/24 10:55, Richard Henderson wrote:
> On 6/22/24 19:12, Brad Smith wrote:
>> + if (sysctl(mib, 2, &isar0, &len, NULL, 0) != -1) {
>> + if (ID_AA64ISAR0_ATOMIC(isar0) >= ID_AA64ISAR0_ATOMIC_IMPL)
>> + info |= CPUINFO_LSE;
>> + if (ID_AA64ISAR0_AES(isar0) >= ID_AA64ISAR0_AES_BASE)
>> + info |= CPUINFO_AES;
>> + if (ID_AA64ISAR0_AES(isar0) >= ID_AA64ISAR0_AES_PMULL)
>> + info |= CPUINFO_PMULL;
>> + }
>> +
>> + mib[0] = CTL_MACHDEP;
>> + mib[1] = CPU_ID_AA64PFR1;
>> + len = sizeof(pfr1);
>> + if (sysctl(mib, 2, &pfr1, &len, NULL, 0) != -1) {
>> + if (ID_AA64PFR1_BT(pfr1) >= ID_AA64PFR1_BT_IMPL)
>> + info |= CPUINFO_BTI;
>> + }
>
> Need braces for all of the if's. Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Fixed braces and queued to tcg-next.
r~
next prev parent reply other threads:[~2024-06-23 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 2:12 [PATCH] util/cpuinfo-aarch64: Add OpenBSD support Brad Smith
2024-06-23 17:55 ` Richard Henderson
2024-06-23 22:08 ` Richard Henderson [this message]
2024-06-26 4:36 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169b725e-44f4-4fe7-9049-174136c393fb@linaro.org \
--to=richard.henderson@linaro.org \
--cc=brad@comstyle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).