From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F533C433E0 for ; Mon, 18 May 2020 08:01:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0618A20787 for ; Mon, 18 May 2020 08:01:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Br9pjD95" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0618A20787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaaij-0005w4-7k for qemu-devel@archiver.kernel.org; Mon, 18 May 2020 04:01:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaahk-0005N9-2X for qemu-devel@nongnu.org; Mon, 18 May 2020 04:00:56 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:49806 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jaahi-0006hp-RY for qemu-devel@nongnu.org; Mon, 18 May 2020 04:00:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589788853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wyOrSchwJSz5rk3OE7L/E8JAEWGpA2HrFyXpZ8RmxI0=; b=Br9pjD95n0nkO55oDCnZf41iwsXz1LyBTPuKV8w9y+Hwdcygl7BVpWAIhxlYemAo7QOR+Z aUFdHr+e4XlEXNZ2cs+nFPWhyS8sktObbfN8ATYYBtnXaNpdQRHSQL0U9Rb8sEtYpQ2mX9 WdOSAzEIgSQGrW94P+hgGFY+0MlHlKg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-305-euYKehZzOqWBDAqsgkGIbQ-1; Mon, 18 May 2020 04:00:41 -0400 X-MC-Unique: euYKehZzOqWBDAqsgkGIbQ-1 Received: by mail-wm1-f70.google.com with SMTP id g10so5436381wme.0 for ; Mon, 18 May 2020 01:00:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wyOrSchwJSz5rk3OE7L/E8JAEWGpA2HrFyXpZ8RmxI0=; b=g2OkrFpJ7RdFP/26QMRNbx0OsDc42F9VTCEq2bSOBSVCfC8oz1YmieFgunUI/7fCjW ofSXiLJ+sCkWakVXuCYpD/5QG9HiUAv2RJhJoVJHlMGJRuZUnwT53GVcPR6L24zOIsry nhCdrogMLX+TPJHYlTKkxNF4edzn6fX6BEkKMmrnbyo4KolLzsCU6Skqn4iTohU4h1Wa wiLDIvZxTtBRCAny8w/gzoSQEwzI7Mpj9xTU52ePkfFMWxX4y3dgJwnhFgJ3WQ/UtOZe 4VjjjGXcpk0KD0iz8gHRW5CNcxc4DpLWyHCU0xvW0pDSzpJ6Za0fdAnIbeFAoeBu0vmz /h4g== X-Gm-Message-State: AOAM532fmbAmMBNvSqVJeROJDXQfq0v8MbHb+3q/RU8Ud8DfyEMROKRg WAuOEyVpl2sbV6N/3Lf6rhMRxA2Ff07Y1biRjKdZeCKMcZVpAxagg3A2xUr0m9eJdjycKPwEvqk jvIK258fXwZvNCHs= X-Received: by 2002:a05:600c:2f97:: with SMTP id t23mr18310768wmn.150.1589788839556; Mon, 18 May 2020 01:00:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOlPj7JWO8DcdGJNqOr4FQdeWIbhu+lRUYNYlwBAKQRxRNV7iGVdl/SFUR1MelwldVG3iR7w== X-Received: by 2002:a05:600c:2f97:: with SMTP id t23mr18310741wmn.150.1589788839281; Mon, 18 May 2020 01:00:39 -0700 (PDT) Received: from [192.168.1.38] (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id c143sm13976480wmd.43.2020.05.18.01.00.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 01:00:38 -0700 (PDT) Subject: Re: [PATCH] net: use peer when purging queue in qemu_flush_or_purge_queue_packets() To: Jason Wang , Alexander Bulekov References: <20200511040453.23956-1-jasowang@redhat.com> <20200511042150.44na6uwgf6mhdngx@mozz.bu.edu> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <16a4d458-c47d-026c-70fd-1b3f47736d04@redhat.com> Date: Mon, 18 May 2020 10:00:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 22:52:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, stefanha@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Jason, On 5/18/20 5:34 AM, Jason Wang wrote: > On 2020/5/11 下午12:21, Alexander Bulekov wrote: >> On 200511 1204, Jason Wang wrote: >>> The sender of packet will be checked in the qemu_net_queue_purge() but >>> we use NetClientState not its peer when trying to purge the incoming >>> queue in qemu_flush_or_purge_packets(). This will trigger the assert >>> in virtio_net_reset since we can't pass the sender check. >>> >>> Fix by using the peer. Can you please include the backtrace: hw/net/virtio-net.c:533: void virtio_net_reset(VirtIODevice *): Assertion `!virtio_net_get_subqueue(nc)->async_tx.elem' failed. #9 0x55a33fa31b78 in virtio_net_reset hw/net/virtio-net.c:533:13 #10 0x55a33fc88412 in virtio_reset hw/virtio/virtio.c:1919:9 #11 0x55a341d82764 in virtio_bus_reset hw/virtio/virtio-bus.c:95:9 #12 0x55a341dba2de in virtio_pci_reset hw/virtio/virtio-pci.c:1824:5 #13 0x55a341db3e02 in virtio_pci_common_write hw/virtio/virtio-pci.c:1252:13 #14 0x55a33f62117b in memory_region_write_accessor memory.c:496:5 #15 0x55a33f6205e4 in access_with_adjusted_size memory.c:557:18 #16 0x55a33f61e177 in memory_region_dispatch_write memory.c:1488:16 And link to reproducer: https://www.mail-archive.com/qemu-devel@nongnu.org/msg701914.html Thanks, Phil. (Alexander, this is an example of why launchpad bug reports are easier to refer in commit history). >>> >>> Reported-by: "Alexander Bulekov" >>> Fixes: ca77d85e1dbf9 ("net: complete all queued packets on VM stop") >>> Cc: qemu-stable@nongnu.org >>> Signed-off-by: Jason Wang >> Hi Jason, >> With this patch, I can no longer reproduce the crash >> >> Acked-by: Alexander Bulekov >> >> Thanks! > > > Applied. > > Thanks > > > >> >>> --- >>>   net/net.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/net/net.c b/net/net.c >>> index 38778e831d..9e47cf727d 100644 >>> --- a/net/net.c >>> +++ b/net/net.c >>> @@ -610,7 +610,7 @@ void >>> qemu_flush_or_purge_queued_packets(NetClientState *nc, bool purge) >>>           qemu_notify_event(); >>>       } else if (purge) { >>>           /* Unable to empty the queue, purge remaining packets */ >>> -        qemu_net_queue_purge(nc->incoming_queue, nc); >>> +        qemu_net_queue_purge(nc->incoming_queue, nc->peer); >>>       } >>>   } >>> -- >>> 2.20.1 >>> > >