From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH 1/2] target/arm: Define and use new load_cpu_field_low32()
Date: Mon, 24 Apr 2023 17:14:35 +0100 [thread overview]
Message-ID: <16a8678a-d2f5-7d2c-03e6-5a9744636c80@linaro.org> (raw)
In-Reply-To: <20230424153909.1419369-2-peter.maydell@linaro.org>
On 4/24/23 16:39, Peter Maydell wrote:
> + QEMU_BUILD_BUG_ON(sizeof(typeof_field(CPUARMState, name)) != 8); \
Surely just sizeof_field().
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-04-24 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 15:39 [PATCH 0/2] target/arm: Load correct half of 64-bit fields Peter Maydell
2023-04-24 15:39 ` [PATCH 1/2] target/arm: Define and use new load_cpu_field_low32() Peter Maydell
2023-04-24 16:14 ` Richard Henderson [this message]
2023-04-24 15:39 ` [PATCH 2/2] target/arm: Add compile time asserts to load/store_cpu_field macros Peter Maydell
2023-04-24 16:14 ` Richard Henderson
2023-05-02 10:33 ` [PATCH 0/2] target/arm: Load correct half of 64-bit fields Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16a8678a-d2f5-7d2c-03e6-5a9744636c80@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).