From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93669C77B61 for ; Mon, 24 Apr 2023 16:15:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqypt-00083J-SE; Mon, 24 Apr 2023 12:14:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqyps-00081x-0J for qemu-devel@nongnu.org; Mon, 24 Apr 2023 12:14:40 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqypq-0002L9-Gy for qemu-devel@nongnu.org; Mon, 24 Apr 2023 12:14:39 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-2f7db354092so2821660f8f.2 for ; Mon, 24 Apr 2023 09:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682352877; x=1684944877; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=reaqqT8z7MI6TcEHMMfL7/rFaQh20A/rUSyHXS9L7fg=; b=dlH+JHHWDo0Mw9n3oAGHvZKhJ94IFqO7ZdRNI4Ai6brQSuqbpj1itTkFUqnmh+6ZmK Am1p1zvkY0BB3TqyocL2nKR+jOqoZ1ypbabbjxGIhf7POGmdbQHiQUhRSn2Gj6WBpu5K rQBNRGzJfSi+xotPJHchhkYu0VgxM1l1xwrJkESY8IKa0h+XUqPpLhavHAZW8Ma4i83p fIO1GCQdr4Wzs56vJmrFuCp5DiBhBNemTNh25NGwCIgPh22hsX7AeSIvVGUcdq04GJIx SqaMyE57Yfs38SlWZ+oXZuIZEM/Ok10KxRaqVvWkWyEeZKSvM152ke2bMWCUDNLPCdDn ZXyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682352877; x=1684944877; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=reaqqT8z7MI6TcEHMMfL7/rFaQh20A/rUSyHXS9L7fg=; b=WDQmjgGp9bznVYHL84N+WUQhvhzIrnwZLkRFTYKodREEaR8mjIwzcXbu7WBcbZPQsE macHUyuSdlt1Y9hwiIjPTv5RLO3qrjP+6Su42CZRLSsgr7dcJVKEwzB300aT2vDOvq2N t/u1iz0bi3b5tPNLMgnESBMbSpGwPvBCpomdPV+HJXVjAelSkbCPw0Yo4KvhAsBmN20W RpjTmvzs9A0g2QVIQKIORdZE4kn14OQmTcIYILuft6i+NXb4xcJAnleDJL3uLCJonDl+ Wjw+h/gPi9xHXe7n1HimHCEcb+JCVxVHkJm/bC2WgrRsFBGBFOJONFPAUp0RsgQ7Qxdz tb2g== X-Gm-Message-State: AAQBX9cOyzqeROBb/sfp2Fl2DzeOfM+Ha6ohglrAfCR9TlA08pQ/NJdv 5wiydjHsVkLP/mdUmrtcDrEslg== X-Google-Smtp-Source: AKy350bBODiOzN6aMbb47pxuh1BJ9Rdu2E7seg8hjyoDPS6HjjZDz8Prs+qXkoWIjwfMOsBqBbyrow== X-Received: by 2002:adf:e843:0:b0:2fe:cafc:8b2c with SMTP id d3-20020adfe843000000b002fecafc8b2cmr10594267wrn.62.1682352876891; Mon, 24 Apr 2023 09:14:36 -0700 (PDT) Received: from [10.43.0.114] (cust-west-loneq8-46-193-226-34.wb.wifirst.net. [46.193.226.34]) by smtp.gmail.com with ESMTPSA id g10-20020a7bc4ca000000b003f171234a08sm12456406wmk.20.2023.04.24.09.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 09:14:36 -0700 (PDT) Message-ID: <16a8678a-d2f5-7d2c-03e6-5a9744636c80@linaro.org> Date: Mon, 24 Apr 2023 17:14:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/2] target/arm: Define and use new load_cpu_field_low32() Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org References: <20230424153909.1419369-1-peter.maydell@linaro.org> <20230424153909.1419369-2-peter.maydell@linaro.org> From: Richard Henderson In-Reply-To: <20230424153909.1419369-2-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.194, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/24/23 16:39, Peter Maydell wrote: > + QEMU_BUILD_BUG_ON(sizeof(typeof_field(CPUARMState, name)) != 8); \ Surely just sizeof_field(). Otherwise, Reviewed-by: Richard Henderson r~