From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH] libqtest: Rename qmp_assert_error_class() to qmp_expect_error_and_unref()
Date: Wed, 2 Sep 2020 14:18:30 +0200 [thread overview]
Message-ID: <16bf55f9-a223-9508-5f8e-ad83fd0478c9@redhat.com> (raw)
In-Reply-To: <b7cdce86-ad58-d8fc-d081-ce5410dbcc57@redhat.com>
On 9/2/20 2:00 PM, Thomas Huth wrote:
> On 02/09/2020 13.57, Markus Armbruster wrote:
>> qmp_assert_error_class() does more than just assert: it also unrefs
>> the @rsp argument. Rename to qmp_assert_error_class() to reduce
>> confusion.
>
> s/to qmp_assert_error_class()/to qmp_expect_error_and_unref()/
>
> With that nit fixed (I can do it when picking up the patch):
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-09-02 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 11:57 [PATCH] libqtest: Rename qmp_assert_error_class() to qmp_expect_error_and_unref() Markus Armbruster
2020-09-02 12:00 ` Thomas Huth
2020-09-02 12:18 ` Philippe Mathieu-Daudé [this message]
2020-09-02 14:31 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16bf55f9-a223-9508-5f8e-ad83fd0478c9@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).