Re: [PATCH] tests/avocado: Move LinuxTest related code into a separate file

[Thomas Huth <thuth@redhat.com>]

On 21/08/2024 17.11, Philippe Mathieu-Daudé wrote:
> On 19/7/24 11:50, Thomas Huth wrote:
>> Only some few tests are using the LinuxTest class. Move the related
>> code into a separate file so that this does not pollute the main
>> namespace.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   tests/avocado/avocado_qemu/__init__.py  | 239 +---------------------
>>   tests/avocado/avocado_qemu/linuxtest.py | 253 ++++++++++++++++++++++++
>>   tests/avocado/boot_linux.py             |   3 +-
>>   tests/avocado/hotplug_blk.py            |   2 +-
>>   tests/avocado/hotplug_cpu.py            |   2 +-
>>   tests/avocado/intel_iommu.py            |   2 +-
>>   tests/avocado/replay_linux.py           |   2 +-
>>   tests/avocado/smmu.py                   |   3 +-
>>   8 files changed, 262 insertions(+), 244 deletions(-)
>>   create mode 100644 tests/avocado/avocado_qemu/linuxtest.py
>>
>> diff --git a/tests/avocado/avocado_qemu/__init__.py 
>> b/tests/avocado/avocado_qemu/__init__.py
>> index 304c428168..a3da2a96bb 100644
>> --- a/tests/avocado/avocado_qemu/__init__.py
>> +++ b/tests/avocado/avocado_qemu/__init__.py
>> @@ -10,7 +10,6 @@
>>   import logging
>>   import os
>> -import shutil
>>   import subprocess
>>   import sys
>>   import tempfile
>> @@ -18,7 +17,7 @@
>>   import uuid
>>   import avocado
>> -from avocado.utils import cloudinit, datadrainer, process, ssh, vmimage
>> +from avocado.utils import ssh
> 
> Unfortunately we don't run the user mode tests on CI and missed
> 'process' is used by the QemuUserTest class.

Oh, sorry ... apparently I'm not running these locally on my machine either 
... could you send a patch to fix it, or want me to do it?

  Thomas