From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AC4BCED60F for ; Tue, 18 Nov 2025 11:19:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLJk2-0005Yw-Ie; Tue, 18 Nov 2025 06:19:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLJjy-0005VB-26 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 06:19:18 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLJjv-0003iW-EO for qemu-devel@nongnu.org; Tue, 18 Nov 2025 06:19:17 -0500 Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-477563e28a3so36747135e9.1 for ; Tue, 18 Nov 2025 03:19:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763464753; x=1764069553; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FY7MPxZayPe1OiVaDC7Ytfdu9D2keOve8OMUnuYhR1g=; b=Y3ePSP2FtPCDzKdInOooP+lGNVzAOWrPcn9dyKlbLExFyn8GBAiFkHm/QR1nt479o4 eunV3N6NViAfoPTGXOusVkNObiTYmmkch53nUrx+Tk73OzyE6o+WtIGjo4MtIES+Nj01 tqtjHCXLQUiDPV1BjCHLKLmjuO4IAC5XcKrLoCKgyoBHHlHe/VqSYqQtpD6xUizkWTJ0 8kEtjbROHG9EE8XFDmzZO4RNTrRNk+uPGdtKF7iN43LbYERvEgWOOqXEKikeJ6zLQat9 Pt2nhQl0rdCdZEv90EY2wBXq8lGy9ZIetsNFgIjmN9xGEtLeiptD6RNxazPVggnyYM37 7o0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763464753; x=1764069553; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FY7MPxZayPe1OiVaDC7Ytfdu9D2keOve8OMUnuYhR1g=; b=EcAFJDQood/Sd2GYdxy4VrkvdEhPjA3ID1TjFIG/i60bBeWLnqajItmV/M0Q/8bJd7 H4m40Ex8ww2kgroNYA692Xu53SA4WB+M5YBMhykoVzSNwu2v3kgWuriyYdFDM8Y5yrq/ 14W3TefdzNAV6GD5YkM8cavM/ujDSJqc/u2C2adFD10aVve8Rs4g9gE/iNmDAxxcN5m0 aEhTjX9wpFYuxyZe3O110+ggJDb/xfnHxDDkwFzQfZT4JlbKBeHTyVpkkia1Ub3SMj7Z rHZSG3hjB1mk4ml8NqlDbGm7MoZOuIAv/HdK7e0kN+peTdaYo4BPMdQ1aIMK28oeB9lt G22g== X-Forwarded-Encrypted: i=1; AJvYcCXXjiAMn96yQ/gQ63lZ7egi3dfzzveOvZwVVMfmerxPPwVUm9iRp6F4y/6dZOZoaVzukAcaVb7K2LYt@nongnu.org X-Gm-Message-State: AOJu0YyTZ+skEWWsrJrfMSEP+cMRAUqqtiKeu5cO+uuTFDubZbB1F7fr CED3/Je2CZvSG1MP6RJcSmf4F/kPL1oV2MhsdqR5to807d98lHO4ZlctcR7m8x2m4pk= X-Gm-Gg: ASbGncuNZb8g59X1d76TJRZwZZb77qWgqqqm39yt/E53y4i+kB//oi4AKcMBUKkax9t 0eXhK41HF0ICFMkS75z3X5MypRBZg/ulPHWe9K/x7Db749RhITReNKwX16ekN2jT92qIaBkcMJL xhwQRHF6Mh4jkTM6ZxEha4s+mATZEoxcMvFsPh3s8R9B9Lh1EzdomWIuyliQVYaoCaD4QSux7mG 9co/8iaAWD/VP8TQ7kwLRdHWoLGyYmYaNtDbkflw7xBA+/U7PsZtlpq60RF5POzLPwgYKYCmiky gTcV73Jyz8RjZlGgm/YzVsFSxOa8Iv0Gv92R+q3nefSiws5jjfzuja95ldJuk4kWpFD6sto9CDH Hl86lUYFAJKCEJCP0yCHuF+JJvv6c6XsIRTNPOSn6U+F2t2iKKMKC/DFKx2Wc0cyjAiOiBeOR14 BK2DmiuWa+tqv+fBiVq2bQfFN8mFB/4lK/fdEM7IhxtUxhkttLIX1TeA== X-Google-Smtp-Source: AGHT+IF262iSV8e5bfwsfbK0PHlbT5vX/d2qgGhVlPTeMDKbhu0BNBFd5YL49Q/Kyi3sKWXUXDzfyw== X-Received: by 2002:a05:600c:2d54:b0:477:a53c:8ca1 with SMTP id 5b1f17b1804b1-477a94f87aemr17407025e9.14.1763464753432; Tue, 18 Nov 2025 03:19:13 -0800 (PST) Received: from [192.168.69.210] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e442c2sm369906275e9.7.2025.11.18.03.19.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 03:19:12 -0800 (PST) Message-ID: <16cd29b1-c0fe-4dfc-81a7-654be0ea09ab@linaro.org> Date: Tue, 18 Nov 2025 12:19:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 14/14] scripts/checkpatch: Check DEVICE_NATIVE_ENDIAN Content-Language: en-US To: Djordje Todorovic , "qemu-devel@nongnu.org" Cc: "qemu-riscv@nongnu.org" , "cfu@mips.com" , "mst@redhat.com" , "marcel.apfelbaum@gmail.com" , "dbarboza@ventanamicro.com" , "alistair23@gmail.com" , "thuth@redhat.com" References: <20251118085758.3996513-1-djordje.todorovic@htecgroup.com> <20251118085758.3996513-15-djordje.todorovic@htecgroup.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20251118085758.3996513-15-djordje.todorovic@htecgroup.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=philmd@linaro.org; helo=mail-wm1-x344.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 18/11/25 09:58, Djordje Todorovic wrote: > Developers should specify endianess explicitly. > > Signed-off-by: Djordje Todorovic > --- > scripts/checkpatch.pl | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 40b6955c69..dc88fa4da4 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3206,6 +3206,10 @@ sub process { > if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\baio_bh_new\s*\(/) { > ERROR("use aio_bh_new_guarded() instead of aio_bh_new() to avoid reentrancy problems\n" . $herecurr); > } > +# check for DEVICE_NATIVE_ENDIAN, use explicit endianness instead > + if ($line =~ /\bDEVICE_NATIVE_ENDIAN\b/) { > + ERROR("DEVICE_NATIVE_ENDIAN is not allowed, use DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN instead\n" . $herecurr); > + } > # check for module_init(), use category-specific init macros explicitly please > if ($line =~ /^module_init\s*\(/) { > ERROR("please use block_init(), type_init() etc. instead of module_init()\n" . $herecurr); Thank you for this patch :) Reviewed-by: Philippe Mathieu-Daudé