From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Laurent@vivier.eu
Subject: Re: [PATCH 2/5] linux-user: Introduce host_signal_mask
Date: Tue, 8 Feb 2022 22:17:52 +1100 [thread overview]
Message-ID: <16d22c7c-a81c-9a65-3d46-12ff19d89229@linaro.org> (raw)
In-Reply-To: <CAFEAcA-Sy8wvO2h1tjNwPcK6j2Tfz-gGY2YTCeQZQEB_1jd=qg@mail.gmail.com>
On 2/8/22 21:59, Peter Maydell wrote:
> On Tue, 8 Feb 2022 at 08:03, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Do not directly access the uc_sigmask member.
>> This is preparation for a sparc64 fix.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> linux-user/include/host/aarch64/host-signal.h | 5 +++++
>> linux-user/include/host/alpha/host-signal.h | 5 +++++
>> linux-user/include/host/arm/host-signal.h | 5 +++++
>> linux-user/include/host/i386/host-signal.h | 5 +++++
>> .../include/host/loongarch64/host-signal.h | 5 +++++
>> linux-user/include/host/mips/host-signal.h | 5 +++++
>> linux-user/include/host/ppc/host-signal.h | 5 +++++
>> linux-user/include/host/riscv/host-signal.h | 5 +++++
>> linux-user/include/host/s390/host-signal.h | 5 +++++
>> linux-user/include/host/sparc/host-signal.h | 5 +++++
>> linux-user/include/host/x86_64/host-signal.h | 5 +++++
>> linux-user/signal.c | 18 ++++++++----------
>> 12 files changed, 63 insertions(+), 10 deletions(-)
>>
>> diff --git a/linux-user/include/host/aarch64/host-signal.h b/linux-user/include/host/aarch64/host-signal.h
>> index 9770b36dc1..76ab078069 100644
>> --- a/linux-user/include/host/aarch64/host-signal.h
>> +++ b/linux-user/include/host/aarch64/host-signal.h
>> @@ -40,6 +40,11 @@ static inline void host_signal_set_pc(ucontext_t *uc, uintptr_t pc)
>> uc->uc_mcontext.pc = pc;
>> }
>>
>> +static inline void *host_signal_mask(ucontext_t *uc)
>> +{
>> + return &uc->uc_sigmask;
>> +}
>
> Why void* rather than sigset_t* ?
Because it's not really a sigset_t, even when it is in ucontext_t.
It's a kernel_sigset_t, as per the comment in host_signal_handler.
When it comes to sparc64 in the last patch, the glibc type will turn out to be unsigned long.
Got a better suggestion?
r~
next prev parent reply other threads:[~2022-02-08 12:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 7:12 [PATCH 0/5] linux-user: Fixes for sparc64 host Richard Henderson
2022-02-08 7:12 ` [PATCH 1/5] common-user/host/sparc64: Fix safe_syscall_base Richard Henderson
2022-02-08 7:12 ` [PATCH 2/5] linux-user: Introduce host_signal_mask Richard Henderson
2022-02-08 10:39 ` Philippe Mathieu-Daudé via
2022-02-08 10:59 ` Peter Maydell
2022-02-08 11:17 ` Richard Henderson [this message]
2022-02-08 11:32 ` Peter Maydell
2022-02-08 7:12 ` [PATCH 3/5] linux-user: Introduce host_sigcontext Richard Henderson
2022-02-08 10:40 ` Philippe Mathieu-Daudé via
2022-02-08 11:06 ` Peter Maydell
2022-02-08 7:12 ` [PATCH 4/5] linux-user: Move sparc/host-signal.h to sparc64/host-signal.h Richard Henderson
2022-02-08 10:40 ` Philippe Mathieu-Daudé via
2022-02-08 11:01 ` Peter Maydell
2022-02-08 11:19 ` Richard Henderson
2022-02-08 7:12 ` [PATCH 5/5] linux-user/include/host/sparc64: Fix host_sigcontext Richard Henderson
2022-02-08 11:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16d22c7c-a81c-9a65-3d46-12ff19d89229@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).