From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, "Denis V . Lunev" <den@openvz.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/7] qcow2: Remove unused Error variable in do_perform_cow()
Date: Wed, 7 Jun 2017 10:44:01 -0500 [thread overview]
Message-ID: <16e8f2c2-f429-96d3-8d37-fd5bd2ab498c@redhat.com> (raw)
In-Reply-To: <8e633db98543522f6e5bd0f98dd1eb58291f6210.1496844254.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 06/07/2017 09:08 AM, Alberto Garcia wrote:
> We are using the return value of qcow2_encrypt_sectors() to detect
> problems but we are throwing away the returned Error since we have no
> way to report it to the user. Therefore we can simply get rid of the
> local Error variable and pass NULL instead.
>
> Alternatively we could try to figure out a way to pass the original
> error instead of simply returning -EIO, but that would be more
> invasive, so let's keep the current approach.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/qcow2-cluster.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-06-07 15:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 14:08 [Qemu-devel] [PATCH v2 0/7] qcow2: Reduce the number of I/O ops when doing COW Alberto Garcia
2017-06-07 14:08 ` [Qemu-devel] [PATCH v2 1/7] qcow2: Remove unused Error variable in do_perform_cow() Alberto Garcia
2017-06-07 15:44 ` Eric Blake [this message]
2017-06-07 14:08 ` [Qemu-devel] [PATCH v2 2/7] qcow2: Use unsigned int for both members of Qcow2COWRegion Alberto Garcia
2017-06-07 16:02 ` Eric Blake
2017-06-08 13:06 ` Alberto Garcia
2017-06-08 13:38 ` Eric Blake
2017-06-07 14:08 ` [Qemu-devel] [PATCH v2 3/7] qcow2: Make perform_cow() call do_perform_cow() twice Alberto Garcia
2017-06-07 21:43 ` Eric Blake
2017-06-08 7:09 ` Alberto Garcia
2017-06-07 14:08 ` [Qemu-devel] [PATCH v2 4/7] qcow2: Split do_perform_cow() into _read(), _encrypt() and _write() Alberto Garcia
2017-06-09 14:53 ` Eric Blake
2017-06-12 13:00 ` Alberto Garcia
2017-06-07 14:08 ` [Qemu-devel] [PATCH v2 5/7] qcow2: Allow reading both COW regions with only one request Alberto Garcia
2017-06-07 14:08 ` [Qemu-devel] [PATCH v2 6/7] qcow2: Pass a QEMUIOVector to do_perform_cow_{read, write}() Alberto Garcia
2017-06-07 16:20 ` Manos Pitsidianakis
2017-06-16 15:31 ` Kevin Wolf
2017-06-07 14:08 ` [Qemu-devel] [PATCH v2 7/7] qcow2: Merge the writing of the COW regions with the guest data Alberto Garcia
2017-06-16 15:31 ` Kevin Wolf
2017-06-19 11:50 ` Alberto Garcia
2017-06-16 15:31 ` [Qemu-devel] [PATCH v2 0/7] qcow2: Reduce the number of I/O ops when doing COW Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e8f2c2-f429-96d3-8d37-fd5bd2ab498c@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).