Re: [PATCH 3/4] hw/m68k/virt: Add a pflash controller for BIOS firmware

["Jiaxun Yang" <jiaxun.yang@flygoat.com>]

在2024年6月18日六月 下午12:47，Philippe Mathieu-Daudé写道：
> Hi Jiaxun,
>
> On 27/5/24 19:15, Jiaxun Yang wrote:
>> Add a 8 MiB pflash controller for BIOS firmware, and boot
>> from it if possible.
>> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>   hw/m68k/Kconfig                                   |  1 +
>>   hw/m68k/virt.c                                    | 44 +++++++++++++++++++++++
>>   include/standard-headers/asm-m68k/bootinfo-virt.h |  1 +
>>   3 files changed, 46 insertions(+)
>> 
>> diff --git a/hw/m68k/Kconfig b/hw/m68k/Kconfig
>> index 4501da56ff6d..f233a5948f19 100644
>> --- a/hw/m68k/Kconfig
>> +++ b/hw/m68k/Kconfig
>> @@ -42,6 +42,7 @@ config M68K_VIRT
>>       select M68K_IRQC
>>       select FW_CFG_DMA
>>       select VIRT_CTRL
>> +    select PFLASH_CFI01
>>       select GOLDFISH_PIC
>>       select GOLDFISH_TTY
>>       select GOLDFISH_RTC
>> diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c
>> index 7590e6515ac3..a2eebc0f2243 100644
>> --- a/hw/m68k/virt.c
>> +++ b/hw/m68k/virt.c
>> @@ -8,6 +8,7 @@
>>    */
>>   
>>   #include "qemu/osdep.h"
>> +#include "qemu/datadir.h"
>>   #include "qemu/units.h"
>>   #include "qemu/guest-random.h"
>>   #include "sysemu/sysemu.h"
>> @@ -28,6 +29,7 @@
>>   #include "sysemu/runstate.h"
>>   #include "sysemu/reset.h"
>>   
>> +#include "hw/block/flash.h"
>>   #include "hw/intc/m68k_irqc.h"
>>   #include "hw/misc/virt_ctrl.h"
>>   #include "hw/char/goldfish_tty.h"
>> @@ -97,6 +99,10 @@
>>   #define VIRT_XHCI_MMIO_BASE 0xff020000    /* MMIO: 0xff020000 - 0xff023fff */
>>   #define VIRT_XHCI_IRQ_BASE  PIC_IRQ(1, 2) /* PIC: #1, IRQ: #2 */
>>   
>> +#define VIRT_PFLASH_MMIO_BASE 0xff800000      /* MMIO: 0xff800000 - 0xffffffff */
>> +#define VIRT_PFLASH_SIZE      0x800000        /* 8 MiB */
>
> Do you need a real RW pflash or a ROM would be enough?

U-Boot needs somewhere to store env vars :-(
Probably a NVRAM would fit the purpose?

Thanks

>

-- 
- Jiaxun