From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH v13 09/11] qcow2_format.py: collect fields to dump in JSON format
Date: Fri, 7 Aug 2020 11:09:48 +0300 [thread overview]
Message-ID: <16f57b1a-b1ee-c974-ad45-7be32b0d73b6@virtuozzo.com> (raw)
In-Reply-To: <c718f884-579e-c658-1ba6-a584a4598e82@virtuozzo.com>
07.08.2020 11:03, Andrey Shinkevich wrote:
> On 07.08.2020 09:30, Vladimir Sementsov-Ogievskiy wrote:
>> 06.08.2020 22:35, Andrey Shinkevich wrote:
>>> As __dict__ is being extended with class members we do not want to
>>> print, add the to_dict() method to classes that returns a dictionary
>>
>> to_json() ... that returns a json-dumpable object
>>
>
> New version to release with the commit message fix?
>
Not worth resending, it can be touched when queuing.
>
>>> with desired fields and their values. Extend it in subclass when
>>> necessary to print the final dictionary in the JSON output which
>>> follows.
>>>
>>> Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
>>
>> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>
>>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2020-08-07 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 19:35 [PATCH v13 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 01/11] iotests: add test for QCOW2 header dump Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 02/11] qcow2_format.py: make printable data an extension class member Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 04/11] qcow2_format.py: dump bitmap flags in human readable way Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 05/11] qcow2_format.py: Dump bitmap directory information Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 06/11] qcow2_format.py: pass cluster size to substructures Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 07/11] qcow2_format.py: Dump bitmap table serialized entries Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 08/11] qcow2.py: Introduce '-j' key to dump in JSON format Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 09/11] qcow2_format.py: collect fields " Andrey Shinkevich
2020-08-07 6:30 ` Vladimir Sementsov-Ogievskiy
2020-08-07 8:03 ` Andrey Shinkevich
2020-08-07 8:09 ` Vladimir Sementsov-Ogievskiy [this message]
2020-08-06 19:35 ` [PATCH v13 10/11] qcow2_format.py: support dumping metadata " Andrey Shinkevich
2020-08-06 19:35 ` [PATCH v13 11/11] iotests: dump QCOW2 header in JSON in #303 Andrey Shinkevich
2020-08-14 11:56 ` [PATCH v13 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-08-20 0:49 ` Eric Blake
2020-08-20 14:11 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16f57b1a-b1ee-c974-ad45-7be32b0d73b6@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).