From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4C4DCCD1BF for ; Thu, 23 Oct 2025 09:09:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBrJE-0004ZE-68; Thu, 23 Oct 2025 05:08:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBrJC-0004Yw-AA; Thu, 23 Oct 2025 05:08:34 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBrJA-0004Vf-5X; Thu, 23 Oct 2025 05:08:34 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59N2YUJH007314; Thu, 23 Oct 2025 09:08:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=AMWiPM KZo4oW0PsUoFhLh7enoxfHNMojag1vskHixtc=; b=TPJDrqqWes289Uh2Yy5z5j Qg9i2AN5S2JpxKyo0poDN56K+qJW2iW9mG6HSRxUJFbuqA/49KTLWpJdsW6dC0TP pP3gl1y+nOC0r+TkYENg3sitC8MxFhRKoUaaJdw0uXFixINRT1HkrYgOfZzXeLBD mMCm54efUqffFDn75ed7fCRE99GbucrR978yG/zX97kbYeWh0kF+5dA/3fx7Autz Kkozc8ICEVaQo/IDqikftbX5yXNFrQeF9pugfgpY8tTexDSXW5/Od7TJRhB32Bs5 STremeDwfVQeaD+4tkUT29PsmMgusK0omBMr69BUeyh5IyvOnbo/gc5W1ZZwkVkA == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v33fhbf1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Oct 2025 09:08:29 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59N96HG0015706; Thu, 23 Oct 2025 09:08:28 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v33fhbew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Oct 2025 09:08:28 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59N62Ahu024303; Thu, 23 Oct 2025 09:08:27 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 49vpqk4vbj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Oct 2025 09:08:27 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59N98NlS21824238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Oct 2025 09:08:23 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C44C2004B; Thu, 23 Oct 2025 09:08:23 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 94FB620043; Thu, 23 Oct 2025 09:08:20 +0000 (GMT) Received: from [9.109.204.116] (unknown [9.109.204.116]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Oct 2025 09:08:20 +0000 (GMT) Message-ID: <16f6bcd4-3fbb-4575-85f9-75c53da0dd49@linux.ibm.com> Date: Thu, 23 Oct 2025 14:38:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/8] hw/ppc: Pass dump-sizes property for fadump in device tree To: Aditya Gupta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Nicholas Piggin , Daniel Henrique Barboza , Harsh Prateek Bora , Mahesh J Salgaonkar , Hari Bathini , Chinmay Rath , Thomas Huth , Shivang Upadhyay , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= References: <20251021134823.1861675-1-adityag@linux.ibm.com> <20251021134823.1861675-6-adityag@linux.ibm.com> Content-Language: en-US From: Sourabh Jain In-Reply-To: <20251021134823.1861675-6-adityag@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=FMYWBuos c=1 sm=1 tr=0 ts=68f9f08d cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=b4aRaDLVE5pkJWayaJsA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 6rKDLsO4FETphbq4UwNpGWiNkVfTBtuv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfX9z44Z6S/AKkE Gf6KVlyWEnGxdgaaFRtfYbVPqD7lRjKM+SWSKDvS4iPf3E314oA9HpnhUMtGryWgGRlPkQRQ79h vqzUxI7+8FKISbm2+CqgKrSvUhIl3wZ88U2Kj6va1AlIVz3JayMf3vBeQIuILL48ncDF9PvE2nc qVLhOVLpJFIv5H669NHzd2/dE+LOr5TARrH6vaIMsSO6wD884qkMX7Sm5tB2Ppo3BvCIXAl6JvL TqQhHIYD0/WUD7Wx5ZEKfgUhvKWHrxUY3qBcSU41PBxE5/8UJsfxf0MkDNARINa4Sj/xLj0cUil coiA04O+ayXqHcMSoMKkC0jPzB9b0qD461qkz2k5SIiQ+vBD1m0e+OxNqFj/73tf/ioFg0Xfdot 0e3HxGsvKEgUJBs5hF0rB7yIOJtRhg== X-Proofpoint-ORIG-GUID: 2pcU87_Ak2iVsTP4X2_M-_GbxYf_Yha1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_08,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 Received-SPF: pass client-ip=148.163.156.1; envelope-from=sourabhjain@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 21/10/25 19:18, Aditya Gupta wrote: > Platform (ie. QEMU) is expected to pass few device tree properties for > details for fadump: > > * "ibm,configure-kernel-dump-sizes": Space required to store dump data > for firmware provided dump sections (ie. CPU & HPTE regions) > * "ibm,configure-kernel-dump-version": Versions of fadump supported > > Pass the above device tree nodes so that kernel can reserve sufficient > space for preserving the CPU state data > > Signed-off-by: Aditya Gupta > --- > hw/ppc/spapr.c | 57 +++++++++++++++++++++++++++++++++++++++++++ > hw/ppc/spapr_fadump.c | 6 ++--- > 2 files changed, 60 insertions(+), 3 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 97ab6bebd25c..d40d5a9dcde5 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -900,6 +900,61 @@ static int spapr_dt_rng(void *fdt) > return ret ? -1 : 0; > } > > +static void spapr_dt_rtas_fadump(SpaprMachineState *spapr, void *fdt, int rtas) > +{ > + MachineState *ms = MACHINE(spapr); > + MachineClass *mc = MACHINE_GET_CLASS(ms); > + > + uint32_t max_possible_cpus = mc->possible_cpu_arch_ids(ms)->len; > + uint64_t fadump_cpu_state_size = 0; > + uint16_t fadump_versions[2] = { > + FADUMP_VERSION /* min supported version */, > + FADUMP_VERSION /* max supported version */ > + }; > + uint32_t fadump_rgn_sizes[2][3] = { > + { > + cpu_to_be32(FADUMP_CPU_STATE_DATA), > + 0, 0 /* Calculated later */ > + }, > + { > + cpu_to_be32(FADUMP_HPTE_REGION), > + 0, 0 /* HPTE region not implemented */ > + } > + }; > + > + /* > + * CPU State Data contains multiple fields such as header, num_cpus and > + * register entries > + * > + * Calculate the maximum CPU State Data size, according to maximum > + * possible CPUs the QEMU VM can have > + * > + * This calculation must match the 'cpu_state_len' calculation done in > + * 'populate_cpu_state_data' in spapr_fadump.c > + */ > + fadump_cpu_state_size += sizeof(struct FadumpRegSaveAreaHeader); > + fadump_cpu_state_size += 0xc; /* padding as in PAPR */ > + fadump_cpu_state_size += sizeof(uint32_t); /* num_cpus */ > + fadump_cpu_state_size += max_possible_cpus * /* reg entries */ > + FADUMP_PER_CPU_REG_ENTRIES * > + sizeof(struct FadumpRegEntry); > + > + /* Set maximum size for CPU state data region */ > + assert(fadump_rgn_sizes[0][0] == cpu_to_be32(FADUMP_CPU_STATE_DATA)); > + > + /* Upper 32 bits of size, usually 0 */ > + fadump_rgn_sizes[0][1] = cpu_to_be32(fadump_cpu_state_size >> 32); > + > + /* Lower 32 bits of size */ > + fadump_rgn_sizes[0][2] = cpu_to_be32(fadump_cpu_state_size & 0xffffffff); > + > + /* Add device tree properties required from platform for fadump */ > + _FDT((fdt_setprop(fdt, rtas, "ibm,configure-kernel-dump-version", > + fadump_versions, sizeof(fadump_versions)))); > + _FDT((fdt_setprop(fdt, rtas, "ibm,configure-kernel-dump-sizes", > + fadump_rgn_sizes, sizeof(fadump_rgn_sizes)))); > +} > + > static void spapr_dt_rtas(SpaprMachineState *spapr, void *fdt) > { > MachineState *ms = MACHINE(spapr); > @@ -1015,6 +1070,8 @@ static void spapr_dt_rtas(SpaprMachineState *spapr, void *fdt) > _FDT(fdt_setprop(fdt, rtas, "ibm,lrdr-capacity", > lrdr_capacity, sizeof(lrdr_capacity))); > > + spapr_dt_rtas_fadump(spapr, fdt, rtas); > + > spapr_dt_rtas_tokens(fdt, rtas); > } > > diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c > index fdd49291483e..fa3aeac94cb7 100644 > --- a/hw/ppc/spapr_fadump.c > +++ b/hw/ppc/spapr_fadump.c > @@ -492,7 +492,7 @@ static void *get_cpu_state_data(uint64_t *cpu_state_len) > *cpu_state_len = 0; > *cpu_state_len += sizeof(reg_save_hdr); /* reg save header */ > *cpu_state_len += 0xc; /* padding as in PAPR */ > - *cpu_state_len += sizeof(__be32); /* num_cpus */ > + *cpu_state_len += sizeof(num_cpus); /* num_cpus */ > *cpu_state_len += reg_entries_size; /* reg entries */ > > cpu_state_buffer = g_malloc(*cpu_state_len); > @@ -503,8 +503,8 @@ static void *get_cpu_state_data(uint64_t *cpu_state_len) > > /* Write num_cpus */ > num_cpus = cpu_to_be32(num_cpus); > - memcpy(cpu_state_buffer + offset, &num_cpus, sizeof(__be32)); > - offset += sizeof(__be32); > + memcpy(cpu_state_buffer + offset, &num_cpus, sizeof(num_cpus)); > + offset += sizeof(num_cpus); > > /* Write the register entries */ > memcpy(cpu_state_buffer + offset, reg_entries, reg_entries_size); LGTM Reviewed-by: Sourabh Jain