From: Al Cho <ACho@suse.com>
To: "thuth@redhat.com" <thuth@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-s390x@nongnu.org" <qemu-s390x@nongnu.org>
Cc: "Claudio Fontana" <Claudio.Fontana@suse.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"José Ricardo Ziviani" <jose.ziviani@suse.com>,
"cfontana@suse.de" <cfontana@suse.de>
Subject: Re: [RFC v6 09/13] target/s390x: make helper.c sysemu-only
Date: Fri, 2 Jul 2021 07:27:25 +0000 [thread overview]
Message-ID: <1702e9caf6192b2e9b9c068e4b1ca5ec8ca5beee.camel@suse.com> (raw)
In-Reply-To: <a3eb7e42-020a-ed1c-ccd9-07cdd4b5382a@redhat.com>
On Thu, 2021-07-01 at 14:36 +0200, Thomas Huth wrote:
> On 29/06/2021 16.19, Cho, Yu-Chen wrote:
> > Now that we have moved cpu-dump functionality out of helper.c,
> > we can make the module sysemu-only.
> >
> > Signed-off-by: Claudio Fontana <cfontana@suse.de>
> > Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> > Acked-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > target/s390x/helper.c | 9 +--------
> > target/s390x/meson.build | 2 +-
> > 2 files changed, 2 insertions(+), 9 deletions(-)
> >
> > diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> > index c72e990f4d..a4d4665f67 100644
> > --- a/target/s390x/helper.c
> > +++ b/target/s390x/helper.c
> > @@ -1,5 +1,5 @@
> > /*
> > - * S/390 helpers
> > + * S/390 helpers - systemu only
>
> s/systemu/sysemu/
>
> With that typo fixed:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
That's a stupid mistake, it should be fixed this version.
Will fix it.
Thanks,
AL
next prev parent reply other threads:[~2021-07-02 7:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 14:19 [RFC v6 00/13] s390x cleanup Cho, Yu-Chen
2021-06-29 14:19 ` [RFC v6 01/13] target/s390x: meson: add target_user_arch Cho, Yu-Chen
2021-07-01 15:40 ` Richard Henderson
2021-06-29 14:19 ` [RFC v6 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c Cho, Yu-Chen
2021-07-01 10:11 ` Thomas Huth
2021-07-02 6:54 ` Al Cho
2021-06-29 14:19 ` [RFC v6 03/13] hw/s390x: only build tod-tcg from the CONFIG_TCG build Cho, Yu-Chen
2021-07-01 10:36 ` Thomas Huth
2021-06-29 14:19 ` [RFC v6 04/13] hw/s390x: tod: make explicit checks for accelerators when initializing Cho, Yu-Chen
2021-07-01 10:32 ` Thomas Huth
2021-07-01 15:16 ` Al Cho via
2021-06-29 14:19 ` [RFC v6 05/13] target/s390x: remove tcg-stub.c Cho, Yu-Chen
2021-07-01 10:40 ` Thomas Huth
2021-06-29 14:19 ` [RFC v6 06/13] target/s390x: start moving TCG-only code to tcg/ Cho, Yu-Chen
2021-07-01 10:51 ` Thomas Huth
2021-07-02 7:24 ` Al Cho
2021-06-29 14:19 ` [RFC v6 07/13] target/s390x: move sysemu-only code out to cpu-sysemu.c Cho, Yu-Chen
2021-06-30 15:12 ` Cornelia Huck
2021-07-01 11:41 ` Thomas Huth
2021-06-29 14:19 ` [RFC v6 08/13] target/s390x: split cpu-dump from helper.c Cho, Yu-Chen
2021-07-01 12:35 ` Thomas Huth
2021-07-02 7:25 ` Al Cho
2021-07-05 6:25 ` Claudio Fontana
2021-07-06 8:47 ` Al Cho
2021-07-06 9:06 ` Thomas Huth
2021-07-06 9:19 ` Claudio Fontana
2021-06-29 14:19 ` [RFC v6 09/13] target/s390x: make helper.c sysemu-only Cho, Yu-Chen
2021-07-01 12:36 ` Thomas Huth
2021-07-02 7:27 ` Al Cho [this message]
2021-06-29 14:19 ` [RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m Cho, Yu-Chen
2021-06-30 15:21 ` Cornelia Huck
2021-07-01 5:25 ` Al Cho
2021-07-01 19:16 ` Thomas Huth
2021-06-29 14:19 ` [RFC v6 11/13] target/s390x: remove kvm-stub.c Cho, Yu-Chen
2021-06-30 15:23 ` Cornelia Huck
2021-07-01 19:17 ` Thomas Huth
2021-06-29 14:19 ` [RFC v6 12/13] target/s390x: move kvm files into kvm/ Cho, Yu-Chen
2021-06-30 15:24 ` Cornelia Huck
2021-07-01 19:30 ` Thomas Huth
2021-07-06 18:32 ` Al Cho
2021-06-29 14:19 ` [RFC v6 13/13] target/s390x: split sysemu part of cpu models Cho, Yu-Chen
2021-07-02 7:43 ` Thomas Huth
2021-06-30 15:27 ` [RFC v6 00/13] s390x cleanup Cornelia Huck
2021-07-05 9:34 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1702e9caf6192b2e9b9c068e4b1ca5ec8ca5beee.camel@suse.com \
--to=acho@suse.com \
--cc=Claudio.Fontana@suse.com \
--cc=cfontana@suse.de \
--cc=cohuck@redhat.com \
--cc=jose.ziviani@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).