From: Si-Wei Liu <si-wei.liu@oracle.com>
To: eperezma@redhat.com, jasowang@redhat.com, mst@redhat.com,
dtatulea@nvidia.com, leiyang@redhat.com, yin31149@gmail.com
Cc: qemu-devel@nongnu.org
Subject: [PATCH 03/12] vdpa: factor out vhost_vdpa_last_dev
Date: Wed, 14 Feb 2024 03:27:53 -0800 [thread overview]
Message-ID: <1707910082-10243-4-git-send-email-si-wei.liu@oracle.com> (raw)
In-Reply-To: <1707910082-10243-1-git-send-email-si-wei.liu@oracle.com>
Generalize duplicated condition check for the last vq of vdpa
device to a common function.
Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
---
hw/virtio/vhost-vdpa.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index f7162da..1d3154a 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -551,6 +551,11 @@ static bool vhost_vdpa_first_dev(struct vhost_dev *dev)
return v->index == 0;
}
+static bool vhost_vdpa_last_dev(struct vhost_dev *dev)
+{
+ return dev->vq_index + dev->nvqs == dev->vq_index_end;
+}
+
static int vhost_vdpa_get_dev_features(struct vhost_dev *dev,
uint64_t *features)
{
@@ -1317,7 +1322,7 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev, bool started)
vhost_vdpa_host_notifiers_uninit(dev, dev->nvqs);
}
- if (dev->vq_index + dev->nvqs != dev->vq_index_end) {
+ if (!vhost_vdpa_last_dev(dev)) {
return 0;
}
@@ -1347,7 +1352,7 @@ static void vhost_vdpa_reset_status(struct vhost_dev *dev)
{
struct vhost_vdpa *v = dev->opaque;
- if (dev->vq_index + dev->nvqs != dev->vq_index_end) {
+ if (!vhost_vdpa_last_dev(dev)) {
return;
}
--
1.8.3.1
next prev parent reply other threads:[~2024-02-14 12:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 11:27 [PATCH 00/12] Preparatory patches for live migration downtime improvement Si-Wei Liu
2024-02-14 11:27 ` [PATCH 01/12] vdpa: add back vhost_vdpa_net_first_nc_vdpa Si-Wei Liu
2024-02-14 11:27 ` [PATCH 02/12] vdpa: no repeat setting shadow_data Si-Wei Liu
2024-02-14 11:27 ` Si-Wei Liu [this message]
2024-02-14 11:27 ` [PATCH 04/12] vdpa: factor out vhost_vdpa_net_get_nc_vdpa Si-Wei Liu
2024-02-14 18:54 ` Eugenio Perez Martin
2024-02-14 20:58 ` Si-Wei Liu
2024-02-15 6:33 ` Eugenio Perez Martin
2024-02-14 11:27 ` [PATCH 05/12] vdpa: add vhost_vdpa_set_address_space_id trace Si-Wei Liu
2024-02-14 11:27 ` [PATCH 06/12] vdpa: add vhost_vdpa_get_vring_base trace for svq mode Si-Wei Liu
2024-02-14 11:27 ` [PATCH 07/12] vdpa: add vhost_vdpa_set_dev_vring_base " Si-Wei Liu
2024-02-14 11:27 ` [PATCH 08/12] vdpa: add trace events for vhost_vdpa_net_load_cmd Si-Wei Liu
2024-02-14 11:27 ` [PATCH 09/12] vdpa: add trace event for vhost_vdpa_net_load_mq Si-Wei Liu
2024-02-14 11:28 ` [PATCH 10/12] vdpa: define SVQ transitioning state for mode switching Si-Wei Liu
2024-02-14 11:28 ` [PATCH 11/12] vdpa: indicate transitional state for SVQ switching Si-Wei Liu
2024-02-14 11:28 ` [PATCH 12/12] vdpa: fix network breakage after cancelling migration Si-Wei Liu
2024-02-15 16:15 ` Eugenio Perez Martin
2024-02-15 17:10 ` Eugenio Perez Martin
2024-03-13 18:12 ` Michael Tokarev
2024-03-13 18:52 ` Michael Tokarev
2024-03-13 19:10 ` Si-Wei Liu
2024-03-13 20:41 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1707910082-10243-4-git-send-email-si-wei.liu@oracle.com \
--to=si-wei.liu@oracle.com \
--cc=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yin31149@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).