qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Si-Wei Liu <si-wei.liu@oracle.com>
To: eperezma@redhat.com, jasowang@redhat.com, mst@redhat.com,
	dtatulea@nvidia.com, leiyang@redhat.com, yin31149@gmail.com
Cc: qemu-devel@nongnu.org
Subject: [PATCH 05/12] vdpa: add vhost_vdpa_set_address_space_id trace
Date: Wed, 14 Feb 2024 03:27:55 -0800	[thread overview]
Message-ID: <1707910082-10243-6-git-send-email-si-wei.liu@oracle.com> (raw)
In-Reply-To: <1707910082-10243-1-git-send-email-si-wei.liu@oracle.com>

For better debuggability and observability.

Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
---
 net/trace-events | 3 +++
 net/vhost-vdpa.c | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/net/trace-events b/net/trace-events
index 823a071..aab666a 100644
--- a/net/trace-events
+++ b/net/trace-events
@@ -23,3 +23,6 @@ colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, in
 # filter-rewriter.c
 colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u  flags=0x%x"
 colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u"
+
+# vhost-vdpa.c
+vhost_vdpa_set_address_space_id(void *v, unsigned vq_group, unsigned asid_num) "vhost_vdpa: %p vq_group: %u asid: %u"
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 4168cad..48a5608 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -29,6 +29,7 @@
 #include "migration/migration.h"
 #include "migration/misc.h"
 #include "hw/virtio/vhost.h"
+#include "trace.h"
 
 /* Todo:need to add the multiqueue support here */
 typedef struct VhostVDPAState {
@@ -440,6 +441,8 @@ static int vhost_vdpa_set_address_space_id(struct vhost_vdpa *v,
     };
     int r;
 
+    trace_vhost_vdpa_set_address_space_id(v, vq_group, asid_num);
+
     r = ioctl(v->shared->device_fd, VHOST_VDPA_SET_GROUP_ASID, &asid);
     if (unlikely(r < 0)) {
         error_report("Can't set vq group %u asid %u, errno=%d (%s)",
-- 
1.8.3.1



  parent reply	other threads:[~2024-02-14 12:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 11:27 [PATCH 00/12] Preparatory patches for live migration downtime improvement Si-Wei Liu
2024-02-14 11:27 ` [PATCH 01/12] vdpa: add back vhost_vdpa_net_first_nc_vdpa Si-Wei Liu
2024-02-14 11:27 ` [PATCH 02/12] vdpa: no repeat setting shadow_data Si-Wei Liu
2024-02-14 11:27 ` [PATCH 03/12] vdpa: factor out vhost_vdpa_last_dev Si-Wei Liu
2024-02-14 11:27 ` [PATCH 04/12] vdpa: factor out vhost_vdpa_net_get_nc_vdpa Si-Wei Liu
2024-02-14 18:54   ` Eugenio Perez Martin
2024-02-14 20:58     ` Si-Wei Liu
2024-02-15  6:33       ` Eugenio Perez Martin
2024-02-14 11:27 ` Si-Wei Liu [this message]
2024-02-14 11:27 ` [PATCH 06/12] vdpa: add vhost_vdpa_get_vring_base trace for svq mode Si-Wei Liu
2024-02-14 11:27 ` [PATCH 07/12] vdpa: add vhost_vdpa_set_dev_vring_base " Si-Wei Liu
2024-02-14 11:27 ` [PATCH 08/12] vdpa: add trace events for vhost_vdpa_net_load_cmd Si-Wei Liu
2024-02-14 11:27 ` [PATCH 09/12] vdpa: add trace event for vhost_vdpa_net_load_mq Si-Wei Liu
2024-02-14 11:28 ` [PATCH 10/12] vdpa: define SVQ transitioning state for mode switching Si-Wei Liu
2024-02-14 11:28 ` [PATCH 11/12] vdpa: indicate transitional state for SVQ switching Si-Wei Liu
2024-02-14 11:28 ` [PATCH 12/12] vdpa: fix network breakage after cancelling migration Si-Wei Liu
2024-02-15 16:15   ` Eugenio Perez Martin
2024-02-15 17:10     ` Eugenio Perez Martin
2024-03-13 18:12   ` Michael Tokarev
2024-03-13 18:52     ` Michael Tokarev
2024-03-13 19:10     ` Si-Wei Liu
2024-03-13 20:41       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1707910082-10243-6-git-send-email-si-wei.liu@oracle.com \
    --to=si-wei.liu@oracle.com \
    --cc=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yin31149@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).