qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Si-Wei Liu <si-wei.liu@oracle.com>
To: eperezma@redhat.com, jasowang@redhat.com, mst@redhat.com,
	dtatulea@nvidia.com, leiyang@redhat.com, yin31149@gmail.com
Cc: qemu-devel@nongnu.org
Subject: [PATCH 07/12] vdpa: add vhost_vdpa_set_dev_vring_base trace for svq mode
Date: Wed, 14 Feb 2024 03:27:57 -0800	[thread overview]
Message-ID: <1707910082-10243-8-git-send-email-si-wei.liu@oracle.com> (raw)
In-Reply-To: <1707910082-10243-1-git-send-email-si-wei.liu@oracle.com>

For better debuggability and observability.

Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
---
 hw/virtio/trace-events | 2 +-
 hw/virtio/vhost-vdpa.c | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index 28d6d78..20577aa 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -57,7 +57,7 @@ vhost_vdpa_dev_start(void *dev, bool started) "dev: %p started: %d"
 vhost_vdpa_set_log_base(void *dev, uint64_t base, unsigned long long size, int refcnt, int fd, void *log) "dev: %p base: 0x%"PRIx64" size: %llu refcnt: %d fd: %d log: %p"
 vhost_vdpa_set_vring_addr(void *dev, unsigned int index, unsigned int flags, uint64_t desc_user_addr, uint64_t used_user_addr, uint64_t avail_user_addr, uint64_t log_guest_addr) "dev: %p index: %u flags: 0x%x desc_user_addr: 0x%"PRIx64" used_user_addr: 0x%"PRIx64" avail_user_addr: 0x%"PRIx64" log_guest_addr: 0x%"PRIx64
 vhost_vdpa_set_vring_num(void *dev, unsigned int index, unsigned int num) "dev: %p index: %u num: %u"
-vhost_vdpa_set_vring_base(void *dev, unsigned int index, unsigned int num) "dev: %p index: %u num: %u"
+vhost_vdpa_set_dev_vring_base(void *dev, unsigned int index, unsigned int num, bool svq) "dev: %p index: %u num: %u svq: %d"
 vhost_vdpa_get_vring_base(void *dev, unsigned int index, unsigned int num, bool svq) "dev: %p index: %u num: %u svq: %d"
 vhost_vdpa_set_vring_kick(void *dev, unsigned int index, int fd) "dev: %p index: %u fd: %d"
 vhost_vdpa_set_vring_call(void *dev, unsigned int index, int fd) "dev: %p index: %u fd: %d"
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 0de7bdf..004110f 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -972,7 +972,10 @@ static int vhost_vdpa_get_config(struct vhost_dev *dev, uint8_t *config,
 static int vhost_vdpa_set_dev_vring_base(struct vhost_dev *dev,
                                          struct vhost_vring_state *ring)
 {
-    trace_vhost_vdpa_set_vring_base(dev, ring->index, ring->num);
+    struct vhost_vdpa *v = dev->opaque;
+
+    trace_vhost_vdpa_set_dev_vring_base(dev, ring->index, ring->num,
+                                        v->shadow_vqs_enabled);
     return vhost_vdpa_call(dev, VHOST_SET_VRING_BASE, ring);
 }
 
-- 
1.8.3.1



  parent reply	other threads:[~2024-02-14 12:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 11:27 [PATCH 00/12] Preparatory patches for live migration downtime improvement Si-Wei Liu
2024-02-14 11:27 ` [PATCH 01/12] vdpa: add back vhost_vdpa_net_first_nc_vdpa Si-Wei Liu
2024-02-14 11:27 ` [PATCH 02/12] vdpa: no repeat setting shadow_data Si-Wei Liu
2024-02-14 11:27 ` [PATCH 03/12] vdpa: factor out vhost_vdpa_last_dev Si-Wei Liu
2024-02-14 11:27 ` [PATCH 04/12] vdpa: factor out vhost_vdpa_net_get_nc_vdpa Si-Wei Liu
2024-02-14 18:54   ` Eugenio Perez Martin
2024-02-14 20:58     ` Si-Wei Liu
2024-02-15  6:33       ` Eugenio Perez Martin
2024-02-14 11:27 ` [PATCH 05/12] vdpa: add vhost_vdpa_set_address_space_id trace Si-Wei Liu
2024-02-14 11:27 ` [PATCH 06/12] vdpa: add vhost_vdpa_get_vring_base trace for svq mode Si-Wei Liu
2024-02-14 11:27 ` Si-Wei Liu [this message]
2024-02-14 11:27 ` [PATCH 08/12] vdpa: add trace events for vhost_vdpa_net_load_cmd Si-Wei Liu
2024-02-14 11:27 ` [PATCH 09/12] vdpa: add trace event for vhost_vdpa_net_load_mq Si-Wei Liu
2024-02-14 11:28 ` [PATCH 10/12] vdpa: define SVQ transitioning state for mode switching Si-Wei Liu
2024-02-14 11:28 ` [PATCH 11/12] vdpa: indicate transitional state for SVQ switching Si-Wei Liu
2024-02-14 11:28 ` [PATCH 12/12] vdpa: fix network breakage after cancelling migration Si-Wei Liu
2024-02-15 16:15   ` Eugenio Perez Martin
2024-02-15 17:10     ` Eugenio Perez Martin
2024-03-13 18:12   ` Michael Tokarev
2024-03-13 18:52     ` Michael Tokarev
2024-03-13 19:10     ` Si-Wei Liu
2024-03-13 20:41       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1707910082-10243-8-git-send-email-si-wei.liu@oracle.com \
    --to=si-wei.liu@oracle.com \
    --cc=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yin31149@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).