From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z30zf-0004LB-Ec for qemu-devel@nongnu.org; Thu, 11 Jun 2015 07:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z30zb-0001eT-Ro for qemu-devel@nongnu.org; Thu, 11 Jun 2015 07:49:59 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:39574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z30zb-0001ds-La for qemu-devel@nongnu.org; Thu, 11 Jun 2015 07:49:55 -0400 Date: Thu, 11 Jun 2015 07:49:51 -0400 (EDT) From: Pankaj Gupta Message-ID: <1708114508.14108746.1434023391416.JavaMail.zimbra@redhat.com> In-Reply-To: <557530D5.2050807@redhat.com> References: <1433514749-19584-1-git-send-email-pagupta@redhat.com> <557530D5.2050807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] net:Enable vhost with vhostforce, vhost options for guests without MSI-X support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , mst@redhat.com Cc: qemu-devel@nongnu.org, stefanha@redhat.com, aliguori@amazon.com > > On 06/05/2015 10:32 PM, Pankaj Gupta wrote: > > We use vhostforce to enable vhost even if Guests don't have MSI-X > > support > > and we fall back to QEMU virtio-net. This patch will enable vhost > > unconditionally > > whenever we have vhostforce='ON' or vhost='ON'. > > > > Initially, I wanted to remove vhostforce completely as an additional > > argument. > > But after discussing this in mailing list found that some programs are > > using vhostforce > > and some vhost. So, we want to keep semantics of both the options. > > > > Signed-off-by: Pankaj Gupta > > --- > > net/tap.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/net/tap.c b/net/tap.c > > index d1ca314..4618359 100644 > > --- a/net/tap.c > > +++ b/net/tap.c > > @@ -649,13 +649,13 @@ static void net_init_tap_one(const NetdevTapOptions > > *tap, NetClientState *peer, > > } > > } > > > > - if (tap->has_vhost ? tap->vhost : > > - vhostfdname || (tap->has_vhostforce && tap->vhostforce)) { > > + if ((tap->has_vhost ? tap->vhost : > > + vhostfdname) || tap->vhostforce) { > > VhostNetOptions options; > > > > options.backend_type = VHOST_BACKEND_TYPE_KERNEL; > > options.net_backend = &s->nc; > > - options.force = tap->has_vhostforce && tap->vhostforce; > > + options.force = true; > > > > if (tap->has_vhostfd || tap->has_vhostfds) { > > vhostfd = monitor_fd_param(cur_mon, vhostfdname, &err); > > In this case, I believe there's no need to have vhost_net_query() and > query_guest_notifiers() callbacks (and maybe more others). I also thought on this. If same functions can be used by some other module in future? If not, I was thinking to remove those in another patch. Does the main functionality looks OK? >