qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Ani Sinha <anisinha@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] loader: remove load_image_gzipped function as its not used anywhere
Date: Thu, 11 Jul 2024 15:58:30 +0200	[thread overview]
Message-ID: <17142a76-0c05-49e7-8e8b-722eecf22ff0@linaro.org> (raw)
In-Reply-To: <20240711072448.32673-1-anisinha@redhat.com>

On 11/7/24 09:24, Ani Sinha wrote:
> load_image_gzipped() does not seem to be used anywhere. Remove it.
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
>   hw/core/loader.c    | 13 -------------
>   include/hw/loader.h |  4 +---
>   2 files changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index a3bea1e718..c04fae55c0 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -845,19 +845,6 @@ ssize_t load_image_gzipped_buffer(const char *filename, uint64_t max_sz,
>       return ret;
>   }
>   
> -/* Load a gzip-compressed kernel. */
> -ssize_t load_image_gzipped(const char *filename, hwaddr addr, uint64_t max_sz)
> -{
> -    ssize_t bytes;
> -    uint8_t *data;
> -
> -    bytes = load_image_gzipped_buffer(filename, max_sz, &data);
> -    if (bytes != -1) {
> -        rom_add_blob_fixed(filename, data, bytes, addr);
> -        g_free(data);
> -    }
> -    return bytes;
> -}

Indeed last one removed in commit 68115ed5fc ("hw/arm/boot: take
Linux/arm64 TEXT_OFFSET header field into account").

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  parent reply	other threads:[~2024-07-11 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11  7:24 [PATCH] loader: remove load_image_gzipped function as its not used anywhere Ani Sinha
2024-07-11 10:23 ` Peter Maydell
2024-07-11 13:58 ` Philippe Mathieu-Daudé [this message]
2024-07-15  9:51 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17142a76-0c05-49e7-8e8b-722eecf22ff0@linaro.org \
    --to=philmd@linaro.org \
    --cc=anisinha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).