From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDTCr-0002sB-SG for qemu-devel@nongnu.org; Fri, 19 Oct 2018 07:44:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDTCm-0008Qv-Um for qemu-devel@nongnu.org; Fri, 19 Oct 2018 07:44:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gDTCl-0008N3-En for qemu-devel@nongnu.org; Fri, 19 Oct 2018 07:44:36 -0400 References: <1539894735-14232-1-git-send-email-pbonzini@redhat.com> <1539894735-14232-7-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <171fc99b-92a4-1b2f-dc64-0e8c5d92a5c4@redhat.com> Date: Fri, 19 Oct 2018 13:44:29 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 06/48] target-i386: kvm: do not initialize padding fields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 19/10/2018 11:03, Peter Maydell wrote: > On 18 October 2018 at 21:31, Paolo Bonzini wrote: >> The exception.pad field is going to be renamed to pending in an upcoming >> header file update. Remove the unnecessary initialization; it was >> introduced to please valgrind (commit 7e680753cfa2) but they were later >> rendered unnecessary by commit 076796f8fd27f4d, which added the "= {}" >> initializer to the declaration of "events". Therefore the patch does >> not change behavior in any way. >> >> Signed-off-by: Paolo Bonzini > > Reviewed-by: Peter Maydell > > thanks > -- PMM > I'll include your R-b in v3. Paolo