From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1Zi0p8-0002sg-AX
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:56:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1Zi0p2-0007Cr-JB
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:56:34 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:59883)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1Zi0p2-0007Ci-Bp
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:56:28 -0400
Date: Fri, 2 Oct 2015 09:56:17 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <1726570872.23125054.1443794177275.JavaMail.zimbra@redhat.com>
In-Reply-To: <20151002163907-mutt-send-email-mst@redhat.com>
References: <1443720248-15482-1-git-send-email-marcandre.lureau@redhat.com>
	<1443720248-15482-4-git-send-email-marcandre.lureau@redhat.com>
	<20151002163907-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 03/24] util: add linux-only memfd
	fallback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: haifeng lin <haifeng.lin@huawei.com>, thibaut collet <thibaut.collet@6wind.com>, jasowang@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, marcandre lureau <marcandre.lureau@redhat.com>

Hi

----- Original Message -----
> On Thu, Oct 01, 2015 at 07:23:47PM +0200, marcandre.lureau@redhat.com wrote:
> > diff --git a/util/Makefile.objs b/util/Makefile.objs
> > index 372e037..9e05861 100644
> > --- a/util/Makefile.objs
> > +++ b/util/Makefile.objs
> > @@ -1,13 +1,18 @@
> >  util-obj-y = osdep.o cutils.o unicode.o qemu-timer-common.o
> >  util-obj-$(CONFIG_WIN32) += oslib-win32.o qemu-thread-win32.o
> >  event_notifier-win32.o
> > -util-obj-$(CONFIG_POSIX) += oslib-posix.o qemu-thread-posix.o
> > event_notifier-posix.o qemu-openpty.o mmap-alloc.o
> > +util-obj-$(CONFIG_POSIX) += oslib-posix.o
> > +util-obj-$(CONFIG_POSIX) += qemu-thread-posix.o
> > +util-obj-$(CONFIG_POSIX) += event_notifier-posix.o
> > +util-obj-$(CONFIG_POSIX) += qemu-openpty.o
> > +util-obj-$(CONFIG_POSIX) += compatfd.o
> > +util-obj-$(CONFIG_POSIX) += mmap-alloc.o
> > +util-obj-$(CONFIG_POSIX) += memfd.o
> >  util-obj-y += envlist.o path.o module.o
> >  util-obj-$(call lnot,$(CONFIG_INT128)) += host-utils.o
> >  util-obj-y += bitmap.o bitops.o hbitmap.o
> >  util-obj-y += fifo8.o
> >  util-obj-y += acl.o
> >  util-obj-y += error.o qemu-error.o
> > -util-obj-$(CONFIG_POSIX) += compatfd.o
> >  util-obj-y += id.o
> >  util-obj-y += iov.o qemu-config.o qemu-sockets.o uri.o notify.o
> >  util-obj-y += qemu-option.o qemu-progress.o
> 
> Will be easier to apply if this refactoring is a separate patch.
> 
> 
Sure, would you mind to do it if you pick the series, or does this deserve another update?