From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v9 6/8] throttle: add the name of the ThrottleGroup to BlockDeviceInfo
Date: Mon, 8 Jun 2015 18:17:46 +0200 [thread overview]
Message-ID: <172df91f09c69c6f0440a697bbd1b3f95b077ee4.1433779731.git.berto@igalia.com> (raw)
In-Reply-To: <cover.1433779731.git.berto@igalia.com>
In-Reply-To: <cover.1433779731.git.berto@igalia.com>
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/qapi.c | 3 +++
hmp.c | 6 ++++--
qapi/block-core.json | 4 +++-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index a5ac312..a738148 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -93,6 +93,9 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState *bs, Error **errp)
info->has_iops_size = cfg.op_size;
info->iops_size = cfg.op_size;
+
+ info->has_group = true;
+ info->group = g_strdup(throttle_group_get_name(bs));
}
info->write_threshold = bdrv_write_threshold_get(bs);
diff --git a/hmp.c b/hmp.c
index eb5ef61..8fac44a 100644
--- a/hmp.c
+++ b/hmp.c
@@ -399,7 +399,8 @@ static void print_block_info(Monitor *mon, BlockInfo *info,
" iops_max=%" PRId64
" iops_rd_max=%" PRId64
" iops_wr_max=%" PRId64
- " iops_size=%" PRId64 "\n",
+ " iops_size=%" PRId64
+ " group=%s\n",
inserted->bps,
inserted->bps_rd,
inserted->bps_wr,
@@ -412,7 +413,8 @@ static void print_block_info(Monitor *mon, BlockInfo *info,
inserted->iops_max,
inserted->iops_rd_max,
inserted->iops_wr_max,
- inserted->iops_size);
+ inserted->iops_size,
+ inserted->group);
}
if (verbose) {
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 3087154..afa9d3d 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -259,6 +259,8 @@
#
# @iops_size: #optional an I/O size in bytes (Since 1.7)
#
+# @group: #optional throttle group name (Since 2.4)
+#
# @cache: the cache mode used for the block device (since: 2.3)
#
# @write_threshold: configured write threshold for the device.
@@ -278,7 +280,7 @@
'*bps_max': 'int', '*bps_rd_max': 'int',
'*bps_wr_max': 'int', '*iops_max': 'int',
'*iops_rd_max': 'int', '*iops_wr_max': 'int',
- '*iops_size': 'int', 'cache': 'BlockdevCacheInfo',
+ '*iops_size': 'int', '*group': 'str', 'cache': 'BlockdevCacheInfo',
'write_threshold': 'int' } }
##
--
2.1.4
next prev parent reply other threads:[~2015-06-08 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 16:17 [Qemu-devel] [PATCH v9 0/8] Block Throttle Group Support Alberto Garcia
2015-06-08 16:17 ` [Qemu-devel] [PATCH v9 1/8] throttle: Extract timers from ThrottleState into a separate structure Alberto Garcia
2015-06-08 16:17 ` [Qemu-devel] [PATCH v9 2/8] throttle: Add throttle group infrastructure Alberto Garcia
2015-06-08 16:17 ` [Qemu-devel] [PATCH v9 3/8] throttle: Add throttle group infrastructure tests Alberto Garcia
2015-06-08 16:17 ` [Qemu-devel] [PATCH v9 4/8] throttle: Add throttle group support Alberto Garcia
2015-06-08 16:17 ` [Qemu-devel] [PATCH v9 5/8] throttle: acquire the ThrottleGroup lock in bdrv_swap() Alberto Garcia
2015-06-08 16:17 ` Alberto Garcia [this message]
2015-06-08 16:17 ` [Qemu-devel] [PATCH v9 7/8] throttle: Update throttle infrastructure copyright Alberto Garcia
2015-06-08 16:17 ` [Qemu-devel] [PATCH v9 8/8] qemu-iotests: expand test 093 to support group throttling Alberto Garcia
2015-06-12 13:01 ` [Qemu-devel] [PATCH v9 0/8] Block Throttle Group Support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172df91f09c69c6f0440a697bbd1b3f95b077ee4.1433779731.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).