From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F4AC47404 for ; Fri, 11 Oct 2019 07:51:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EE5E20679 for ; Fri, 11 Oct 2019 07:51:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EE5E20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIpi8-0000vX-AX for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 03:51:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36864) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIpgL-0007W5-PA for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:49:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIpgK-0006Vd-7j for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:49:49 -0400 Received: from mga09.intel.com ([134.134.136.24]:61216) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIpgK-0006Us-04 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:49:48 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 00:49:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,283,1566889200"; d="scan'208";a="193458532" Received: from txu2-mobl.ccr.corp.intel.com (HELO [10.239.196.168]) ([10.239.196.168]) by fmsmga008.fm.intel.com with ESMTP; 11 Oct 2019 00:49:44 -0700 Subject: Re: [PATCH RESEND v6 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE To: "pbonzini@redhat.com" References: <20191011074103.30393-1-tao3.xu@intel.com> <20191011074103.30393-2-tao3.xu@intel.com> From: Tao Xu Message-ID: <1731d87f-f07a-916f-90a7-346b593d821e@intel.com> Date: Fri, 11 Oct 2019 15:49:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191011074103.30393-2-tao3.xu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ehabkost@redhat.com" , "kvm@vger.kernel.org" , "Liu, Jingqi" , "mtosatti@redhat.com" , "qemu-devel@nongnu.org" , "rth@twiddle.net" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/11/2019 3:41 PM, Xu, Tao3 wrote: [...] > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 11b9c854b5..a465c893b5 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@ -401,6 +401,12 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function, > if (host_tsx_blacklisted()) { > ret &= ~(CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_HLE); > } > + } else if (function == 7 && index == 0 && reg == R_ECX) { > + if (enable_cpu_pm) { > + ret |= CPUID_7_0_ECX_WAITPKG; > + } else { > + ret &= ~CPUID_7_0_ECX_WAITPKG; > + } Hi Paolo, I am sorry because I realize in KVM side, I keep cpuid mask WAITPKG as 0: F(CLDEMOTE) | F(MOVDIRI) | F(MOVDIR64B) | 0 /*WAITPKG*/; Therefore in QEMU side, we need to add CPUID_7_0_ECX_WAITPKG when enable_cpu_pm is on. Otherwise, QEMU can't get this CPUID. Could you review this part again? Thank you very much! Tao